Skip to content

Commit fd29fa6

Browse files
committed
Remove a couple tests just testing the mocks
1 parent c801132 commit fd29fa6

File tree

3 files changed

+1
-70
lines changed

3 files changed

+1
-70
lines changed

RetailCoder.VBE/Refactorings/RemoveParameters/IRemoveParametersDialog.cs

Lines changed: 0 additions & 10 deletions
This file was deleted.

RetailCoder.VBE/Rubberduck.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -577,7 +577,6 @@
577577
<Compile Include="Refactorings\IntroduceField\IntroduceFieldRefactoring.cs" />
578578
<Compile Include="Refactorings\IntroduceParameter\IntroduceParameterRefactoring.cs" />
579579
<Compile Include="Refactorings\MoveCloserToUsage\MoveCloserToUsageRefactoring.cs" />
580-
<Compile Include="Refactorings\RemoveParameters\IRemoveParametersDialog.cs" />
581580
<Compile Include="Refactorings\RemoveParameters\Parameter.cs" />
582581
<Compile Include="Refactorings\RemoveParameters\RemoveParametersModel.cs" />
583582
<Compile Include="Refactorings\RemoveParameters\RemoveParametersPresenter.cs" />

RubberduckTests/Refactoring/RemoveParametersTests.cs

Lines changed: 1 addition & 59 deletions
Original file line numberDiff line numberDiff line change
@@ -1578,7 +1578,7 @@ public void RemoveParams_RefactorDeclaration_FailsInvalidTarget()
15781578
{
15791579
refactoring.Refactor(
15801580
model.Declarations.FirstOrDefault(
1581-
i => i.DeclarationType == Rubberduck.Parsing.Symbols.DeclarationType.ProceduralModule));
1581+
i => i.DeclarationType == DeclarationType.ProceduralModule));
15821582
}
15831583
catch (ArgumentException e)
15841584
{
@@ -1636,64 +1636,6 @@ public void RemoveParams_ModelIsNull()
16361636
Assert.AreEqual(inputCode, component.CodeModule.Content());
16371637
}
16381638

1639-
[TestMethod]
1640-
public void Presenter_Accept_ReturnsModelWithParametersChanged()
1641-
{
1642-
//Input
1643-
const string inputCode =
1644-
@"Private Sub Foo(ByVal arg1 As Integer, ByVal arg2 As String)
1645-
End Sub";
1646-
var selection = new Selection(1, 15, 1, 15);
1647-
1648-
IVBComponent component;
1649-
var vbe = MockVbeBuilder.BuildFromSingleStandardModule(inputCode, out component, selection);
1650-
1651-
var state = MockParser.CreateAndParse(vbe.Object);
1652-
var qualifiedSelection = new QualifiedSelection(new QualifiedModuleName(component), selection);
1653-
1654-
var model = new RemoveParametersModel(state, qualifiedSelection, new Mock<IMessageBox>().Object);
1655-
model.Parameters[1].IsRemoved = true;
1656-
1657-
var view = new Mock<IRemoveParametersDialog>();
1658-
view.Setup(v => v.ShowDialog()).Returns(DialogResult.OK);
1659-
view.Setup(v => v.Parameters).Returns(model.Parameters);
1660-
1661-
var factory = new RemoveParametersPresenterFactory(vbe.Object, view.Object, state, null);
1662-
1663-
var presenter = factory.Create();
1664-
1665-
Assert.AreEqual(model.Parameters, presenter.Show().Parameters);
1666-
}
1667-
1668-
[TestMethod]
1669-
public void Presenter_Reject_ReturnsNull()
1670-
{
1671-
//Input
1672-
const string inputCode =
1673-
@"Private Sub Foo(ByVal arg1 As Integer, ByVal arg2 As String)
1674-
End Sub";
1675-
var selection = new Selection(1, 15, 1, 15);
1676-
1677-
IVBComponent component;
1678-
var vbe = MockVbeBuilder.BuildFromSingleStandardModule(inputCode, out component, selection);
1679-
1680-
var state = MockParser.CreateAndParse(vbe.Object);
1681-
var qualifiedSelection = new QualifiedSelection(new QualifiedModuleName(component), selection);
1682-
1683-
var model = new RemoveParametersModel(state, qualifiedSelection, new Mock<IMessageBox>().Object);
1684-
model.Parameters[1].IsRemoved = true;
1685-
1686-
var view = new Mock<IRemoveParametersDialog>();
1687-
view.Setup(v => v.ShowDialog()).Returns(DialogResult.Cancel);
1688-
view.Setup(v => v.Parameters).Returns(model.Parameters);
1689-
1690-
var factory = new RemoveParametersPresenterFactory(vbe.Object, view.Object, state, null);
1691-
1692-
var presenter = factory.Create();
1693-
1694-
Assert.AreEqual(null, presenter.Show());
1695-
}
1696-
16971639
[TestMethod]
16981640
public void Presenter_Accept_AutoMarksSingleParamAsRemoved()
16991641
{

0 commit comments

Comments
 (0)