Update/add tests

Author: Hosch250

RetailCoder.VBE/UI/SourceControl/SettingsViewViewModel.cs

@@ -128,6 +128,7 @@ private void CancelSettingsChanges()
             UserName = _config.UserName;
             EmailAddress = _config.EmailAddress;
             DefaultRepositoryLocation = _config.DefaultRepositoryLocation;
+            CommandPromptLocation = _config.CommandPromptLocation;
         }
 
         private void UpdateSettings()

RubberduckTests/SourceControl/SettingsViewModelTests.cs

@@ -14,21 +14,25 @@ public class SettingsViewModelTests
         private const string Name = "Chris McClellan";
         private const string Email = "ckuhn203@gmail";
         private const string RepoLocation = @"C:\Users\Christopher\Documents";
+        private const string CommandPromptLocation = "cmd.exe";
 
         private const string OtherName = "King Lear";
         private const string OtherEmail = "king.lear@yahoo.com";
         private const string OtherRepoLocation = @"C:\Users\KingLear\Documents";
+        private const string OtherCommandPromptLocation = @"C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe";
 
         private Mock<ISourceControlConfigProvider> _configService;
         private SourceControlSettings _config;
 
         private Mock<IFolderBrowserFactory> _folderBrowserFactory;
         private Mock<IFolderBrowser> _folderBrowser;
 
+        private Mock<IOpenFileDialog> _openFileDialog;
+
         [TestInitialize]
         public void Initialize()
         {
-            _config = new SourceControlSettings(Name, Email, RepoLocation, new List<Repository>(), "cmd.exe");
+            _config = new SourceControlSettings(Name, Email, RepoLocation, new List<Repository>(), CommandPromptLocation);
 
             _configService = new Mock<ISourceControlConfigProvider>();
             _configService.Setup(s => s.Create()).Returns(_config);
@@ -37,13 +41,15 @@ public void Initialize()
             _folderBrowserFactory = new Mock<IFolderBrowserFactory>();
             _folderBrowserFactory.Setup(f => f.CreateFolderBrowser(It.IsAny<string>())).Returns(_folderBrowser.Object);
             _folderBrowserFactory.Setup(f => f.CreateFolderBrowser(It.IsAny<string>(), false)).Returns(_folderBrowser.Object);
+
+            _openFileDialog = new Mock<IOpenFileDialog>();
         }
 
         [TestMethod]
         public void ViewIsPopulatedOnRefresh()
         {
             //arrange
-            var vm = new SettingsViewViewModel(_configService.Object, _folderBrowserFactory.Object, new Rubberduck.UI.OpenFileDialog());
+            var vm = new SettingsViewViewModel(_configService.Object, _folderBrowserFactory.Object, _openFileDialog.Object);
 
             //act
             vm.RefreshView();
@@ -52,18 +58,20 @@ public void ViewIsPopulatedOnRefresh()
             Assert.AreEqual(Name, vm.UserName, "Name");
             Assert.AreEqual(Email, vm.EmailAddress, "Email");
             Assert.AreEqual(RepoLocation, vm.DefaultRepositoryLocation, "Default Repo Location");
+            Assert.AreEqual(CommandPromptLocation, vm.CommandPromptLocation, "Command Prompt Location");
         }
 
         [TestMethod]
         public void ConfigIsPopulatedFromViewOnSave()
         {
             //arrange
-            var vm = new SettingsViewViewModel(_configService.Object, _folderBrowserFactory.Object, new Rubberduck.UI.OpenFileDialog());
+            var vm = new SettingsViewViewModel(_configService.Object, _folderBrowserFactory.Object, _openFileDialog.Object);
 
             //simulate user input
             vm.UserName = OtherName;
             vm.EmailAddress = OtherEmail;
             vm.DefaultRepositoryLocation = OtherRepoLocation;
+            vm.CommandPromptLocation = OtherCommandPromptLocation;
 
             //simulate Update button click
             vm.UpdateSettingsCommand.Execute(null);
@@ -72,13 +80,14 @@ public void ConfigIsPopulatedFromViewOnSave()
             Assert.AreEqual(OtherName, _config.UserName, "Name");
             Assert.AreEqual(OtherEmail, _config.EmailAddress, "Email");
             Assert.AreEqual(OtherRepoLocation, _config.DefaultRepositoryLocation, "Default Repo Location");
+            Assert.AreEqual(OtherCommandPromptLocation, _config.CommandPromptLocation, "Command Prompt Location");
         }
 
         [TestMethod]
         public void ConfigIsSavedOnSave()
         {
             //arrange
-            var vm = new SettingsViewViewModel(_configService.Object, _folderBrowserFactory.Object, new Rubberduck.UI.OpenFileDialog());
+            var vm = new SettingsViewViewModel(_configService.Object, _folderBrowserFactory.Object, _openFileDialog.Object);
 
             //act
             //simulate Update button click
@@ -92,12 +101,13 @@ public void ConfigIsSavedOnSave()
         public void ChangesToViewAreRevertedOnCancel()
         {
             //arrange
-            var vm = new SettingsViewViewModel(_configService.Object, _folderBrowserFactory.Object, new Rubberduck.UI.OpenFileDialog());
+            var vm = new SettingsViewViewModel(_configService.Object, _folderBrowserFactory.Object, _openFileDialog.Object);
 
             //simulate user input
             vm.UserName = OtherName;
             vm.EmailAddress = OtherEmail;
             vm.DefaultRepositoryLocation = OtherRepoLocation;
+            vm.DefaultRepositoryLocation = OtherCommandPromptLocation;
 
             //act
             //simulate Cancel button click
@@ -107,13 +117,14 @@ public void ChangesToViewAreRevertedOnCancel()
             Assert.AreEqual(Name, vm.UserName, "Name");
             Assert.AreEqual(Email, vm.EmailAddress, "Email");
             Assert.AreEqual(RepoLocation, vm.DefaultRepositoryLocation, "Default Repo Location");
+            Assert.AreEqual(CommandPromptLocation, vm.CommandPromptLocation, "Command Prompt Location");
         }
 
         [TestMethod]
         public void OnBrowseDefaultRepoLocation_WhenUserConfirms_ViewMatchesSelectedPath()
         {
             //arrange
-            var vm = new SettingsViewViewModel(_configService.Object, _folderBrowserFactory.Object, new Rubberduck.UI.OpenFileDialog())
+            var vm = new SettingsViewViewModel(_configService.Object, _folderBrowserFactory.Object, _openFileDialog.Object)
             {
                 DefaultRepositoryLocation = RepoLocation
             };
@@ -128,10 +139,10 @@ public void OnBrowseDefaultRepoLocation_WhenUserConfirms_ViewMatchesSelectedPath
         }
 
         [TestMethod]
-        public void OnBrowserDefaultRepoLocation_WhenUserCancels_ViewRemainsUnchanged()
+        public void OnBrowseDefaultRepoLocation_WhenUserCancels_ViewRemainsUnchanged()
         {
             //arrange
-            var vm = new SettingsViewViewModel(_configService.Object, _folderBrowserFactory.Object, new Rubberduck.UI.OpenFileDialog())
+            var vm = new SettingsViewViewModel(_configService.Object, _folderBrowserFactory.Object, _openFileDialog.Object)
             {
                 DefaultRepositoryLocation = RepoLocation
             };
@@ -144,5 +155,41 @@ public void OnBrowserDefaultRepoLocation_WhenUserCancels_ViewRemainsUnchanged()
             //assert
             Assert.AreEqual(RepoLocation, vm.DefaultRepositoryLocation);
         }
+
+        [TestMethod]
+        public void OnBrowseCommandPromptLocation_WhenUserConfirms_ViewMatchesSelectedPath()
+        {
+            //arrange
+            var vm = new SettingsViewViewModel(_configService.Object, _folderBrowserFactory.Object, _openFileDialog.Object)
+            {
+                CommandPromptLocation = CommandPromptLocation
+            };
+            _openFileDialog.Setup(o => o.FileName).Returns(OtherCommandPromptLocation);
+            _openFileDialog.Setup(o => o.ShowDialog()).Returns(DialogResult.OK);
+
+            //act
+            vm.ShowCommandPromptExePickerCommand.Execute(null);
+
+            //assert
+            Assert.AreEqual(_openFileDialog.Object.FileName, vm.CommandPromptLocation);
+        }
+
+        [TestMethod]
+        public void OnBrowseCommandPromptLocation_WhenUserCancels_ViewRemainsUnchanged()
+        {
+            //arrange
+            var vm = new SettingsViewViewModel(_configService.Object, _folderBrowserFactory.Object, _openFileDialog.Object)
+            {
+                CommandPromptLocation = CommandPromptLocation
+            };
+            _openFileDialog.Setup(o => o.FileName).Returns(OtherCommandPromptLocation);
+            _openFileDialog.Setup(o => o.ShowDialog()).Returns(DialogResult.Cancel);
+
+            //act
+            vm.ShowDefaultRepoFolderPickerCommand.Execute(null);
+
+            //assert
+            Assert.AreEqual(CommandPromptLocation, vm.CommandPromptLocation);
+        }
     }
 }