Skip to content

Commit fb86e37

Browse files
retailcoderretailcoder
committed
put all inspection tests in "Inspections" test category
1 parent 9690fbc commit fb86e37

32 files changed

+266
-6
lines changed

‎RetailCoder.VBE/Inspections/ObjectVariableNotSetInspection.cs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,14 +88,16 @@ public override IEnumerable<InspectionResultBase> GetInspectionResults()
8888
{
8989
return State.AllUserDeclarations
9090
.Where(item => !ValueTypes.Contains(item.AsTypeName)
91+
&& (item.AsTypeDeclaration != null && item.AsTypeDeclaration.DeclarationType != DeclarationType.UserDefinedType)
9192
&& !item.IsSelfAssigned
92-
&& (item.DeclarationType == DeclarationType.Variable
93-
|| item.DeclarationType == DeclarationType.Parameter))
93+
&& (item.DeclarationType == DeclarationType.Variable
94+
|| item.DeclarationType == DeclarationType.Parameter))
9495
.SelectMany(declaration =>
9596
declaration.References.Where(reference =>
9697
{
9798
var k = reference.Context.parent.GetType();
98-
var setStmtContext = ParserRuleContextHelper.GetParent<VBAParser.LetStmtContext>(reference.Context);
99+
var setStmtContext =
100+
ParserRuleContextHelper.GetParent<VBAParser.LetStmtContext>(reference.Context);
99101
return setStmtContext != null && setStmtContext.LET() == null;
100102
}))
101103
.Select(reference => new ObjectVariableNotSetInspectionResult(this, reference));

‎RubberduckTests/Inspections/AssignedByValParameterInspectionTests.cs

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ namespace RubberduckTests.Inspections
1414
public class AssignedByValParameterInspectionTests
1515
{
1616
[TestMethod]
17+
[TestCategory("Inspections")]
1718
public void AssignedByValParameter_ReturnsResult_Sub()
1819
{
1920
const string inputCode =
@@ -39,6 +40,7 @@ public void AssignedByValParameter_ReturnsResult_Sub()
3940
}
4041

4142
[TestMethod]
43+
[TestCategory("Inspections")]
4244
public void AssignedByValParameter_ReturnsResult_Function()
4345
{
4446
const string inputCode =
@@ -64,6 +66,7 @@ public void AssignedByValParameter_ReturnsResult_Function()
6466
}
6567

6668
[TestMethod]
69+
[TestCategory("Inspections")]
6770
public void AssignedByValParameter_ReturnsResult_MultipleParams()
6871
{
6972
const string inputCode =
@@ -90,6 +93,7 @@ public void AssignedByValParameter_ReturnsResult_MultipleParams()
9093
}
9194

9295
[TestMethod]
96+
[TestCategory("Inspections")]
9397
public void AssignedByValParameter_DoesNotReturnResult()
9498
{
9599
const string inputCode =
@@ -114,6 +118,7 @@ public void AssignedByValParameter_DoesNotReturnResult()
114118
}
115119

116120
[TestMethod]
121+
[TestCategory("Inspections")]
117122
public void AssignedByValParameter_ReturnsResult_SomeAssignedByValParams()
118123
{
119124
const string inputCode =
@@ -142,6 +147,7 @@ Dim var1 As Integer
142147
}
143148

144149
[TestMethod]
150+
[TestCategory("Inspections")]
145151
public void AssignedByValParameter_QuickFixWorks()
146152
{
147153
const string inputCode =
@@ -176,13 +182,15 @@ public void AssignedByValParameter_QuickFixWorks()
176182
}
177183

178184
[TestMethod]
185+
[TestCategory("Inspections")]
179186
public void InspectionType()
180187
{
181188
var inspection = new AssignedByValParameterInspection(null);
182189
Assert.AreEqual(CodeInspectionType.CodeQualityIssues, inspection.InspectionType);
183190
}
184191

185192
[TestMethod]
193+
[TestCategory("Inspections")]
186194
public void InspectionName()
187195
{
188196
const string inspectionName = "AssignedByValParameterInspection";

‎RubberduckTests/Inspections/ConstantNotUsedInspectionTests.cs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ namespace RubberduckTests.Inspections
1414
public class ConstantNotUsedInspectionTests
1515
{
1616
[TestMethod]
17+
[TestCategory("Inspections")]
1718
public void ConstantNotUsed_ReturnsResult()
1819
{
1920
const string inputCode =
@@ -39,6 +40,7 @@ public void ConstantNotUsed_ReturnsResult()
3940
}
4041

4142
[TestMethod]
43+
[TestCategory("Inspections")]
4244
public void ConstantNotUsed_ReturnsResult_MultipleConsts()
4345
{
4446
const string inputCode =
@@ -65,6 +67,7 @@ public void ConstantNotUsed_ReturnsResult_MultipleConsts()
6567
}
6668

6769
[TestMethod]
70+
[TestCategory("Inspections")]
6871
public void GivenReferencedConstant_ReturnsNoInspectionResult()
6972
{
7073
const string inputCode =
@@ -94,6 +97,7 @@ Public Sub Goo(ByVal arg1 As Integer)
9497
}
9598

9699
[TestMethod]
100+
[TestCategory("Inspections")]
97101
public void GivenConstantNotUsed_ReturnsResultForUnusedConstant()
98102
{
99103
const string inputCode =
@@ -125,6 +129,7 @@ Public Sub Goo(ByVal arg1 As Integer)
125129
}
126130

127131
[TestMethod]
132+
[TestCategory("Inspections")]
128133
public void ConstantNotUsed_QuickFixWorks()
129134
{
130135
const string inputCode =
@@ -158,13 +163,15 @@ public void ConstantNotUsed_QuickFixWorks()
158163
}
159164

160165
[TestMethod]
166+
[TestCategory("Inspections")]
161167
public void InspectionType()
162168
{
163169
var inspection = new ConstantNotUsedInspection(null);
164170
Assert.AreEqual(CodeInspectionType.CodeQualityIssues, inspection.InspectionType);
165171
}
166172

167173
[TestMethod]
174+
[TestCategory("Inspections")]
168175
public void InspectionName()
169176
{
170177
const string inspectionName = "ConstantNotUsedInspection";

‎RubberduckTests/Inspections/DefaultProjectNameInspectionTests.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ namespace RubberduckTests.Inspections
1313
public class DefaultProjectNameInspectionTests
1414
{
1515
[TestMethod]
16+
[TestCategory("Inspections")]
1617
public void DefaultProjectName_ReturnsResult()
1718
{
1819
const string inputCode = @"";
@@ -38,6 +39,7 @@ public void DefaultProjectName_ReturnsResult()
3839
}
3940

4041
[TestMethod]
42+
[TestCategory("Inspections")]
4143
public void DefaultProjectName_DoesNotReturnResult()
4244
{
4345
const string inputCode = @"";
@@ -63,13 +65,15 @@ public void DefaultProjectName_DoesNotReturnResult()
6365
}
6466

6567
[TestMethod]
68+
[TestCategory("Inspections")]
6669
public void InspectionType()
6770
{
6871
var inspection = new DefaultProjectNameInspection(null);
6972
Assert.AreEqual(CodeInspectionType.MaintainabilityAndReadabilityIssues, inspection.InspectionType);
7073
}
7174

7275
[TestMethod]
76+
[TestCategory("Inspections")]
7377
public void InspectionName()
7478
{
7579
const string inspectionName = "DefaultProjectNameInspection";

‎RubberduckTests/Inspections/EmptyStringLiteralInspectionTests.cs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ namespace RubberduckTests.Inspections
1717
public class EmptyStringLiteralInspectionTests
1818
{
1919
[TestMethod]
20+
[TestCategory("Inspections")]
2021
public void EmptyStringLiteral_ReturnsResult_PassToProcedure()
2122
{
2223
const string inputCode =
@@ -51,6 +52,7 @@ Public Sub Foo(ByRef arg1 As String)
5152
}
5253

5354
[TestMethod]
55+
[TestCategory("Inspections")]
5456
public void EmptyStringLiteral_ReturnsResult_Assignment()
5557
{
5658
const string inputCode =
@@ -82,6 +84,7 @@ public void EmptyStringLiteral_ReturnsResult_Assignment()
8284
}
8385

8486
[TestMethod]
87+
[TestCategory("Inspections")]
8588
public void NotEmptyStringLiteral_DoesNotReturnResult()
8689
{
8790
const string inputCode =
@@ -113,6 +116,7 @@ public void NotEmptyStringLiteral_DoesNotReturnResult()
113116
}
114117

115118
[TestMethod]
119+
[TestCategory("Inspections")]
116120
public void EmptyStringLiteral_QuickFixWorks()
117121
{
118122
const string inputCode =
@@ -153,13 +157,15 @@ public void EmptyStringLiteral_QuickFixWorks()
153157
}
154158

155159
[TestMethod]
160+
[TestCategory("Inspections")]
156161
public void InspectionType()
157162
{
158163
var inspection = new EmptyStringLiteralInspection(null);
159164
Assert.AreEqual(CodeInspectionType.LanguageOpportunities, inspection.InspectionType);
160165
}
161166

162167
[TestMethod]
168+
[TestCategory("Inspections")]
163169
public void InspectionName()
164170
{
165171
const string inspectionName = "EmptyStringLiteralInspection";

‎RubberduckTests/Inspections/EncapsulatePublicFieldInspectionTests.cs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ namespace RubberduckTests.Inspections
1313
public class EncapsulatePublicFieldInspectionTests
1414
{
1515
[TestMethod]
16+
[TestCategory("Inspections")]
1617
public void PublicField_ReturnsResult()
1718
{
1819
const string inputCode =
@@ -36,6 +37,7 @@ public void PublicField_ReturnsResult()
3637
}
3738

3839
[TestMethod]
40+
[TestCategory("Inspections")]
3941
public void MultiplePublicFields_ReturnMultipleResult()
4042
{
4143
const string inputCode =
@@ -61,6 +63,7 @@ public void MultiplePublicFields_ReturnMultipleResult()
6163
}
6264

6365
[TestMethod]
66+
[TestCategory("Inspections")]
6467
public void PrivateField_DoesNotReturnResult()
6568
{
6669
const string inputCode =
@@ -84,6 +87,7 @@ public void PrivateField_DoesNotReturnResult()
8487
}
8588

8689
[TestMethod]
90+
[TestCategory("Inspections")]
8791
public void PublicNonField_DoesNotReturnResult()
8892
{
8993
const string inputCode =
@@ -108,13 +112,15 @@ public void PublicNonField_DoesNotReturnResult()
108112
}
109113

110114
[TestMethod]
115+
[TestCategory("Inspections")]
111116
public void InspectionType()
112117
{
113118
var inspection = new EncapsulatePublicFieldInspection(null);
114119
Assert.AreEqual(CodeInspectionType.MaintainabilityAndReadabilityIssues, inspection.InspectionType);
115120
}
116121

117122
[TestMethod]
123+
[TestCategory("Inspections")]
118124
public void InspectionName()
119125
{
120126
const string inspectionName = "EncapsulatePublicFieldInspection";

‎RubberduckTests/Inspections/FunctionReturnValueNotUsedInspectionTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010

1111
namespace RubberduckTests.Inspections
1212
{
13+
[Ignore] // todo: uncomment these tests
1314
[TestClass]
1415
public class FunctionReturnValueNotUsedInspectionTests
1516
{

‎RubberduckTests/Inspections/GeneralInspectionTests.cs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ public void InitResources()
2323
}
2424

2525
[TestMethod]
26+
[TestCategory("Inspections")]
2627
public void InspectionNameStringsExist()
2728
{
2829
var inspections = typeof(InspectionBase).Assembly.GetTypes()
@@ -35,6 +36,7 @@ public void InspectionNameStringsExist()
3536
}
3637

3738
[TestMethod]
39+
[TestCategory("Inspections")]
3840
public void InspectionMetaStringsExist()
3941
{
4042
var inspections = typeof(InspectionBase).Assembly.GetTypes()
@@ -47,6 +49,8 @@ public void InspectionMetaStringsExist()
4749
}
4850

4951
[TestMethod]
52+
[TestCategory("Inspections")]
53+
[TestCategory("Inspections")]
5054
public void InspectionResultFormatStringsExist()
5155
{
5256
var inspectionsWithSharedResultFormat = new List<string>
@@ -68,6 +72,7 @@ public void InspectionResultFormatStringsExist()
6872
}
6973

7074
[TestMethod]
75+
[TestCategory("Inspections")]
7176
public void InspectionNameStrings_AreNotFormatted()
7277
{
7378
var inspections = typeof(InspectionBase).Assembly.GetTypes()

‎RubberduckTests/Inspections/ImplicitActiveSheetReferenceInspectionTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ namespace RubberduckTests.Inspections
1515
public class ImplicitActiveSheetReferenceInspectionTests
1616
{
1717
[TestMethod, Ignore] // doesn't pick up the reference to "Range".
18+
[TestCategory("Inspections")]
1819
public void ReportsRange()
1920
{
2021
const string inputCode =

‎RubberduckTests/Inspections/ImplicitByRefParameterInspectionTests.cs

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ namespace RubberduckTests.Inspections
1414
public class ImplicitByRefParameterInspectionTests
1515
{
1616
[TestMethod]
17+
[TestCategory("Inspections")]
1718
public void ImplicitByRefParameter_ReturnsResult()
1819
{
1920
const string inputCode =
@@ -38,6 +39,7 @@ public void ImplicitByRefParameter_ReturnsResult()
3839
}
3940

4041
[TestMethod]
42+
[TestCategory("Inspections")]
4143
public void ImplicitByRefParameter_ReturnsResult_MultipleParams()
4244
{
4345
const string inputCode =
@@ -62,6 +64,7 @@ public void ImplicitByRefParameter_ReturnsResult_MultipleParams()
6264
}
6365

6466
[TestMethod]
67+
[TestCategory("Inspections")]
6568
public void ImplicitByRefParameter_DoesNotReturnResult_ByRef()
6669
{
6770
const string inputCode =
@@ -86,6 +89,7 @@ public void ImplicitByRefParameter_DoesNotReturnResult_ByRef()
8689
}
8790

8891
[TestMethod]
92+
[TestCategory("Inspections")]
8993
public void ImplicitByRefParameter_DoesNotReturnResult_ByVal()
9094
{
9195
const string inputCode =
@@ -110,6 +114,7 @@ public void ImplicitByRefParameter_DoesNotReturnResult_ByVal()
110114
}
111115

112116
[TestMethod]
117+
[TestCategory("Inspections")]
113118
public void ImplicitByRefParameter_ReturnsResult_SomePassedByRefImplicitely()
114119
{
115120
const string inputCode =
@@ -134,6 +139,7 @@ public void ImplicitByRefParameter_ReturnsResult_SomePassedByRefImplicitely()
134139
}
135140

136141
[TestMethod]
142+
[TestCategory("Inspections")]
137143
public void ImplicitByRefParameter_ReturnsResult_InterfaceImplementation()
138144
{
139145
//Input
@@ -168,6 +174,7 @@ Sub IClass1_Foo(arg1 As Integer)
168174
}
169175

170176
[TestMethod]
177+
[TestCategory("Inspections")]
171178
public void ImplicitByRefParameter_QuickFixWorks_PassByRef()
172179
{
173180
const string inputCode =
@@ -200,6 +207,7 @@ public void ImplicitByRefParameter_QuickFixWorks_PassByRef()
200207
}
201208

202209
[TestMethod]
210+
[TestCategory("Inspections")]
203211
public void ImplicitByRefParameter_QuickFixWorks_ParamArrayIsIgnored()
204212
{
205213
const string inputCode =
@@ -224,13 +232,15 @@ public void ImplicitByRefParameter_QuickFixWorks_ParamArrayIsIgnored()
224232
}
225233

226234
[TestMethod]
235+
[TestCategory("Inspections")]
227236
public void InspectionType()
228237
{
229238
var inspection = new ImplicitByRefParameterInspection(null);
230239
Assert.AreEqual(CodeInspectionType.CodeQualityIssues, inspection.InspectionType);
231240
}
232241

233242
[TestMethod]
243+
[TestCategory("Inspections")]
234244
public void InspectionName()
235245
{
236246
const string inspectionName = "ImplicitByRefParameterInspection";

0 commit comments

Comments
 (0)