Fixed test to load DebugDeclarations, proving fixed #3284

Author: Vogel612

RubberduckTests/Mocks/MockParser.cs

@@ -23,7 +23,6 @@ public static class MockParser
     {
         public static RubberduckParserState ParseString(string inputCode, out QualifiedModuleName qualifiedModuleName)
         {
-
             IVBComponent component;
             var vbe = MockVbeBuilder.BuildFromSingleStandardModule(inputCode, out component);
             qualifiedModuleName = new QualifiedModuleName(component);
@@ -35,7 +34,6 @@ public static RubberduckParserState ParseString(string inputCode, out QualifiedM
                 Assert.Inconclusive("Parser Error: {0}");
             }
             return parser.State;
-
         }
 
         public static ParseCoordinator Create(IVBE vbe, string serializedDeclarationsPath = null)
@@ -113,16 +111,39 @@ public static ParseCoordinator Create(IVBE vbe, RubberduckParserState state, IAt
                 parserStateManager,
                 true);
         }
+        
+        public static RubberduckParserState CreateAndParse(IVBE vbe, IInspectionListener listener, IEnumerable<string> testLibraries = null)
+        {
+            var parser = CreateWithLibraries(vbe, testLibraries: testLibraries);
+            parser.Parse(new CancellationTokenSource());
+            if (parser.State.Status >= ParserState.Error)
+            { Assert.Inconclusive("Parser Error"); }
 
-        public static RubberduckParserState CreateAndParse(IVBE vbe, string serializedDeclarationsPath = null)
+            return parser.State;
+        }
+
+        public static RubberduckParserState CreateAndParse(IVBE vbe, string serializedDeclarationsPath = null, IEnumerable<string> testLibraries = null)
         {
-            var parser = Create(vbe);
+            var parser = CreateWithLibraries(vbe, serializedDeclarationsPath, testLibraries);
             parser.Parse(new CancellationTokenSource());
             if (parser.State.Status >= ParserState.Error) { Assert.Inconclusive("Parser Error"); }
 
             return parser.State;
         }
 
+        private static ParseCoordinator CreateWithLibraries(IVBE vbe, string serializedDeclarationsPath = null, IEnumerable<string> testLibraries = null)
+        {
+            var parser = Create(vbe, serializedDeclarationsPath);
+            if (testLibraries != null)
+            {
+                foreach (var lib in testLibraries)
+                {
+                    parser.State.AddTestLibrary(lib);
+                }
+            }
+            return parser;
+        }
+
         private static readonly HashSet<DeclarationType> ProceduralTypes =
             new HashSet<DeclarationType>(new[]
             {
@@ -162,15 +183,5 @@ private static void AddTestLibrary(RubberduckParserState state, SerializableProj
                 state.AddDeclaration(declaration);
             }
         }
-
-        public static RubberduckParserState CreateAndParse(IVBE vbe, IInspectionListener listener)
-        {
-            var parser = Create(vbe);
-            parser.Parse(new CancellationTokenSource());
-            if(parser.State.Status >= ParserState.Error)
-            { Assert.Inconclusive("Parser Error"); }
-
-            return parser.State;
-        }
     }
 }

RubberduckTests/Refactoring/RenameTests.cs

@@ -1814,7 +1814,6 @@ public void RenameRefactoring_RefactorProperties_UpdatesReferences()
             var oldName = "Column";
             var refactoredName = "Rank";
 
-            var tdo = new RenameTestsDataObject(oldName, refactoredName );
             var classInputOutput = new RenameTestModuleDefinition("MyClass", ComponentType.ClassModule)
             {
                 Input = $@"Option Explicit
@@ -1824,7 +1823,7 @@ Private colValue As Long
 Public Property Get {oldName}() As Long
     {oldName} = colValue
 End Property
-Public Property Let |{oldName}(value As Long)
+Public Property Let {FAUX_CURSOR}{oldName}(value As Long)
     colValue = value
 End Property
 ",
@@ -1850,7 +1849,8 @@ Dim instance As MyClass
     instance.{oldName} = 97521
     Debug.Print instance.{oldName};""is the value""
 End Sub
-", Expected = $@"Option Explicit
+",
+                Expected = $@"Option Explicit
 
 Public Sub useColValue()
     Dim instance As MyClass
@@ -1860,8 +1860,24 @@ Dim instance As MyClass
 End Sub
 "
             };
-            tdo.RefactorParamType = RefactorParams.Declaration;
-            PerformExpectedVersusActualRenameTests(tdo, classInputOutput, usageInputOutput);
+
+            var builder = new MockVbeBuilder();
+            var projectName = "Test";
+            var vbe = builder.ProjectBuilder(projectName, ProjectProtection.Unprotected)
+                .AddReference("VBA", MockVbeBuilder.LibraryPathVBA, major: 4, minor: 1, isBuiltIn: true)
+                .AddComponent("MyClass", ComponentType.ClassModule, classInputOutput.Input.Replace(FAUX_CURSOR, ""))
+                .AddComponent("Usage", ComponentType.StandardModule, usageInputOutput.Input)
+                .AddProjectToVbeBuilder()
+                .Build();
+
+            var tdo = new RenameTestsDataObject(oldName, refactoredName)
+            {
+                VBE = vbe.Object,
+                RefactorParamType = RefactorParams.Declaration,
+                SelectionModuleName = "MyClass",
+                ProjectName = projectName
+            };
+            PerformExpectedVersusActualRenameTests(tdo, classInputOutput, usageInputOutput, testLibraries: new[] { "VBA.4.2.xml" });
             tdo.MsgBox.Verify(m => m.Show(It.IsAny<string>(), It.IsAny<string>(), It.IsAny<MessageBoxButtons>(), It.IsAny<MessageBoxIcon>()), Times.Never);
         }
         #endregion
@@ -2085,11 +2101,12 @@ private static void PerformExpectedVersusActualRenameTests(RenameTestsDataObject
             , RenameTestModuleDefinition? inputOutput1
             , RenameTestModuleDefinition? inputOutput2 = null
             , RenameTestModuleDefinition? inputOutput3 = null
-            , RenameTestModuleDefinition? inputOutput4 = null)
+            , RenameTestModuleDefinition? inputOutput4 = null
+            , IEnumerable<string> testLibraries = null)
         {
             try
             {
-                InitializeTestDataObject(tdo, inputOutput1, inputOutput2, inputOutput3, inputOutput4);
+                InitializeTestDataObject(tdo, inputOutput1, inputOutput2, inputOutput3, inputOutput4, testLibraries);
                 RunRenameRefactorScenario(tdo);
                 CheckRenameRefactorTestResults(tdo);
             }
@@ -2103,7 +2120,8 @@ private static void InitializeTestDataObject(RenameTestsDataObject tdo
             , RenameTestModuleDefinition? inputOutput1
             , RenameTestModuleDefinition? inputOutput2 = null
             , RenameTestModuleDefinition? inputOutput3 = null
-            , RenameTestModuleDefinition? inputOutput4 = null)
+            , RenameTestModuleDefinition? inputOutput4 = null
+            , IEnumerable<string> testLibraries = null)
         {
             var renameTMDs = new List<RenameTestModuleDefinition>();
             bool cursorFound = false;
@@ -2144,7 +2162,7 @@ private static void InitializeTestDataObject(RenameTestsDataObject tdo
                 .Returns(tdo.MsgBoxReturn);
 
             tdo.VBE = tdo.VBE ?? BuildProject(tdo.ProjectName, tdo.ModuleTestSetupDefs);
-            tdo.ParserState = MockParser.CreateAndParse(tdo.VBE);
+            tdo.ParserState = MockParser.CreateAndParse(tdo.VBE, testLibraries: testLibraries);
 
             CreateQualifiedSelectionForTestCase(tdo);
             tdo.RenameModel = new RenameModel(tdo.VBE, tdo.ParserState, tdo.QualifiedSelection) { NewName = tdo.NewName };
@@ -2269,7 +2287,6 @@ private static IVBE BuildProject(string projectName, List<RenameTestModuleDefini
         {
             var builder = new MockVbeBuilder();
             var enclosingProjectBuilder = builder.ProjectBuilder(projectName, ProjectProtection.Unprotected);
-
             foreach (var comp in testComponents)
             {
                 if (comp.ModuleType == ComponentType.UserForm)