Skip to content

Commit fa018b0

Browse files
committed
Revert "Fix a bunch of ignored ignore annotations for parameter inspections"
This reverts commit f70bfc2.
1 parent f70bfc2 commit fa018b0

File tree

4 files changed

+5
-8
lines changed

4 files changed

+5
-8
lines changed

RetailCoder.VBE/Inspections/ImplicitByRefParameterInspection.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ public override IEnumerable<InspectionResultBase> GetInspectionResults()
2626

2727
var issues = (from item in UserDeclarations
2828
where
29-
item.DeclarationType == DeclarationType.Parameter
30-
&& !item.ParentDeclaration.IsInspectionDisabled(AnnotationName)
29+
!item.IsInspectionDisabled(AnnotationName)
30+
&& item.DeclarationType == DeclarationType.Parameter
3131
// ParamArray parameters do not allow an explicit "ByRef" parameter mechanism.
3232
&& !((ParameterDeclaration)item).IsParamArray
3333
&& !interfaceMembersScope.Contains(item.ParentScope)

RetailCoder.VBE/Inspections/ParameterNotUsedInspection.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,7 @@ public override IEnumerable<InspectionResultBase> GetInspectionResults()
4646

4747
var issues = from issue in unused.Where(parameter =>
4848
!IsInterfaceMemberParameter(parameter, interfaceMemberScopes)
49-
&& !builtInHandlers.Contains(parameter.ParentDeclaration)
50-
&& !parameter.ParentDeclaration.IsInspectionDisabled(AnnotationName))
49+
&& !builtInHandlers.Contains(parameter.ParentDeclaration))
5150
let isInterfaceImplementationMember = IsInterfaceMemberImplementationParameter(issue, interfaceImplementationMemberScopes)
5251
select new ParameterNotUsedInspectionResult(this, issue,
5352
((dynamic) issue.Context).unrestrictedIdentifier(), issue.QualifiedName,

RetailCoder.VBE/Inspections/UseMeaningfulNameInspection.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,7 @@ public UseMeaningfulNameInspection(IMessageBox messageBox, RubberduckParserState
2323
public override IEnumerable<InspectionResultBase> GetInspectionResults()
2424
{
2525
var issues = UserDeclarations
26-
.Where(declaration => declaration.DeclarationType != DeclarationType.ModuleOption &&
27-
(declaration.DeclarationType != DeclarationType.Parameter ||
28-
(declaration.DeclarationType == DeclarationType.Parameter && !declaration.ParentDeclaration.IsInspectionDisabled(AnnotationName))) &&
26+
.Where(declaration => declaration.DeclarationType != DeclarationType.ModuleOption &&
2927
(declaration.IdentifierName.Length < 3 ||
3028
char.IsDigit(declaration.IdentifierName.Last()) ||
3129
!declaration.IdentifierName.Any(c =>

RetailCoder.VBE/Inspections/VariableTypeNotDeclaredInspection.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ public override IEnumerable<InspectionResultBase> GetInspectionResults()
2121
var issues = from item in UserDeclarations
2222
where (item.DeclarationType == DeclarationType.Variable
2323
|| item.DeclarationType == DeclarationType.Constant
24-
|| (item.DeclarationType == DeclarationType.Parameter && !item.IsArray && !item.ParentDeclaration.IsInspectionDisabled(AnnotationName)))
24+
|| (item.DeclarationType == DeclarationType.Parameter && !item.IsArray))
2525
&& !item.IsTypeSpecified
2626
select new VariableTypeNotDeclaredInspectionResult(this, item);
2727

0 commit comments

Comments
 (0)