Skip to content

Commit f9c5db7

Browse files
committed
Improve description of dictionary access inspections based on review to PR #5164
1 parent 0b02dfe commit f9c5db7

File tree

5 files changed

+13
-13
lines changed

5 files changed

+13
-13
lines changed

Rubberduck.CodeAnalysis/Inspections/Concrete/UseOfRecursiveBangNotationInspection.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ namespace Rubberduck.Inspections.Concrete
4848
/// <example hasResult="false">
4949
/// <![CDATA[
5050
/// Public Function MyName(ByVal rst As ADODB.Recordset) As Variant
51-
/// MyName = rst.Fields!Name.Value
51+
/// MyName = rst.Fields!Name.Value 'see "UseOfBangNotation" inspection
5252
/// End Function
5353
/// ]]>
5454
/// </example>

Rubberduck.Resources/Inspections/InspectionInfo.Designer.cs

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Rubberduck.Resources/Inspections/InspectionInfo.resx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -404,12 +404,12 @@ If the parameter can be null, ignore this inspection result; passing a null valu
404404
<value>The VBA compiler does not raise an error if an indexed default member call is required but the object's declared type does not have a suitable default member. Under almost all circumstances, this leads to a run-time error 91 'Object or With block variable not set' or 438 'Object doesn't support this property or method' depending on whether the object has the value 'Nothing' or not, which is harder to detect and indicates a bug.</value>
405405
</data>
406406
<data name="UseOfBangNotationInspection" xml:space="preserve">
407-
<value>Bang notation, formally known as dictionary access expression, looks like it is strongly typed. However, it is actually a stringly typed access to the paramterized default member of the object it is used on.</value>
407+
<value>Bang notation, formally known as dictionary access expression, looks like it is strongly typed. However, it is actually a stringly-typed access to the parameterized default member of the object it is used on.</value>
408408
</data>
409409
<data name="UseOfRecursiveBangNotationInspection" xml:space="preserve">
410-
<value>Bang notation, formally known as dictionary access expression, looks like it is strongly typed. However, it is actually a stringly typed access to the paramterized default member of the object it is used on. This is especially misleading if the parameterized default member is not on the object itself and can only be reached by calling the parameterless default member first. </value>
410+
<value>Bang notation, formally known as dictionary access expression, looks like it is strongly typed. However, it is actually a stringly-typed access to the parameterized default member of the object it is used on. This is especially misleading if the parameterized default member is not on the object itself and can only be reached by calling the parameterless default member first.</value>
411411
</data>
412412
<data name="UseOfUnboundBangNotationInspection" xml:space="preserve">
413-
<value>Bang notation, formally known as dictionary access expression, looks like it is strongly typed. However, it is actually a stringly typed access to the paramterized default member of the object it is used on. This is especially misleading the default member cannot be determined at compile time.</value>
413+
<value>Bang notation, formally known as dictionary access expression, looks like it is strongly typed. However, it is actually a stringly-typed access to the parameterized default member of the object it is used on. This is especially misleading the default member cannot be determined at compile time.</value>
414414
</data>
415415
</root>

Rubberduck.Resources/Inspections/InspectionResults.Designer.cs

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Rubberduck.Resources/Inspections/InspectionResults.resx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -459,15 +459,15 @@ In memoriam, 1972-2018</value>
459459
<comment>{0} expression; {1} type</comment>
460460
</data>
461461
<data name="UseOfBangNotationInspection" xml:space="preserve">
462-
<value>The expression '{0}' contains a use of bang notation.</value>
462+
<value>The expression '{0}' uses bang notation.</value>
463463
<comment>{0} expression</comment>
464464
</data>
465465
<data name="UseOfRecursiveBangNotationInspection" xml:space="preserve">
466-
<value>The expression '{0}' contains a use of recursive bang notation.</value>
466+
<value>The expression '{0}' uses a recursive bang operator.</value>
467467
<comment>{0} expression</comment>
468468
</data>
469469
<data name="UseOfUnboundBangNotationInspection" xml:space="preserve">
470-
<value>The expression '{0}' contains a use of unbound bang notation.</value>
470+
<value>The expression '{0}' uses an unbound bang operator.</value>
471471
<comment>{0} expression</comment>
472472
</data>
473473
</root>

0 commit comments

Comments
 (0)