ignored arrays in unassigned variable inspection; added note in ParameterCanBeByVal inspection, we need to relate args calls to parameters, and parameters to procedures to be able to tell if we're passing a parameter to another proc as a ByRef arg.

Author: retailcoder

RetailCoder.VBE/Inspections/ParameterCanBeByValInspection.cs

@@ -1,6 +1,8 @@
+using System;
 using System.Collections.Generic;
 using Rubberduck.Parsing;
 using System.Linq;
+using Microsoft.CSharp.RuntimeBinder;
 using Rubberduck.Parsing.Grammar;
 using Rubberduck.Parsing.Symbols;
 
@@ -59,12 +61,18 @@ public IEnumerable<CodeInspectionResultBase> GetInspectionResults(VBProjectParse
                 && !interfaceMembers.Select(m => m.Scope).Contains(declaration.ParentScope)
                 && PrimitiveTypes.Contains(declaration.AsTypeName)
                 && ((VBAParser.ArgContext) declaration.Context).BYVAL() == null
+                && !IsUsedAsByRefParam(parseResult.Declarations, declaration)
                 && !declaration.References.Any(reference => reference.IsAssignment))
                 .Select(issue => new ParameterCanBeByValInspectionResult(string.Format(Name, issue.IdentifierName), Severity, issue.Context, issue.QualifiedName));
 
             return issues;
         }
 
-
+        private bool IsUsedAsByRefParam(Declarations declarations, Declaration parameter)
+        {
+            // todo: enable tracking parameter references 
+            // by linking Parameter declarations to their parent Procedure/Function/Property member.
+            return false;
+        }
     }
 }

RetailCoder.VBE/Inspections/VariableNotAssignedInspection.cs

@@ -18,10 +18,15 @@ public VariableNotAssignedInspection()
 
         public IEnumerable<CodeInspectionResultBase> GetInspectionResults(VBProjectParseResult parseResult)
         {
+            // ignore arrays. todo: ArrayIndicesNotAccessedInspection
+            var arrays = parseResult.Declarations.Items.Where(declaration =>
+                declaration.DeclarationType == DeclarationType.Variable
+                && declaration.IsArray()).ToList();
+
             var declarations = parseResult.Declarations.Items.Where(declaration =>
-                !declaration.IsBuiltIn 
-                && declaration.DeclarationType == DeclarationType.Variable
-                && !declaration.IsArray() // ignore arrays... not ideal though
+                declaration.DeclarationType == DeclarationType.Variable
+                && !declaration.IsBuiltIn 
+                && !arrays.Contains(declaration)
                 && !parseResult.Declarations.Items.Any(item => 
                     item.IdentifierName == declaration.AsTypeName 
                     && item.DeclarationType == DeclarationType.UserDefinedType) // UDT variables don't need to be assigned

RetailCoder.VBE/Inspections/VariableNotUsedInspection.cs

@@ -20,8 +20,9 @@ public IEnumerable<CodeInspectionResultBase> GetInspectionResults(VBProjectParse
         {
             var declarations = parseResult.Declarations.Items.Where(declaration =>
                 !declaration.IsBuiltIn 
+                //&& !declaration.IsArray()
                 && declaration.DeclarationType == DeclarationType.Variable
-                && !declaration.References.Any(reference => !reference.IsAssignment));
+                && declaration.References.All(reference => reference.IsAssignment));
 
             foreach (var issue in declarations)
             {

Rubberduck.Parsing/Symbols/Declaration.cs

@@ -135,7 +135,7 @@ public bool IsArray()
 
             try
             {
-                var declaration = ((dynamic)Context.Parent); // Context is AmbiguousIdentifier - parent is the declaration sub-statement where the array parens are
+                var declaration = ((dynamic)Context); // Context is AmbiguousIdentifier - parent is the declaration sub-statement where the array parens are
                 return declaration.LPAREN() != null && declaration.RPAREN() != null;
             }
             catch (RuntimeBinderException)

Rubberduck.Parsing/Symbols/DeclarationSymbolsListener.cs

@@ -258,7 +258,7 @@ public override void EnterArgList(VBAParser.ArgListContext context)
                     : asTypeClause.type().GetText();
 
                 var identifier = argContext.ambiguousIdentifier();
-                _declarations.Add(CreateDeclaration(identifier.GetText(), asTypeName, Accessibility.Implicit, DeclarationType.Parameter, argContext, argContext.ambiguousIdentifier().GetSelection()));
+                _declarations.Add(CreateDeclaration(identifier.GetText(), asTypeName, Accessibility.Implicit, DeclarationType.Parameter, argContext, identifier.GetSelection()));
             }
         }
 

Rubberduck.Parsing/Symbols/IdentifierReferenceListener.cs

@@ -1,7 +1,6 @@
 using System;
 using System.Collections.Generic;
 using System.Linq;
-using System.Windows.Forms;
 using Antlr4.Runtime;
 using Antlr4.Runtime.Tree;
 using Rubberduck.Parsing.Grammar;