Stop reporting array accesses as separate references for FindAllReferences

Author: MDoerner

Rubberduck.Core/UI/Controls/FindAllReferencesService.cs

@@ -141,11 +141,14 @@ private SearchResultsViewModel CreateViewModel(ProjectDeclaration project, Proje
 
         private SearchResultsViewModel CreateViewModel(Declaration declaration)
         {
-            var results = declaration.References.Distinct().Select(reference =>
-                new SearchResultItem(
-                    reference.ParentNonScoping,
-                    new NavigateCodeEventArgs(reference.QualifiedModuleName, reference.Selection),
-                    GetModuleLine(reference.QualifiedModuleName, reference.Selection.StartLine)));
+            var results = declaration.References
+                .Where(reference => !reference.IsArrayAccess)
+                .Distinct()
+                .Select(reference =>
+                    new SearchResultItem(
+                        reference.ParentNonScoping,
+                        new NavigateCodeEventArgs(reference.QualifiedModuleName, reference.Selection),
+                        GetModuleLine(reference.QualifiedModuleName, reference.Selection.StartLine)));
 
             var accessor = declaration.DeclarationType.HasFlag(DeclarationType.PropertyGet) ? "(get)"
                 : declaration.DeclarationType.HasFlag(DeclarationType.PropertyLet) ? "(let)"

RubberduckTests/Commands/FindAllReferencesTests.cs

@@ -75,6 +75,56 @@ Private Sub Bar()
             }
         }
 
+        [Category("Commands")]
+        [Test]
+        //See issue #5277 at https://github.com/rubberduck-vba/Rubberduck/issues/5277
+        public void FindAllReferences_ArraySelected_ReturnsCorrectNumberIgnoringArrayAccesses()
+        {
+            const string inputCode =
+                @"
+Private Sub Bar()
+    Dim arr(0 To 1) As Variant
+    arr(1) = arr(1)
+End Sub";
+
+            var vbe = MockVbeBuilder.BuildFromSingleStandardModule(inputCode, out _, new Selection(4, 6, 4, 6));
+            using (var state = MockParser.CreateAndParse(vbe.Object))
+            {
+                var vm = new SearchResultsWindowViewModel();
+                var service = ArrangeFindAllReferencesService(state, vm);
+                var command = ArrangeFindAllReferencesCommand(state, vbe, vm, service);
+
+                command.Execute(null);
+
+                Assert.AreEqual(2, vm.Tabs[0].SearchResults.Count);
+            }
+        }
+
+        [Category("Commands")]
+        [Test]
+        //See issue #5277 at https://github.com/rubberduck-vba/Rubberduck/issues/5277
+        public void FindAllReferences_ReDimDeclaredArraySelected_ReturnsCorrectNumberIgnoringArrayAccesses()
+        {
+            const string inputCode =
+                @"
+Private Sub Bar()
+    ReDim arr(0 To 1)
+    arr(1) = arr(1)
+End Sub";
+
+            var vbe = MockVbeBuilder.BuildFromSingleStandardModule(inputCode, out _, new Selection(4, 6, 4, 6));
+            using (var state = MockParser.CreateAndParse(vbe.Object))
+            {
+                var vm = new SearchResultsWindowViewModel();
+                var service = ArrangeFindAllReferencesService(state, vm);
+                var command = ArrangeFindAllReferencesCommand(state, vbe, vm, service);
+
+                command.Execute(null);
+
+                Assert.AreEqual(3, vm.Tabs[0].SearchResults.Count);
+            }
+        }
+
         [Category("Commands")]
         [Test]
         public void FindAllReferences_NoResults_DisplayMessageBox()