Skip to content

Commit f5b5175

Browse files
committed
Rewire the refactoring
1 parent b54cbac commit f5b5175

File tree

5 files changed

+16
-30
lines changed

5 files changed

+16
-30
lines changed

RetailCoder.VBE/Refactorings/ReorderParameters/IReorderParametersDialog.cs

Lines changed: 0 additions & 11 deletions
This file was deleted.

RetailCoder.VBE/Refactorings/ReorderParameters/ReorderParametersPresenter.cs

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
1-
using System.Windows.Forms;
1+
using System.Collections.ObjectModel;
2+
using System.Linq;
3+
using System.Windows.Forms;
24
using Rubberduck.UI;
5+
using Rubberduck.UI.Refactorings.ReorderParameters;
36

47
namespace Rubberduck.Refactorings.ReorderParameters
58
{
@@ -10,11 +13,11 @@ public interface IReorderParametersPresenter
1013

1114
public class ReorderParametersPresenter : IReorderParametersPresenter
1215
{
13-
private readonly IReorderParametersDialog _view;
16+
private readonly ReorderParametersDialog _view;
1417
private readonly ReorderParametersModel _model;
1518
private readonly IMessageBox _messageBox;
1619

17-
public ReorderParametersPresenter(IReorderParametersDialog view, ReorderParametersModel model, IMessageBox messageBox)
20+
public ReorderParametersPresenter(ReorderParametersDialog view, ReorderParametersModel model, IMessageBox messageBox)
1821
{
1922
_view = view;
2023
_model = model;
@@ -32,15 +35,15 @@ public ReorderParametersModel Show()
3235
return null;
3336
}
3437

35-
_view.Parameters = _model.Parameters;
36-
_view.InitializeParameterGrid();
38+
_view.ViewModel.Parameters = new ObservableCollection<Parameter>(_model.Parameters);
3739

38-
if (_view.ShowDialog() != DialogResult.OK)
40+
_view.ShowDialog();
41+
if (_view.DialogResult != DialogResult.OK)
3942
{
4043
return null;
4144
}
4245

43-
_model.Parameters = _view.Parameters;
46+
_model.Parameters = _view.ViewModel.Parameters.ToList();
4447
return _model;
4548
}
4649
}

RetailCoder.VBE/Refactorings/ReorderParameters/ReorderParametersPresenterFactory.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,18 @@
11
using Rubberduck.Parsing.VBA;
22
using Rubberduck.UI;
3+
using Rubberduck.UI.Refactorings.ReorderParameters;
34
using Rubberduck.VBEditor.SafeComWrappers.Abstract;
45

56
namespace Rubberduck.Refactorings.ReorderParameters
67
{
78
public class ReorderParametersPresenterFactory : IRefactoringPresenterFactory<IReorderParametersPresenter>
89
{
910
private readonly IVBE _vbe;
10-
private readonly IReorderParametersDialog _view;
11+
private readonly ReorderParametersDialog _view;
1112
private readonly RubberduckParserState _state;
1213
private readonly IMessageBox _messageBox;
1314

14-
public ReorderParametersPresenterFactory(IVBE vbe, IReorderParametersDialog view,
15+
public ReorderParametersPresenterFactory(IVBE vbe, ReorderParametersDialog view,
1516
RubberduckParserState state, IMessageBox messageBox)
1617
{
1718
_vbe = vbe;

RetailCoder.VBE/Rubberduck.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -590,7 +590,6 @@
590590
<Compile Include="Refactorings\RemoveParameters\RemoveParametersPresenterFactory.cs" />
591591
<Compile Include="Refactorings\RemoveParameters\RemoveParametersRefactoring.cs" />
592592
<Compile Include="Refactorings\Rename\RenameModel.cs" />
593-
<Compile Include="Refactorings\ReorderParameters\IReorderParametersDialog.cs" />
594593
<Compile Include="Refactorings\ReorderParameters\ReorderParametersModel.cs" />
595594
<Compile Include="Refactorings\ReorderParameters\ReorderParametersPresenter.cs" />
596595
<Compile Include="Refactorings\ReorderParameters\ReorderParametersPresenterFactory.cs" />

RetailCoder.VBE/UI/Command/Refactorings/RefactorReorderParametersCommand.cs

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
1-
using System.Collections.Generic;
2-
using System.Collections.ObjectModel;
3-
using System.Linq;
1+
using System.Linq;
42
using System.Runtime.InteropServices;
53
using Rubberduck.Common;
64
using Rubberduck.Parsing.Symbols;
@@ -73,13 +71,9 @@ protected override void ExecuteImpl(object parameter)
7371

7472
using (var view = new ReorderParametersDialog(new ReorderParametersViewModel(_state)))
7573
{
76-
/*var factory = new ReorderParametersPresenterFactory(Vbe, view, _state, _msgbox);
74+
var factory = new ReorderParametersPresenterFactory(Vbe, view, _state, _msgbox);
7775
var refactoring = new ReorderParametersRefactoring(Vbe, factory, _msgbox);
78-
refactoring.Refactor(selection);*/
79-
view.ViewModel.Parameters =
80-
new ObservableCollection<Parameter>(_state.AllUserDeclarations.Where(s => s.DeclarationType == DeclarationType.Parameter)
81-
.Select((s, i) => new Parameter((ParameterDeclaration)s, i)).ToList());
82-
view.ShowDialog();
76+
refactoring.Refactor(selection);
8377
}
8478
}
8579
}

0 commit comments

Comments
 (0)