Merge pull request #1283 from autoboosh/resolverspeed

Small parser/resolver performance improvements

Author: retailcoder

RetailCoder.VBE/Inspections/InspectionBase.cs

@@ -10,12 +10,14 @@ public abstract class InspectionBase : IInspection
     {
         protected readonly RubberduckParserState State;
         private readonly CodeInspectionSeverity _defaultSeverity;
+        private readonly string _name;
 
         protected InspectionBase(RubberduckParserState state, CodeInspectionSeverity defaultSeverity = CodeInspectionSeverity.Warning)
         {
             State = state;
             _defaultSeverity = defaultSeverity;
             Severity = _defaultSeverity;
+            _name = GetType().Name;
         }
 
         /// <summary>
@@ -42,7 +44,7 @@ protected InspectionBase(RubberduckParserState state, CodeInspectionSeverity def
         /// <summary>
         /// The inspection type name, obtained by reflection.
         /// </summary>
-        public string Name { get { return GetType().Name; } }
+        public string Name { get { return _name; } }
 
         /// <summary>
         /// Inspection severity level. Can control whether an inspection is enabled.

RetailCoder.VBE/Navigation/CodeExplorer/CodeExplorerViewModel.cs

@@ -80,7 +80,7 @@ private void ParserState_StateChanged(object sender, EventArgs e)
         {
             Debug.WriteLine("CodeExplorerViewModel handles StateChanged...");
             IsBusy = _state.Status == ParserState.Parsing;
-            if (_state.Status != ParserState.Parsed)
+            if (_state.Status != ParserState.Ready)
             {
                 return;
             }

RetailCoder.VBE/UI/ToDoItems/ToDoExplorerViewModel.cs

@@ -51,7 +51,7 @@ public ICommand RefreshCommand
         private async void _state_StateChanged(object sender, EventArgs e)
         {
             Debug.WriteLine("ToDoExplorerViewModel handles StateChanged...");
-            if (_state.Status != ParserState.Parsed)
+            if (_state.Status != ParserState.Ready)
             {
                 return;
             }

Rubberduck.Parsing/Symbols/IdentifierReference.cs

@@ -1,7 +1,7 @@
 using Antlr4.Runtime;
-using Microsoft.CSharp.RuntimeBinder;
 using Rubberduck.Parsing.Grammar;
 using Rubberduck.VBEditor;
+using System.Linq;
 
 namespace Rubberduck.Parsing.Symbols
 {
@@ -115,8 +115,7 @@ public bool HasTypeHint(out string token)
                 _hasTypeHint = false;
                 return false;
             }
-
-            var method = Context.Parent.GetType().GetMethod("typeHint");
+            var method = Context.Parent.GetType().GetMethods().FirstOrDefault(m => m.Name == "typeHint");
             if (method == null)
             {
                 token = null;

Rubberduck.VBEEditor/QualifiedModuleName.cs

@@ -24,6 +24,7 @@ public QualifiedModuleName(VBComponent component)
 
             _component = component;
             _componentName = component == null ? string.Empty : component.Name;
+            _project = component == null ? null : component.Collection.Parent;
             _projectName = component == null ? string.Empty : component.Collection.Parent.Name;
             _projectHashCode = component == null ? 0 : component.Collection.Parent.GetHashCode();
 
@@ -47,7 +48,6 @@ public QualifiedModuleName(VBComponent component)
         public QualifiedModuleName(string projectName, string componentName)
         {
             _project = null; // field is only assigned when the instance refers to a VBProject.
-
             _projectName = projectName;
             _componentName = componentName;
             _component = null;
@@ -64,7 +64,7 @@ public QualifiedMemberName QualifyMemberName(string member)
         public VBComponent Component { get { return _component; } }
 
         private readonly VBProject _project;
-        public VBProject Project { get { return _project ?? (_component == null ? null : _component.Collection.Parent); } }
+        public VBProject Project { get { return _project; } }
 
         private readonly int _projectHashCode;
         public int ProjectHashCode { get { return _projectHashCode; } }