Stop simple name expressions from resolving to Debug.Print

Also fixes resolver in case the outputList is null.

Author: MDoerner

Rubberduck.Parsing/Binding/Bindings/ObjectPrintDefaultBinding.cs

@@ -21,7 +21,7 @@ public ObjectPrintDefaultBinding(
         public IBoundExpression Resolve()
         {
             var printMethodExpression = _printMethodBinding.Resolve();
-            var outputListExpression = _outputListBinding.Resolve();
+            var outputListExpression = _outputListBinding?.Resolve();
             return new ObjectPrintExpression(_context, printMethodExpression, outputListExpression);
         }
     }

Rubberduck.Parsing/Binding/DefaultBindingContext.cs

@@ -258,11 +258,14 @@ private IExpressionBinding Visit(Declaration module, Declaration parent, VBAPars
                 lExpressionBinding,
                 StatementResolutionContext.Undefined,
                 expression.printMethod());
-            var outputListBinding = Visit(
-                module,
-                parent,
-                expression.outputList(),
-                withBlockVariable);
+            var outputListContext = expression.outputList();
+            var outputListBinding = outputListContext != null
+                ? Visit(
+                    module,
+                    parent,
+                    outputListContext,
+                    withBlockVariable)
+                : null;
             return new ObjectPrintDefaultBinding(expression, memberAccessBinding, outputListBinding);
         }
 
@@ -277,11 +280,14 @@ private IExpressionBinding Visit(Declaration module, Declaration parent, VBAPars
                 printMethodContext,
                 printMethodContext.GetText(),
                 StatementResolutionContext.Undefined);
-            var outputListBinding = Visit(
-                module,
-                parent,
-                expression.outputList(),
-                withBlockVariable);
+            var outputListContext = expression.outputList();
+            var outputListBinding = outputListContext != null 
+                ? Visit(
+                    module,
+                    parent,
+                    outputListContext,
+                    withBlockVariable)
+                : null;
             return new ObjectPrintDefaultBinding(expression, simpleNameBinding, outputListBinding);
         }
 

Rubberduck.Parsing/VBA/DeclarationCaching/DeclarationFinder.cs

@@ -1159,8 +1159,9 @@ public Declaration FindMemberReferencedProjectInModule(Declaration callingProjec
                      (Declaration.GetModuleParent(p) == null ||
                       Declaration.GetModuleParent(p).DeclarationType == moduleType));
             var accessibleMembers = memberMatches.Where(m => AccessibilityCheck.IsMemberAccessible(callingProject, callingModule, callingParent, m));
-            var match = accessibleMembers.FirstOrDefault(member => !(member.IdentifierName.Equals("Assert") 
-                                                                     && member.QualifiedModuleName.ComponentName.Equals("Debug")));
+            var match = accessibleMembers.FirstOrDefault(member => !(member.QualifiedModuleName.ComponentName.Equals("Debug") 
+                                                                     && (member.IdentifierName.Equals("Assert") 
+                                                                         || member.IdentifierName.Equals("Print"))));
             return match;
         }
 

Rubberduck.Parsing/VBA/ReferenceManagement/BoundExpressionVisitor.cs

@@ -185,7 +185,12 @@ private void Visit(
             Declaration scope,
             Declaration parent)
         {
-            Visit(expression.OutputListExpression, module, scope, parent);
+            var outputListExpression = expression.OutputListExpression;
+            if (outputListExpression != null)
+            {
+                Visit(expression.OutputListExpression, module, scope, parent);
+            }
+
             Visit(expression.PrintMethodExpressions, module, scope, parent);
         }
 

Rubberduck.Parsing/VBA/ReferenceManagement/FailedResolutionVisitor.cs

@@ -115,7 +115,12 @@ private void Visit(MemberAccessExpression expression, Declaration parent, IBound
 
         private void Visit(ObjectPrintExpression expression, Declaration parent, IBoundExpression withExpression)
         {
-            Visit(expression.OutputListExpression, parent, withExpression);
+            var outputListExpression = expression.OutputListExpression;
+            if (outputListExpression != null)
+            {
+                Visit(expression.OutputListExpression, parent, withExpression);
+            }
+
             Visit(expression.PrintMethodExpressions, parent, withExpression);
         }
 

Rubberduck.Parsing/VBA/ReferenceManagement/IdentifierReferenceResolver.cs

@@ -502,7 +502,11 @@ public void Resolve(VBAParser.WidthStmtContext context)
         public void Resolve(VBAParser.PrintStmtContext context)
         {
             ResolveDefault(context.markedFileNumber().expression(), true);
-            ResolveOutputList(context.outputList());
+            var outputList = context.outputList();
+            if (outputList != null)
+            {
+                ResolveOutputList(outputList);
+            }
         }
 
         public void Resolve(VBAParser.UnqualifiedObjectPrintStmtContext context)
@@ -513,7 +517,11 @@ public void Resolve(VBAParser.UnqualifiedObjectPrintStmtContext context)
         public void Resolve(VBAParser.WriteStmtContext context)
         {
             ResolveDefault(context.markedFileNumber().expression(), true);
-            ResolveOutputList(context.outputList());
+            var outputList = context.outputList();
+            if (outputList != null)
+            {
+                ResolveOutputList(outputList);
+            }
         }
 
         private void ResolveOutputList(VBAParser.OutputListContext outputList)

RubberduckTests/Grammar/ResolverTests.cs

@@ -2257,7 +2257,6 @@ public void UnqualifiedObjectPrintExpr_IsReferencePrintOnContainingModule()
         {
             var code = @"
 Sub Test()
-    Dim obj As Object
     Dim referenced As String
     Print referenced;referenced, referenced , referenced ;
 End Sub
@@ -6785,5 +6784,79 @@ End Function
                 Assert.AreEqual(2, debugAssertReferences.Count());
             }
         }
+
+        [Category("Grammar")]
+        [Category("Resolver")]
+        [Test]
+        public void PrintWithoutDebug_NoReferenceToDebugPrint()
+        {
+            var classCode = @"
+Public Function Foo(index As Variant) As Class1
+    Print
+End Function
+";
+
+            var moduleCode = $@"
+Private Function Test() As Variant
+    Print
+End Function
+";
+
+            var vbe = new MockVbeBuilder()
+                .ProjectBuilder("TestProject", ProjectProtection.Unprotected)
+                .AddComponent("Class1", ComponentType.ClassModule, classCode)
+                .AddComponent("Module1", ComponentType.StandardModule, moduleCode)
+                .AddReference("VBA", MockVbeBuilder.LibraryPathVBA, 4, 2, true)
+                .AddProjectToVbeBuilder()
+                .Build();
+
+            using (var state = Resolve(vbe.Object))
+            {
+                var debugAssertDeclaration = state.DeclarationFinder
+                    .BuiltInDeclarations(DeclarationType.Procedure)
+                    .Single(declaration => declaration.IdentifierName.Equals("Print")
+                                           && declaration.QualifiedModuleName.ComponentName.Equals("Debug"));
+                var debugAssertReferences = debugAssertDeclaration.References;
+
+                Assert.IsFalse(debugAssertReferences.Any());
+            }
+        }
+
+        [Category("Grammar")]
+        [Category("Resolver")]
+        [Test]
+        public void PrintWithDebug_ReferenceToDebugPrint()
+        {
+            var classCode = @"
+Public Function Foo(index As Variant) As Class1
+    Debug.Print 42
+End Function
+";
+
+            var moduleCode = $@"
+Private Function Test() As Variant
+    Debug.Print 42
+End Function
+";
+
+            var vbe = new MockVbeBuilder()
+                .ProjectBuilder("TestProject", ProjectProtection.Unprotected)
+                .AddComponent("Class1", ComponentType.ClassModule, classCode)
+                .AddComponent("Module1", ComponentType.StandardModule, moduleCode)
+                .AddReference("VBA", MockVbeBuilder.LibraryPathVBA, 4, 2, true)
+                .AddProjectToVbeBuilder()
+                .Build();
+
+            using (var state = Resolve(vbe.Object))
+            {
+                var debugAssertDeclaration = state.DeclarationFinder
+                    .BuiltInDeclarations(DeclarationType.Procedure)
+                    .Single(declaration => declaration.IdentifierName.Equals("Print")
+                                           && declaration.QualifiedModuleName.ComponentName.Equals("Debug"));
+                var debugAssertReferences = debugAssertDeclaration.References;
+
+                Assert.AreEqual(2, debugAssertReferences.Count());
+            }
+        }
     }
 }