restored bail-out parsing strategy

Author: retailcoder

Rubberduck.Parsing/Preprocessing/VBAPrecompilationParser.cs

@@ -17,7 +17,7 @@ public VBAConditionalCompilationParser.CompilationUnitContext Parse(string modul
             var lexer = new VBALexer(stream);
             var tokens = new CommonTokenStream(lexer);
             var parser = new VBAConditionalCompilationParser(tokens);
-            //parser.AddErrorListener(new SyntaxErrorNotificationListener()); // notify?
+            parser.AddErrorListener(new ExceptionErrorListener()); // notify?
             VBAConditionalCompilationParser.CompilationUnitContext tree;
             try
             {

Rubberduck.Parsing/VBA/AttributeParser.cs

@@ -47,7 +47,7 @@ public IDictionary<Tuple<string, DeclarationType>, Attributes> Parse(IVBComponen
             // line numbers are offset due to module header and attributes
             // (these don't show up in the VBE, that's why we're parsing an exported file)
             ITokenStream tokenStream;
-            new VBAModuleParser().Parse(component.Name, preprocessed, new IParseTreeListener[] { listener }, new SyntaxErrorNotificationListener(), out tokenStream);
+            new VBAModuleParser().Parse(component.Name, preprocessed, new IParseTreeListener[] { listener }, new ExceptionErrorListener(), out tokenStream);
             return listener.Attributes;
         }
 

Rubberduck.Parsing/VBA/ComponentParseTask.cs

@@ -87,7 +87,7 @@ public void Start(CancellationToken token)
             }
             catch (SyntaxErrorException exception)
             {
-                System.Diagnostics.Debug.Assert(false, "A RecognitionException should be notified of, not thrown as a SyntaxErrorException. This lets the parser recover from parse errors.");
+                //System.Diagnostics.Debug.Assert(false, "A RecognitionException should be notified of, not thrown as a SyntaxErrorException. This lets the parser recover from parse errors.");
                 Logger.Error(exception, "Exception thrown in thread {0}.", Thread.CurrentThread.ManagedThreadId);
                 var failedHandler = ParseFailure;
                 if (failedHandler != null)
@@ -166,9 +166,9 @@ private string RewriteAndPreprocess()
 
         private IParseTree ParseInternal(string moduleName, string code, IParseTreeListener[] listeners, out ITokenStream outStream)
         {
-            var errorNotifier = new SyntaxErrorNotificationListener();
-            errorNotifier.OnSyntaxError += ParserSyntaxError;
-            return _parser.Parse(moduleName, code, listeners, errorNotifier, out outStream);
+            //var errorNotifier = new SyntaxErrorNotificationListener();
+            //errorNotifier.OnSyntaxError += ParserSyntaxError;
+            return _parser.Parse(moduleName, code, listeners, new ExceptionErrorListener(), out outStream);
         }
 
         private void ParserSyntaxError(object sender, SyntaxErrorEventArgs e)

Rubberduck.Parsing/VBA/VBADateLiteralParser.cs

@@ -3,6 +3,7 @@
 using NLog;
 using System;
 using Rubberduck.Parsing.Preprocessing;
+using Rubberduck.Parsing.Symbols;
 
 namespace Rubberduck.Parsing.VBA
 {
@@ -21,7 +22,7 @@ public VBADateParser.DateLiteralContext Parse(string date)
             var lexer = new VBADateLexer(stream);
             var tokens = new CommonTokenStream(lexer);
             var parser = new VBADateParser(tokens);
-            //parser.AddErrorListener(new SyntaxErrorNotificationListener()); // notify?
+            parser.AddErrorListener(new ExceptionErrorListener()); // notify?
             VBADateParser.CompilationUnitContext tree;
             try
             {