more green tests, but still getting false positive

Author: retailcoder

RetailCoder.VBE/Inspections/ParameterCanBeByValInspection.cs

@@ -60,7 +60,7 @@ private bool IsIssue(ParameterDeclaration declaration, Declaration[] userDeclara
                 !declaration.IsArray
                 && !declaration.IsParamArray
                 && (declaration.IsByRef || declaration.IsImplicitByRef)
-                && (declaration.AsTypeDeclaration == null || declaration.AsTypeDeclaration.DeclarationType != DeclarationType.UserDefinedType)
+                && (declaration.AsTypeDeclaration == null || declaration.AsTypeDeclaration.DeclarationType != DeclarationType.ClassModule && declaration.AsTypeDeclaration.DeclarationType != DeclarationType.UserDefinedType && declaration.AsTypeDeclaration.DeclarationType != DeclarationType.Enumeration)
                 && !declareScopes.Contains(declaration.ParentScope)
                 && !eventScopes.Contains(declaration.ParentScope)
                 && !interfaceScopes.Contains(declaration.ParentScope)

RubberduckTests/Inspections/ParameterCanBeByValInspectionTests.cs

@@ -16,6 +16,62 @@ namespace RubberduckTests.Inspections
     [TestClass]
     public class ParameterCanBeByValInspectionTests
     {
+            [TestMethod]
+            [TestCategory("Inspections")]
+            public void ParameterCanBeByVal_NoResultForByValClassInProperty()
+            {
+                const string class1Code = @"
+    Option Explicit
+    Public Sub DoSomething()
+    End sub
+    ";
+
+                const string inputCode =
+    @"Public Property Set Foo(ByVal value As Class1)
+    End Property";
+
+                //Arrange
+                var builder = new MockVbeBuilder();
+                var vbe = builder.ProjectBuilder("TestProject1", ProjectProtection.Unprotected)
+                    .AddComponent("Class1", ComponentType.ClassModule, class1Code)
+                    .AddComponent("Module1", ComponentType.StandardModule, inputCode)
+                    .MockVbeBuilder().Build();
+
+                var parser = MockParser.Create(vbe.Object, new RubberduckParserState(vbe.Object));
+                parser.Parse(new CancellationTokenSource());
+                if (parser.State.Status >= ParserState.Error) { Assert.Inconclusive("Parser Error"); }
+
+                var inspection = new ParameterCanBeByValInspection(parser.State);
+                var inspectionResults = inspection.GetInspectionResults();
+
+                Assert.AreEqual(0, inspectionResults.Count());
+            }
+
+        [TestMethod]
+        [TestCategory("Inspections")]
+        public void ParameterCanBeByVal_NoResultForByValObjectInProperty()
+        {
+            const string inputCode =
+@"Public Property Set Foo(ByVal value As Object)
+End Property";
+
+            //Arrange
+            var builder = new MockVbeBuilder();
+            IVBComponent component;
+            var vbe = builder.BuildFromSingleModule(inputCode, ComponentType.ClassModule, out component);
+            var mockHost = new Mock<IHostApplication>();
+            mockHost.SetupAllProperties();
+            var parser = MockParser.Create(vbe.Object, new RubberduckParserState(vbe.Object));
+
+            parser.Parse(new CancellationTokenSource());
+            if (parser.State.Status >= ParserState.Error) { Assert.Inconclusive("Parser Error"); }
+
+            var inspection = new ParameterCanBeByValInspection(parser.State);
+            var inspectionResults = inspection.GetInspectionResults();
+
+            Assert.AreEqual(0, inspectionResults.Count());
+        }
+
         [TestMethod]
         [TestCategory("Inspections")]
         public void ParameterCanBeByVal_NoResultForByValObject()