Skip to content

Commit ee648b9

Browse files
committed
Ignore const for implicitly Variant inspection. Closes #3728
1 parent 73a0e4b commit ee648b9

File tree

2 files changed

+19
-1
lines changed

2 files changed

+19
-1
lines changed

Rubberduck.CodeAnalysis/Inspections/Concrete/VariableTypeNotDeclaredInspection.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ public VariableTypeNotDeclaredInspection(RubberduckParserState state)
1717
protected override IEnumerable<IInspectionResult> DoGetInspectionResults()
1818
{
1919
var issues = from item in State.DeclarationFinder.UserDeclarations(DeclarationType.Variable)
20-
.Union(State.DeclarationFinder.UserDeclarations(DeclarationType.Constant))
2120
.Union(State.DeclarationFinder.UserDeclarations(DeclarationType.Parameter))
2221
where (item.DeclarationType != DeclarationType.Parameter || (item.DeclarationType == DeclarationType.Parameter && !item.IsArray))
2322
&& item.DeclarationType != DeclarationType.Control

RubberduckTests/Inspections/VariableTypeNotDeclaredInspectionTests.cs

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -178,6 +178,25 @@ Sub Foo(arg1)
178178
}
179179
}
180180

181+
[Test]
182+
[Category("Inspections")]
183+
public void VariableTypeNotDeclared_Const_DoesNotReturnResult()
184+
{
185+
const string inputCode =
186+
@"Sub Foo()
187+
Const bar = 42
188+
End Sub";
189+
var vbe = MockVbeBuilder.BuildFromSingleStandardModule(inputCode, out _);
190+
using (var state = MockParser.CreateAndParse(vbe.Object))
191+
{
192+
193+
var inspection = new VariableTypeNotDeclaredInspection(state);
194+
var inspectionResults = inspection.GetInspectionResults(CancellationToken.None);
195+
196+
Assert.IsFalse(inspectionResults.Any());
197+
}
198+
}
199+
181200
[Test]
182201
[Category("Inspections")]
183202
public void InspectionName()

0 commit comments

Comments
 (0)