Make single variable RHS case in ObjectVariableNotSetInspection respect declaration shadowing

Previously, the inspection simply used `IsAccessible`, which does not care for declaration shadowing. This commit changes this to using the identifier references, for which the resolver has already done all the work.

Author: MDoerner

Rubberduck.CodeAnalysis/Inspections/Concrete/VariableRequiresSetAssignmentEvaluator.cs

@@ -4,6 +4,7 @@
 using Rubberduck.Parsing.VBA;
 using System.Diagnostics;
 using System.Linq;
+using Rubberduck.VBEditor;
 
 namespace Rubberduck.Inspections
 {
@@ -100,10 +101,14 @@ public static bool RequiresSetAssignment(IdentifierReference reference, IDeclara
             var simpleName = expression.GetDescendent<VBAParser.SimpleNameExprContext>();
             if (simpleName != null && simpleName.GetText() == expression.GetText())
             {
-                return declarationFinderProvider.DeclarationFinder.MatchName(simpleName.identifier().GetText())
-                    .Any(d => AccessibilityCheck.IsAccessible(project, module, reference.ParentScoping, d) && d.IsObject);
+                var qualifiedIdentifierSelection = new QualifiedSelection(module.QualifiedModuleName,
+                    simpleName.identifier().GetSelection());
+                return declarationFinderProvider.DeclarationFinder.IdentifierReferences(qualifiedIdentifierSelection)
+                    .Any(identifierReference => identifierReference.Declaration.IsObject 
+                                                && simpleName.identifier().GetText() == identifierReference.Declaration.IdentifierName);
             }
 
+            //todo: Use code path analysis to ensure that we are really picking up the last assignment to the RHS.
             // is the reference referring to something else in scope that's a object?
             return declarationFinderProvider.DeclarationFinder.MatchName(expression.GetText())
                 .Any(decl => (decl.DeclarationType.HasFlag(DeclarationType.ClassModule) || Tokens.Object.Equals(decl.AsTypeName))

Rubberduck.Parsing/VBA/DeclarationCaching/DeclarationFinder.cs

@@ -1177,6 +1177,16 @@ public IEnumerable<IdentifierReference> IdentifierReferences(QualifiedModuleName
                 : Enumerable.Empty<IdentifierReference>();
         }
 
+        /// <summary>
+        /// Gets all identifier references in the specified module.
+        /// </summary>
+        public IEnumerable<IdentifierReference> IdentifierReferences(QualifiedSelection selection)
+        {
+            return _referencesBySelection.TryGetValue(selection, out var value)
+                ? value
+                : Enumerable.Empty<IdentifierReference>();
+        }
+
         /// <summary>
         /// Gets all identifier references in the specified member.
         /// </summary>

RubberduckTests/Inspections/ObjectVariableNotSetInspectionTests.cs

@@ -501,6 +501,25 @@ Dim bar As Collection
             AssertInputCodeYieldsExpectedInspectionResultCount(input, expectResultCount, new[]{"VBA.4.2"});
         }
 
+        [Test]
+        [Category("Inspections")]
+        public void ObjectVariableNotSet_SinlgeRHSVariableCaseRespectsDeclarationShadowing()
+        {
+
+            var expectResultCount = 0;
+            var input =
+                @"
+Private bar As Collection
+
+Private Sub Test()
+    Dim foo As Variant
+    Dim bar As Long
+    bar = 42
+    foo = bar
+End Sub";
+            AssertInputCodeYieldsExpectedInspectionResultCount(input, expectResultCount, new[] { "VBA.4.2" });
+        }
+
         [Test]
         [Category("Inspections")]
         public void ObjectVariableNotSet_LSetOnUDT_ReturnsNoResult()