Skip to content

Commit ed3e6ee

Browse files
authored
Merge pull request #1944 from Hosch250/Issue1397
Fix some localization
2 parents e6b454e + f9a7165 commit ed3e6ee

28 files changed

+137
-49
lines changed

RetailCoder.VBE/App.cs

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ public sealed class App : IDisposable
3737
private bool _handleSinkEvents = true;
3838
private readonly BranchesViewViewModel _branchesVM;
3939
private readonly SourceControlViewViewModel _sourceControlPanelVM;
40+
private readonly UI.Settings.Settings _settings;
4041

4142
private static readonly Logger Logger = LogManager.GetCurrentClassLogger();
4243

@@ -52,6 +53,7 @@ public sealed class App : IDisposable
5253
new Dictionary<string, Tuple<IConnectionPoint, int>>();
5354

5455
public App(VBE vbe, IMessageBox messageBox,
56+
UI.Settings.Settings settings,
5557
IRubberduckParser parser,
5658
IGeneralConfigService configService,
5759
IAppMenu appMenus,
@@ -61,6 +63,7 @@ public App(VBE vbe, IMessageBox messageBox,
6163
{
6264
_vbe = vbe;
6365
_messageBox = messageBox;
66+
_settings = settings;
6467
_parser = parser;
6568
_configService = configService;
6669
_autoSave = new AutoSave.AutoSave(_vbe, _configService);
@@ -543,6 +546,11 @@ public void Dispose()
543546
_hooks = null;
544547
}
545548

549+
if (_settings != null)
550+
{
551+
_settings.Dispose();
552+
}
553+
546554
if (_configService != null)
547555
{
548556
_configService.SettingsChanged -= _configService_SettingsChanged;

RetailCoder.VBE/Common/DeclarationExtensions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public static class DeclarationExtensions
2222

2323
public static string ToLocalizedString(this DeclarationType type)
2424
{
25-
return RubberduckUI.ResourceManager.GetString("DeclarationType_" + type);
25+
return RubberduckUI.ResourceManager.GetString("DeclarationType_" + type, UI.Settings.Settings.Culture);
2626
}
2727

2828
public static BitmapImage BitmapImage(this Declaration declaration)

RetailCoder.VBE/Inspections/DefaultProjectNameInspectionResult.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public class RenameProjectQuickFix : CodeInspectionQuickFix
4141
private readonly RubberduckParserState _state;
4242

4343
public RenameProjectQuickFix(ParserRuleContext context, QualifiedSelection selection, Declaration target, RubberduckParserState state)
44-
: base(context, selection, string.Format(RubberduckUI.Rename_DeclarationType, RubberduckUI.ResourceManager.GetString("DeclarationType_" + DeclarationType.Project, RubberduckUI.Culture)))
44+
: base(context, selection, string.Format(RubberduckUI.Rename_DeclarationType, RubberduckUI.ResourceManager.GetString("DeclarationType_" + DeclarationType.Project, UI.Settings.Settings.Culture)))
4545
{
4646
_target = target;
4747
_state = state;

RetailCoder.VBE/Inspections/InspectionBase.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,13 +54,13 @@ protected InspectionBase(RubberduckParserState state, CodeInspectionSeverity def
5454
/// <summary>
5555
/// Meta-information about why an inspection exists.
5656
/// </summary>
57-
public virtual string Meta { get { return InspectionsUI.ResourceManager.GetString(Name + "Meta"); } }
57+
public virtual string Meta { get { return InspectionsUI.ResourceManager.GetString(Name + "Meta", UI.Settings.Settings.Culture); } }
5858

5959
/// <summary>
6060
/// Gets a localized string representing the type of inspection.
6161
/// <see cref="InspectionType"/>
6262
/// </summary>
63-
public virtual string InspectionTypeName { get { return InspectionsUI.ResourceManager.GetString(InspectionType.ToString()); } }
63+
public virtual string InspectionTypeName { get { return InspectionsUI.ResourceManager.GetString(InspectionType.ToString(), UI.Settings.Settings.Culture); } }
6464

6565
/// <summary>
6666
/// Gets a string representing the text that must be present in an

RetailCoder.VBE/Inspections/Inspector.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ public async Task<IEnumerable<ICodeInspectionResult>> FindIssuesAsync(Rubberduck
8181
})).ToList();
8282

8383
await Task.WhenAll(inspections);
84-
state.OnStatusMessageUpdate(RubberduckUI.ResourceManager.GetString("ParserState_" + state.Status)); // should be "Ready"
84+
state.OnStatusMessageUpdate(RubberduckUI.ResourceManager.GetString("ParserState_" + state.Status, UI.Settings.Settings.Culture)); // should be "Ready"
8585
return allIssues;
8686
}
8787

RetailCoder.VBE/Inspections/UseMeaningfulNameInspectionResult.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ public UseMeaningfulNameInspectionResult(IInspection inspection, Declaration tar
2828

2929
public override string Description
3030
{
31-
get { return string.Format(InspectionsUI.UseMeaningfulNameInspectionResultFormat, RubberduckUI.ResourceManager.GetString("DeclarationType_" + Target.DeclarationType), Target.IdentifierName); }
31+
get { return string.Format(InspectionsUI.UseMeaningfulNameInspectionResultFormat, RubberduckUI.ResourceManager.GetString("DeclarationType_" + Target.DeclarationType, UI.Settings.Settings.Culture), Target.IdentifierName); }
3232
}
3333

3434
public override NavigateCodeEventArgs GetNavigationArgs()
@@ -47,7 +47,7 @@ public class RenameDeclarationQuickFix : CodeInspectionQuickFix
4747
private readonly IMessageBox _messageBox;
4848

4949
public RenameDeclarationQuickFix(ParserRuleContext context, QualifiedSelection selection, Declaration target, RubberduckParserState state, IMessageBox messageBox)
50-
: base(context, selection, string.Format(RubberduckUI.Rename_DeclarationType, RubberduckUI.ResourceManager.GetString("DeclarationType_" + target.DeclarationType, RubberduckUI.Culture)))
50+
: base(context, selection, string.Format(RubberduckUI.Rename_DeclarationType, RubberduckUI.ResourceManager.GetString("DeclarationType_" + target.DeclarationType, UI.Settings.Settings.Culture)))
5151
{
5252
_target = target;
5353
_state = state;

RetailCoder.VBE/Rubberduck.csproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -729,6 +729,7 @@
729729
<Compile Include="UI\Settings\InspectionSettingsViewModel.cs" />
730730
<Compile Include="UI\Settings\ISettingsView.cs" />
731731
<Compile Include="UI\Settings\ISettingsViewModel.cs" />
732+
<Compile Include="UI\Settings\Settings.cs" />
732733
<Compile Include="UI\Settings\SettingsControl.xaml.cs">
733734
<DependentUpon>SettingsControl.xaml</DependentUpon>
734735
</Compile>

RetailCoder.VBE/Settings/CodeInspectionSettings.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ public string LocalizedName
5353
{
5454
get
5555
{
56-
return InspectionsUI.ResourceManager.GetString(Name + "Name");
56+
return InspectionsUI.ResourceManager.GetString(Name + "Name", UI.Settings.Settings.Culture);
5757
}
5858
} // not serialized because culture-dependent
5959

@@ -71,25 +71,25 @@ public string Meta
7171
{
7272
get
7373
{
74-
return InspectionsUI.ResourceManager.GetString(Name + "Meta");
74+
return InspectionsUI.ResourceManager.GetString(Name + "Meta", UI.Settings.Settings.Culture);
7575
}
7676
}
7777

7878
[XmlIgnore]
7979
public string TypeLabel
8080
{
81-
get { return RubberduckUI.ResourceManager.GetString("CodeInspectionSettings_" + InspectionType); }
81+
get { return RubberduckUI.ResourceManager.GetString("CodeInspectionSettings_" + InspectionType, UI.Settings.Settings.Culture); }
8282
}
8383

8484
[XmlIgnore]
8585
public string SeverityLabel
8686
{
87-
get { return RubberduckUI.ResourceManager.GetString("CodeInspectionSeverity_" + Severity, RubberduckUI.Culture); }
87+
get { return RubberduckUI.ResourceManager.GetString("CodeInspectionSeverity_" + Severity, UI.Settings.Settings.Culture); }
8888
set
8989
{
9090
foreach (var severity in Enum.GetValues(typeof (CodeInspectionSeverity)))
9191
{
92-
if (value == RubberduckUI.ResourceManager.GetString("CodeInspectionSeverity_" + severity, RubberduckUI.Culture))
92+
if (value == RubberduckUI.ResourceManager.GetString("CodeInspectionSeverity_" + severity, UI.Settings.Settings.Culture))
9393
{
9494
Severity = (CodeInspectionSeverity)severity;
9595
return;

RetailCoder.VBE/Settings/HotkeySetting.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ public class HotkeySetting
2323
[XmlIgnore]
2424
public string Prompt
2525
{
26-
get { return RubberduckUI.ResourceManager.GetString("HotkeyDescription_" + Name); }
26+
get { return RubberduckUI.ResourceManager.GetString("HotkeyDescription_" + Name, UI.Settings.Settings.Culture); }
2727
}
2828

2929
public string ToMenuHotkeyString()

RetailCoder.VBE/Settings/MinimumLogLevel.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ public sealed class MinimumLogLevel
1010
public MinimumLogLevel(int ordinal, string logLevelName)
1111
{
1212
_ordinal = ordinal;
13-
_name = RubberduckUI.ResourceManager.GetString("GeneralSettings_" + logLevelName + "LogLevel");
13+
_name = RubberduckUI.ResourceManager.GetString("GeneralSettings_" + logLevelName + "LogLevel", UI.Settings.Settings.Culture);
1414
}
1515

1616
public int Ordinal

0 commit comments

Comments
 (0)