Skip to content

Commit eb4cc99

Browse files
retailcoderretailcoder
authored
Merge pull request #2409 from comintern/next
Various indenter fixes, partial fix for PassParameterByValueQuickFix
2 parents 6e4abe7 + c68f71e commit eb4cc99

File tree

9 files changed

+621
-39
lines changed

9 files changed

+621
-39
lines changed

‎RetailCoder.VBE/Inspections/ChangeParameterByRefByValQuickFix.cs

Lines changed: 32 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1+
using System;
12
using Antlr4.Runtime;
3+
using Rubberduck.Parsing.Grammar;
24
using Rubberduck.VBEditor;
35

46
namespace Rubberduck.Inspections
@@ -15,16 +17,38 @@ public ChangeParameterByRefByValQuickFix(ParserRuleContext context, QualifiedSel
1517

1618
public override void Fix()
1719
{
18-
var parameter = Context.GetText();
19-
var newContent = string.Concat(_newToken, " ", parameter);
20-
var selection = Selection.Selection;
21-
22-
var module = Selection.QualifiedName.Component.CodeModule;
20+
try
2321
{
24-
var lines = module.GetLines(selection.StartLine, selection.LineCount);
25-
var result = lines.Replace(parameter, newContent);
26-
module.ReplaceLine(selection.StartLine, result);
22+
dynamic context = Context;
23+
var parameter = Context.GetText();
24+
dynamic args = Context.parent;
25+
var argList = args.GetText();
26+
var module = Selection.QualifiedName.Component.CodeModule;
27+
{
28+
string result;
29+
if (context.OPTIONAL() != null)
30+
{
31+
result = parameter.Replace(Tokens.Optional, Tokens.Optional + ' ' + _newToken);
32+
}
33+
else
34+
{
35+
result = _newToken + ' ' + parameter;
36+
}
37+
38+
dynamic proc = args.parent;
39+
var startLine = proc.GetType().GetProperty("Start").GetValue(proc).Line;
40+
var stopLine = proc.GetType().GetProperty("Stop").GetValue(proc).Line;
41+
var code = module.GetLines(startLine, stopLine - startLine + 1);
42+
result = code.Replace(argList, argList.Replace(parameter, result));
43+
44+
foreach (var line in result.Split(new[] {"\r\n"}, StringSplitOptions.None))
45+
{
46+
module.ReplaceLine(startLine++, line);
47+
}
48+
}
2749
}
50+
// ReSharper disable once EmptyGeneralCatchClause
51+
catch { }
2852
}
2953
}
3054
}

‎RetailCoder.VBE/Inspections/PassParameterByValueQuickFix.cs

Lines changed: 33 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
using System;
12
using System.Linq;
23
using Antlr4.Runtime;
34
using Rubberduck.Common;
@@ -73,14 +74,42 @@ private void FixMethods()
7374

7475
private void FixMethod(VBAParser.ArgContext context, QualifiedSelection qualifiedSelection)
7576
{
76-
var selectionLength = context.BYREF() == null ? 0 : 6;
77+
var parameter = context.GetText();
78+
var argList = context.parent.GetText();
7779

7880
var module = qualifiedSelection.QualifiedName.Component.CodeModule;
7981
{
80-
var lines = module.GetLines(context.Start.Line, 1);
82+
string result;
83+
if (context.BYREF() != null)
84+
{
85+
result = parameter.Replace(Tokens.ByRef, Tokens.ByVal);
86+
}
87+
else if (context.OPTIONAL() != null)
88+
{
89+
result = parameter.Replace(Tokens.Optional, Tokens.Optional + ' ' + Tokens.ByVal);
90+
}
91+
else
92+
{
93+
result = Tokens.ByVal + ' ' + parameter;
94+
}
8195

82-
var result = lines.Remove(context.Start.Column, selectionLength).Insert(context.Start.Column, Tokens.ByVal + ' ');
83-
module.ReplaceLine(context.Start.Line, result);
96+
var startLine = 0;
97+
var stopLine = 0;
98+
try
99+
{
100+
dynamic proc = context.parent.parent;
101+
startLine = proc.GetType().GetProperty("Start").GetValue(proc).Line;
102+
stopLine = proc.GetType().GetProperty("Stop").GetValue(proc).Line;
103+
}
104+
catch { return; }
105+
106+
var code = module.GetLines(startLine, stopLine - startLine + 1);
107+
result = code.Replace(argList, argList.Replace(parameter, result));
108+
109+
foreach (var line in result.Split(new[] { "\r\n" }, StringSplitOptions.None))
110+
{
111+
module.ReplaceLine(startLine++, line);
112+
}
84113
}
85114
}
86115
}

‎Rubberduck.SmartIndenter/AbsoluteCodeLine.cs

Lines changed: 98 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,12 @@ namespace Rubberduck.SmartIndenter
1010
internal class AbsoluteCodeLine
1111
{
1212
private const string StupidLineEnding = ": _";
13-
private const string StringPlaceholder = "\a";
14-
private static readonly Regex StringLiteralRegex = new Regex("\"(?:[^\"]+|\"\")*\"");
15-
private static readonly Regex StringReplaceRegex = new Regex(StringPlaceholder);
13+
private const char StringPlaceholder = '\a';
14+
private const char BracketPlaceholder = '\x2';
15+
private static readonly Regex StringReplaceRegex = new Regex(StringPlaceholder.ToString(CultureInfo.InvariantCulture));
16+
private static readonly Regex BracketReplaceRegex = new Regex(BracketPlaceholder.ToString(CultureInfo.InvariantCulture));
1617
private static readonly Regex LineNumberRegex = new Regex(@"^(?<number>\d+)\s+(?<code>.*)", RegexOptions.ExplicitCapture);
17-
private static readonly Regex EndOfLineCommentRegex = new Regex(@"^(?!(Rem\s)|('))(?<code>.*)(\s(?<comment>'.*))$", RegexOptions.ExplicitCapture);
18+
private static readonly Regex EndOfLineCommentRegex = new Regex(@"^(?!(Rem\s)|('))(?<code>[^']*)(\s(?<comment>'.*))$", RegexOptions.ExplicitCapture);
1819
private static readonly Regex ProcedureStartRegex = new Regex(@"^(Public\s|Private\s|Friend\s)?(Static\s)?(Sub|Function|Property\s(Let|Get|Set))\s");
1920
private static readonly Regex ProcedureStartIgnoreRegex = new Regex(@"^[LR]?Set\s|^Let\s|^(Public|Private)\sDeclare\s(Function|Sub)");
2021
private static readonly Regex ProcedureEndRegex = new Regex(@"^End\s(Sub|Function|Property)");
@@ -31,9 +32,10 @@ internal class AbsoluteCodeLine
3132
private uint _lineNumber;
3233
private bool _numbered;
3334
private string _code;
34-
private bool _stupidLineEnding;
35+
private readonly bool _stupidLineEnding;
3536
private readonly string[] _segments;
3637
private List<string> _strings;
38+
private List<string> _brackets;
3739

3840
public AbsoluteCodeLine(string code, IIndenterSettings settings)
3941
{
@@ -51,23 +53,69 @@ public AbsoluteCodeLine(string code, IIndenterSettings settings)
5153

5254
Original = code;
5355

54-
ExtractStringLiterals();
56+
ExtractStringLiteralsAndBrackets();
5557
ExtractLineNumber();
5658
ExtractEndOfLineComment();
57-
59+
_code = Regex.Replace(_code, StringPlaceholder + "+", StringPlaceholder.ToString(CultureInfo.InvariantCulture));
60+
_code = Regex.Replace(_code, BracketPlaceholder + "+", BracketPlaceholder.ToString(CultureInfo.InvariantCulture)).Trim();
5861
_segments = _code.Split(new[] { ": " }, StringSplitOptions.None);
5962
}
6063

61-
private void ExtractStringLiterals()
64+
//TODO: This should be a class.
65+
private void ExtractStringLiteralsAndBrackets()
6266
{
6367
_strings = new List<string>();
64-
var matches = StringLiteralRegex.Matches(_code);
65-
if (matches.Count == 0) return;
66-
foreach (var match in matches)
68+
_brackets = new List<string>();
69+
70+
var chars = _code.ToCharArray();
71+
var quoted = false;
72+
var bracketed = false;
73+
var ins = 0;
74+
var strpos = 0;
75+
var brkpos = 0;
76+
for (var c = 0; c < chars.Length; c++)
6777
{
68-
_strings.Add(match.ToString());
78+
if (chars[c] == '"' && !bracketed)
79+
{
80+
if (!quoted)
81+
{
82+
strpos = c;
83+
quoted = true;
84+
continue;
85+
}
86+
if (c + 1 < chars.Length && chars[c] == '"')
87+
{
88+
c++;
89+
}
90+
quoted = false;
91+
_strings.Add(new string(chars.Skip(strpos).Take(c - strpos).ToArray()));
92+
for (var e = strpos; e < c; e++)
93+
{
94+
chars[e] = StringPlaceholder;
95+
}
96+
}
97+
else if (!quoted && !bracketed && chars[c] == '[')
98+
{
99+
bracketed = true;
100+
brkpos = c;
101+
ins++;
102+
}
103+
else if (!quoted && bracketed && chars[c] == ']')
104+
{
105+
ins--;
106+
if (ins != 0)
107+
{
108+
continue;
109+
}
110+
bracketed = false;
111+
_brackets.Add(new string(chars.Skip(brkpos).Take(c - brkpos).ToArray()));
112+
for (var e = brkpos; e < c; e++)
113+
{
114+
chars[e] = BracketPlaceholder;
115+
}
116+
}
69117
}
70-
_code = StringLiteralRegex.Replace(_code, StringPlaceholder);
118+
_code = new string(chars);
71119
}
72120

73121
private void ExtractLineNumber()
@@ -77,12 +125,9 @@ private void ExtractLineNumber()
77125
{
78126
_numbered = true;
79127
_lineNumber = Convert.ToUInt32(match.Groups["number"].Value);
80-
_code = match.Groups["code"].Value.Trim();
81-
}
82-
else
83-
{
84-
_code = _code.Trim();
128+
_code = match.Groups["code"].Value;
85129
}
130+
_code = _code.Trim();
86131
}
87132

88133
private void ExtractEndOfLineComment()
@@ -98,7 +143,24 @@ private void ExtractEndOfLineComment()
98143
}
99144

100145
public string Original { get; private set; }
101-
146+
147+
public string Escaped
148+
{
149+
get
150+
{
151+
var output = Original;
152+
foreach (var item in _strings)
153+
{
154+
output = output.Replace(item, new string(StringPlaceholder, item.Length));
155+
}
156+
foreach (var item in _brackets)
157+
{
158+
output = output.Replace(item, new string(BracketPlaceholder, item.Length));
159+
}
160+
return output;
161+
}
162+
}
163+
102164
public string EndOfLineComment { get; private set; }
103165

104166
public IEnumerable<string> Segments
@@ -146,7 +208,7 @@ public bool HasContinuation
146208

147209
public bool IsPrecompilerDirective
148210
{
149-
get { return Original.TrimStart().StartsWith("#"); }
211+
get { return _code.TrimStart().StartsWith("#"); }
150212
}
151213

152214
public bool IsBareDebugStatement
@@ -248,6 +310,10 @@ public string Indent(int indents, bool atProcStart, bool absolute = false)
248310
{
249311
code = _strings.Aggregate(code, (current, literal) => StringReplaceRegex.Replace(current, literal, 1));
250312
}
313+
if (_brackets.Any())
314+
{
315+
code = _brackets.Aggregate(code, (current, expr) => BracketReplaceRegex.Replace(current, expr, 1));
316+
}
251317

252318
code = string.Join(string.Empty, number, new string(' ', gap), code);
253319
if (string.IsNullOrEmpty(EndOfLineComment))
@@ -283,10 +349,20 @@ public override string ToString()
283349
}
284350

285351
private void AlignDims(int postition)
286-
{
352+
{
353+
if (_segments[0].Trim().StartsWith("As "))
354+
{
355+
_segments[0] = string.Format("{0}{1}", new String(' ', _settings.AlignDimColumn - postition - 1), _segments[0].Trim());
356+
return;
357+
}
287358
var alignTokens = _segments[0].Split(new[] { " As " }, StringSplitOptions.None);
359+
if (alignTokens.Length <= 1)
360+
{
361+
return;
362+
}
288363
var gap = Math.Max(_settings.AlignDimColumn - postition - alignTokens[0].Length - 2, 0);
289-
_segments[0] = string.Format("{0}{1} As {2}", alignTokens[0].Trim(), new string(' ', gap), string.Join(" As ", alignTokens.Skip(1)));
364+
_segments[0] = string.Format("{0}{1} As {2}", alignTokens[0].Trim(), new string(' ', gap),
365+
string.Join(" As ", alignTokens.Skip(1)));
290366
}
291367
}
292368
}

‎Rubberduck.SmartIndenter/LogicalCodeLine.cs

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ public string Indented()
132132
var current = _lines.First().Indent(IndentationLevel, AtProcedureStart);
133133
var commentPos = string.IsNullOrEmpty(_lines.First().EndOfLineComment) ? 0 : current.Length - _lines.First().EndOfLineComment.Length;
134134
output.Add(current);
135-
var alignment = FunctionAlign(current, _lines[1].Original.Trim().StartsWith(":="));
135+
var alignment = FunctionAlign(current, _lines[1].Escaped.Trim().StartsWith(":="));
136136

137137
//foreach (var line in _lines.Skip(1))
138138
for (var i = 1; i < _lines.Count; i++)
@@ -156,7 +156,7 @@ public string Indented()
156156
var operatorAdjust = _settings.IgnoreOperatorsInContinuations && OperatorIgnoreRegex.IsMatch(line.Original) ? 2 : 0;
157157
current = line.Indent(Math.Max(alignment - operatorAdjust, 0), AtProcedureStart, true);
158158
output.Add(current);
159-
alignment = FunctionAlign(current, i + 1 < _lines.Count && _lines[i + 1].Original.Trim().StartsWith(":="));
159+
alignment = FunctionAlign(current, i + 1 < _lines.Count && _lines[i + 1].Escaped.Trim().StartsWith(":="));
160160
commentPos = string.IsNullOrEmpty(line.EndOfLineComment) ? 0 : current.Length - line.EndOfLineComment.Length;
161161
}
162162

@@ -181,9 +181,11 @@ private int FunctionAlign(string line, bool splitNamed)
181181
var character = line.Substring(index - 1, 1);
182182
switch (character)
183183
{
184-
case "\"":
185-
//A String => jump to the end of it
186-
while (!line.Substring(index++, 1).Equals("\"")) { }
184+
case "\a":
185+
while (!line.Substring(index++, 1).Equals("\a")) { }
186+
break;
187+
case "\x2":
188+
while (!line.Substring(index++, 1).Equals("\x2")) { }
187189
break;
188190
case "(":
189191
//Start of another function => remember this position

0 commit comments

Comments
 (0)