Skip to content

Commit ea609e0

Browse files
committed
added component name to OptionExplicit inspection description; fixed ducky icon in localized resources
1 parent 5984913 commit ea609e0

24 files changed

+350
-284
lines changed

RetailCoder.VBE/Inspections/InspectionsUI.Designer.cs

Lines changed: 3 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

RetailCoder.VBE/Inspections/InspectionsUI.resx

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -118,15 +118,12 @@
118118
<value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
119119
</resheader>
120120
<data name="EmptyStringLiteralInspection" xml:space="preserve">
121-
<value>Intent of empty string literal could be clarified with 'vbNullString'.</value>
121+
<value>Prefer 'vbNullString' to an empty string literal</value>
122122
</data>
123123
<data name="EmptyStringLiteralInspectionQuickFix" xml:space="preserve">
124-
<value>Replace '""' with 'vbNullString'.</value>
124+
<value>Replace empty string with the 'vbNullString' constant</value>
125125
</data>
126126
<data name="UseMeaningfulNameInspection" xml:space="preserve">
127-
<value>Identifier '{0}' could probably use a better name.</value>
128-
</data>
129-
<data name="UseMeaningfulNameInspectionQuickFix" xml:space="preserve">
130-
<value>Rename identifier</value>
127+
<value>Consider renaming {0} '{1}'</value>
131128
</data>
132129
</root>

RetailCoder.VBE/Inspections/OptionExplicitInspectionResult.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ public class OptionExplicitInspectionResult : CodeInspectionResultBase
1313
private readonly IEnumerable<CodeInspectionQuickFix> _quickFixes;
1414

1515
public OptionExplicitInspectionResult(IInspection inspection, QualifiedModuleName qualifiedName)
16-
: base(inspection, inspection.Description, new CommentNode(string.Empty, new QualifiedSelection(qualifiedName, Selection.Home)))
16+
: base(inspection, string.Format(inspection.Description,qualifiedName.ComponentName), new CommentNode(string.Empty, new QualifiedSelection(qualifiedName, Selection.Home)))
1717
{
1818
_quickFixes = new[]
1919
{

RetailCoder.VBE/Inspections/UseMeaningfulNameInspectionResult.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ public class UseMeaningfulNameInspectionResult : CodeInspectionResultBase
1515
private readonly IEnumerable<CodeInspectionQuickFix> _quickFixes;
1616

1717
public UseMeaningfulNameInspectionResult(IInspection inspection, Declaration target, RubberduckParserState parserState, ICodePaneWrapperFactory wrapperFactory, IMessageBox messageBox)
18-
: base(inspection, string.Format(inspection.Description, target.IdentifierName), target)
18+
: base(inspection, string.Format(inspection.Description, RubberduckUI.ResourceManager.GetString("DeclarationType_" + target.DeclarationType, RubberduckUI.Culture), target.IdentifierName), target)
1919
{
2020
_quickFixes = new[]
2121
{

RetailCoder.VBE/UI/FindSymbol/FindSymbolDialog.Designer.cs

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)