Skip to content

Commit e991c43

Browse files
committed
Update VBESettingsTest to not use the Locale-Dependent decimal.Parse
1 parent fecd93b commit e991c43

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

Rubberduck.Core/Properties/AssemblyInfo.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
[assembly: AssemblyProduct("Rubberduck.Core")]
1313
[assembly: AssemblyCopyright("Copyright © 2014-2018")]
1414
[assembly: AssemblyTrademark("")]
15-
[assembly: AssemblyCulture("en")]
15+
[assembly: AssemblyCulture("")]
1616
[assembly: InternalsVisibleTo("Rubberduck.Main")]
1717
[assembly: InternalsVisibleTo("RubberduckTests")]
1818

Rubberduck.Core/VBERuntime/VBESettings.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ public VBESettings(IVBE vbe, IRegistryWrapper registry)
2424
{
2525
try
2626
{
27-
switch (Convert.ToInt32(decimal.Parse(vbe.Version)))
27+
switch (int.Parse(vbe.Version.Split('.')[0]))
2828
{
2929
case 6:
3030
Version = DllVersion.Vbe6;

RubberduckTests/VBE/VBESettingsTests.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public void DllVersion_MustBe6()
2929
vbe.SetupGet(s => s.Version).Returns("6.00");
3030
var settings = new VBESettings(vbe.Object, registry.Object);
3131

32-
Assert.IsTrue(settings.Version == VBESettings.DllVersion.Vbe6);
32+
Assert.AreEqual(VBESettings.DllVersion.Vbe6, settings.Version);
3333
}
3434

3535
[Category("VBE")]
@@ -42,7 +42,7 @@ public void DllVersion_MustBe7()
4242
vbe.SetupGet(s => s.Version).Returns("7.00");
4343
var settings = new VBESettings(vbe.Object, registry.Object);
4444

45-
Assert.IsTrue(settings.Version == VBESettings.DllVersion.Vbe7);
45+
Assert.AreEqual(VBESettings.DllVersion.Vbe7, settings.Version);
4646
}
4747

4848
[Category("VBE")]
@@ -55,7 +55,7 @@ public void DllVersion_IsBogus()
5555
vbe.SetupGet(s => s.Version).Returns("foo");
5656
var settings = new VBESettings(vbe.Object, registry.Object);
5757

58-
Assert.IsTrue(settings.Version == VBESettings.DllVersion.Unknown);
58+
Assert.AreEqual(VBESettings.DllVersion.Unknown, settings.Version);
5959
}
6060

6161
[Category("VBE")]

0 commit comments

Comments
 (0)