Make UseSetKeywordForObjectAssignmentQuickFix able to deal with Suspicious Let assignments

Author: MDoerner

Rubberduck.CodeAnalysis/QuickFixes/UseSetKeywordForObjectAssignmentQuickFix.cs

@@ -10,7 +10,7 @@ namespace Rubberduck.Inspections.QuickFixes
     public sealed class UseSetKeywordForObjectAssignmentQuickFix : QuickFixBase
     {
         public UseSetKeywordForObjectAssignmentQuickFix()
-            : base(typeof(ObjectVariableNotSetInspection))
+            : base(typeof(ObjectVariableNotSetInspection), typeof(SuspiciousLetAssignmentInspection))
         {}
 
         public override void Fix(IInspectionResult result, IRewriteSession rewriteSession)

RubberduckTests/QuickFixes/ExpandBangNotationQuickFixTests.cs

@@ -3,7 +3,6 @@
 using Rubberduck.Inspections.Concrete;
 using Rubberduck.Parsing.Inspections.Abstract;
 using Rubberduck.Parsing.VBA;
-using Rubberduck.Parsing.VBA.Parsing;
 using Rubberduck.VBEditor.SafeComWrappers;
 using RubberduckTests.Mocks;
 
@@ -46,7 +45,7 @@ End Function
                 ("Class2", class2Code, ComponentType.ClassModule),
                 ("Module1", moduleCode, ComponentType.StandardModule));
 
-            var actualModuleCode = ApplyQuickFixToFirstInspectionResult(vbe.Object, "Module1", state => new UseOfBangNotationInspection(state), CodeKind.AttributesCode);
+            var actualModuleCode = ApplyQuickFixToFirstInspectionResult(vbe.Object, "Module1", state => new UseOfBangNotationInspection(state));
             Assert.AreEqual(expectedModuleCode, actualModuleCode);
         }
 
@@ -85,7 +84,7 @@ End Function
                 ("Class2", class2Code, ComponentType.ClassModule),
                 ("Module1", moduleCode, ComponentType.StandardModule));
 
-            var actualModuleCode = ApplyQuickFixToFirstInspectionResult(vbe.Object, "Module1", state => new UseOfRecursiveBangNotationInspection(state), CodeKind.AttributesCode);
+            var actualModuleCode = ApplyQuickFixToFirstInspectionResult(vbe.Object, "Module1", state => new UseOfRecursiveBangNotationInspection(state));
             Assert.AreEqual(expectedModuleCode, actualModuleCode);
         }
 
@@ -126,7 +125,7 @@ End Function
                 ("Class2", class2Code, ComponentType.ClassModule),
                 ("Module1", moduleCode, ComponentType.StandardModule));
 
-            var actualModuleCode = ApplyQuickFixToFirstInspectionResult(vbe.Object, "Module1", state => new UseOfBangNotationInspection(state), CodeKind.AttributesCode);
+            var actualModuleCode = ApplyQuickFixToFirstInspectionResult(vbe.Object, "Module1", state => new UseOfBangNotationInspection(state));
             Assert.AreEqual(expectedModuleCode, actualModuleCode);
         }
 
@@ -167,7 +166,7 @@ End Function
                 ("Class2", class2Code, ComponentType.ClassModule),
                 ("Module1", moduleCode, ComponentType.StandardModule));
 
-            var actualModuleCode = ApplyQuickFixToFirstInspectionResult(vbe.Object, "Module1", state => new UseOfRecursiveBangNotationInspection(state), CodeKind.AttributesCode);
+            var actualModuleCode = ApplyQuickFixToFirstInspectionResult(vbe.Object, "Module1", state => new UseOfRecursiveBangNotationInspection(state));
             Assert.AreEqual(expectedModuleCode, actualModuleCode);
         }
 

RubberduckTests/QuickFixes/UseSetKeywordForObjectAssignmentQuickFixTests.cs

@@ -97,6 +97,47 @@ End Property
             Assert.AreEqual(expectedCode, actualCode);
         }
 
+        [Test]
+        [Category("Inspections")]
+        public void BothSidesOfAssignmentHaveDefaultMemberAccess_NoExplicitLet_QuickFixWorks()
+        {
+            var class1Code = @"
+Public Property Get Baz() As Long
+Attribute Baz.VB_UserMemId = 0
+End Property
+
+Public Property Let Baz(RHS As Long)
+End Property
+";
+
+            var moduleCode = $@"
+Private Sub Bar() 
+    Dim cls1 As Class1
+    Dim cls2 As Class1
+    Set cls1 = New Class1
+    Set cls2 = New Class1
+    cls2 = cls1
+End Sub
+";
+
+            var expectedModuleCode = $@"
+Private Sub Bar() 
+    Dim cls1 As Class1
+    Dim cls2 As Class1
+    Set cls1 = New Class1
+    Set cls2 = New Class1
+    Set cls2 = cls1
+End Sub
+";
+
+            var vbe = MockVbeBuilder.BuildFromModules(
+                ("Class1", class1Code, ComponentType.ClassModule),
+                ("Module1", moduleCode, ComponentType.StandardModule));
+
+            var actualModuleCode = ApplyQuickFixToAllInspectionResults(vbe.Object, "Module1", state => new SuspiciousLetAssignmentInspection(state));
+            Assert.AreEqual(expectedModuleCode, actualModuleCode);
+        }
+
 
         protected override IQuickFix QuickFix(RubberduckParserState state)
         {