Make CE refresh non-async for the tests

Author: Hosch250

RetailCoder.VBE/Navigation/CodeExplorer/CodeExplorerViewModel.cs

@@ -28,7 +28,7 @@ public CodeExplorerViewModel(FolderHelper folderHelper, RubberduckParserState st
             _folderHelper = folderHelper;
             _state = state;
             _state.StateChanged += ParserState_StateChanged;
-            
+
             _refreshCommand = new DelegateCommand(param => _state.OnParseRequested(this),
                 param => !IsBusy && _state.IsDirty());
 
@@ -188,38 +188,38 @@ public string PanelTitle
 
                 if (SelectedItem is CodeExplorerProjectViewModel)
                 {
-                    var node = (CodeExplorerProjectViewModel) SelectedItem;
+                    var node = (CodeExplorerProjectViewModel)SelectedItem;
                     return node.Declaration.IdentifierName + string.Format(" - ({0})", node.Declaration.DeclarationType);
                 }
 
                 if (SelectedItem is CodeExplorerComponentViewModel)
                 {
-                    var node = (CodeExplorerComponentViewModel) SelectedItem;
+                    var node = (CodeExplorerComponentViewModel)SelectedItem;
                     return node.Declaration.IdentifierName + string.Format(" - ({0})", node.Declaration.DeclarationType);
                 }
 
                 if (SelectedItem is CodeExplorerMemberViewModel)
                 {
-                    var node = (CodeExplorerMemberViewModel) SelectedItem;
+                    var node = (CodeExplorerMemberViewModel)SelectedItem;
                     return node.Declaration.IdentifierName + string.Format(" - ({0})", node.Declaration.DeclarationType);
                 }
 
                 return SelectedItem.Name;
             }
         }
-        
+
         public string Description
         {
             get
             {
                 if (SelectedItem is ICodeExplorerDeclarationViewModel)
                 {
-                    return ((ICodeExplorerDeclarationViewModel) SelectedItem).Declaration.DescriptionString;
+                    return ((ICodeExplorerDeclarationViewModel)SelectedItem).Declaration.DescriptionString;
                 }
 
                 if (SelectedItem is CodeExplorerCustomFolderViewModel)
                 {
-                    return ((CodeExplorerCustomFolderViewModel) SelectedItem).FolderAttribute;
+                    return ((CodeExplorerCustomFolderViewModel)SelectedItem).FolderAttribute;
                 }
 
                 return string.Empty;
@@ -237,47 +237,44 @@ public ObservableCollection<CodeExplorerItemViewModel> Projects
             set
             {
                 _projects = new ObservableCollection<CodeExplorerItemViewModel>(value.OrderBy(o => o.NameWithSignature));
-                
+
                 ReorderChildNodes(_projects);
                 OnPropertyChanged();
             }
         }
 
         private void ParserState_StateChanged(object sender, EventArgs e)
         {
-            UiDispatcher.InvokeAsync(() =>
+            if (Projects == null)
             {
-                if (Projects == null)
-                {
-                    Projects = new ObservableCollection<CodeExplorerItemViewModel>();
-                }
+                Projects = new ObservableCollection<CodeExplorerItemViewModel>();
+            }
 
-                IsBusy = _state.Status < ParserState.ResolvedDeclarations;
-                if (_state.Status != ParserState.ResolvedDeclarations)
-                {
-                    return;
-                }
+            IsBusy = _state.Status < ParserState.ResolvedDeclarations;
+            if (_state.Status != ParserState.ResolvedDeclarations)
+            {
+                return;
+            }
 
-                var userDeclarations = _state.AllUserDeclarations
-                    .GroupBy(declaration => declaration.Project)
-                    .Where(grouping => grouping.Key != null)
-                    .ToList();
+            var userDeclarations = _state.AllUserDeclarations
+                .GroupBy(declaration => declaration.Project)
+                .Where(grouping => grouping.Key != null)
+                .ToList();
 
-                if (userDeclarations.Any(
+            if (userDeclarations.Any(
                     grouping => grouping.All(declaration => declaration.DeclarationType != DeclarationType.Project)))
-                {
-                    return;
-                }
+            {
+                return;
+            }
 
-                var newProjects = userDeclarations.Select(grouping =>
-                    new CodeExplorerProjectViewModel(_folderHelper,
-                        grouping.SingleOrDefault(declaration => declaration.DeclarationType == DeclarationType.Project),
-                        grouping)).ToList();
+            var newProjects = userDeclarations.Select(grouping =>
+                new CodeExplorerProjectViewModel(_folderHelper,
+                    grouping.SingleOrDefault(declaration => declaration.DeclarationType == DeclarationType.Project),
+                    grouping)).ToList();
 
-                UpdateNodes(Projects, newProjects);
+            UpdateNodes(Projects, newProjects);
 
-                Projects = new ObservableCollection<CodeExplorerItemViewModel>(newProjects);
-            });
+            Projects = new ObservableCollection<CodeExplorerItemViewModel>(newProjects);
         }
 
         private void UpdateNodes(IEnumerable<CodeExplorerItemViewModel> oldList,
@@ -406,7 +403,7 @@ private void SetErrorState(CodeExplorerItemViewModel itemNode, VBComponent compo
 
                 if (node is CodeExplorerComponentViewModel)
                 {
-                    var componentNode = (CodeExplorerComponentViewModel) node;
+                    var componentNode = (CodeExplorerComponentViewModel)node;
                     if (componentNode.GetSelectedDeclaration().QualifiedName.QualifiedModuleName.Component == component)
                     {
                         componentNode.IsErrorState = true;
@@ -475,8 +472,8 @@ private void SetErrorState(CodeExplorerItemViewModel itemNode, VBComponent compo
         // this is a special case--we have to reset SelectedItem to prevent a crash
         private void ExecuteRemoveComand(object param)
         {
-            var node = (CodeExplorerComponentViewModel) SelectedItem;
-            SelectedItem = Projects.First(p => ((CodeExplorerProjectViewModel) p).Declaration.Project == node.Declaration.Project);
+            var node = (CodeExplorerComponentViewModel)SelectedItem;
+            SelectedItem = Projects.First(p => ((CodeExplorerProjectViewModel)p).Declaration.Project == node.Declaration.Project);
 
             _externalRemoveCommand.Execute(param);
         }

Rubberduck.Parsing/VBA/RubberduckParser.cs

@@ -147,7 +147,7 @@ private void ParseAll()
                 return;
             }
 
-
+            
             lock (_state)  // note, method is invoked from UI thread... really need the lock here?
             {
                 foreach (var component in toParse)