Merge pull request #2574 from comintern/next

Fix MarkAsDead so it doesn't eat too extra NewLines. Closes #2022

Author: retailcoder

Rubberduck.Parsing/Preprocessing/LivelinessExpression.cs

@@ -16,44 +16,23 @@ public LivelinessExpression(IExpression isAlive, IExpression code)
 
         public override IValue Evaluate()
         {
-            bool isAlive = _isAlive.Evaluate().AsBool;
+            var isAlive = _isAlive.Evaluate().AsBool;
             var code = _code.Evaluate().AsString;
-            if (isAlive)
-            {
-                return new StringValue(code);
-            }
-            else
-            {
-                return new StringValue(MarkAsDead(code));
-            }
+            return isAlive ? new StringValue(code) : new StringValue(MarkAsDead(code));
         }
 
         private string MarkAsDead(string code)
         {
-            bool hasNewLine = false;
-            if (code.EndsWith(Environment.NewLine))
-            {
-                hasNewLine = true;
-            }
+            var hasNewLine = code.EndsWith(Environment.NewLine);
             // Remove parsed new line.
-            code = code.TrimEnd('\r', '\n');
-            var lines = code.Split(new string[] { Environment.NewLine }, StringSplitOptions.None);
+            code = code.Substring(0, code.Length - Environment.NewLine.Length);
+            var lines = code.Split(new[] { Environment.NewLine }, StringSplitOptions.None);
             var result = string.Join(Environment.NewLine, lines.Select(_ => string.Empty));
             if (hasNewLine)
             {
                 result += Environment.NewLine;
             }
             return result;
         }
-
-        private string MarkLineAsDead(string line)
-        {
-            var result = string.Empty;
-            if (line.EndsWith(Environment.NewLine))
-            {
-                result += Environment.NewLine;
-            }
-            return result;
-        }
     }
 }