Add RemoveAttributeQuickFix

Author: MDoerner

Rubberduck.CodeAnalysis/QuickFixes/RemoveAttributeQuickFix.cs

@@ -0,0 +1,43 @@
+using System.Collections.Generic;
+using Rubberduck.Inspections.Abstract;
+using Rubberduck.Inspections.Concrete;
+using Rubberduck.Parsing.Inspections.Abstract;
+using Rubberduck.Parsing.Rewriter;
+using Rubberduck.Parsing.Symbols;
+using Rubberduck.Parsing.VBA;
+using Rubberduck.Parsing.VBA.Parsing;
+
+namespace Rubberduck.Inspections.QuickFixes
+{
+    public class RemoveAttributeQuickFix : QuickFixBase
+    {
+        private readonly IAttributesUpdater _attributesUpdater;
+
+        public RemoveAttributeQuickFix(IAttributesUpdater attributesUpdater)
+        :base(typeof(AttributeValueOutOfSyncInspection))
+        {
+            _attributesUpdater = attributesUpdater;
+        }
+
+        public override void Fix(IInspectionResult result, IRewriteSession rewriteSession)
+        {
+            var declaration = result.Target;
+            string attributeBaseName = result.Properties.AttributeName; 
+            IReadOnlyList<string> attributeValues = result.Properties.AttributeValues;
+
+            var attributeName = declaration.DeclarationType.HasFlag(DeclarationType.Module)
+                ? attributeBaseName
+                : $"{declaration.IdentifierName}.{attributeBaseName}";
+
+            _attributesUpdater.RemoveAttribute(rewriteSession, declaration, attributeName, attributeValues);
+        }
+
+        public override string Description(IInspectionResult result) => Resources.Inspections.QuickFixes.RemoveAttributeQuickFix;
+
+        public override CodeKind TargetCodeKind => CodeKind.AttributesCode;
+
+        public override bool CanFixInProcedure => false;
+        public override bool CanFixInModule => false;
+        public override bool CanFixInProject => false;
+    }
+}

Rubberduck.Resources/Inspections/QuickFixes.Designer.cs

@@ -267,4 +267,7 @@
   <data name="AdjustAttributeValuesQuickFix" xml:space="preserve">
     <value>Attributwert(e) anpassen</value>
   </data>
+  <data name="RemoveAttributeQuickFix" xml:space="preserve">
+    <value>Attribut entfernen</value>
+  </data>
 </root>

Rubberduck.Resources/Inspections/QuickFixes.de.resx

@@ -267,4 +267,7 @@
   <data name="AdjustAttributeValuesQuickFix" xml:space="preserve">
     <value>Adjust attribute value(s)</value>
   </data>
+  <data name="RemoveAttributeQuickFix" xml:space="preserve">
+    <value>Remove attribute</value>
+  </data>
 </root>

Rubberduck.Resources/Inspections/QuickFixes.resx

@@ -0,0 +1,104 @@
+using NUnit.Framework;
+using Rubberduck.Inspections.Concrete;
+using Rubberduck.Inspections.QuickFixes;
+using Rubberduck.Parsing.Inspections.Abstract;
+using Rubberduck.Parsing.VBA;
+using Rubberduck.Parsing.VBA.Parsing;
+
+namespace RubberduckTests.QuickFixes
+{
+    [TestFixture]
+    public class RemoveAttributeQuickFixTests : QuickFixTestBase
+    {
+        [Test]
+        [Category("QuickFixes")]
+        public void ModuleAttributeWithoutAnnotation_QuickFixWorks()
+        {
+            const string inputCode =
+                @"Attribute VB_Description = ""Desc""
+Public Sub Foo()
+    Const const1 As Integer = 9
+End Sub";
+
+            const string expectedCode =
+                @"Public Sub Foo()
+    Const const1 As Integer = 9
+End Sub";
+
+            var actualCode = ApplyQuickFixToFirstInspectionResult(inputCode, state => new MissingModuleAnnotationInspection(state), CodeKind.AttributesCode);
+            Assert.AreEqual(expectedCode, actualCode);
+        }
+
+        [Test]
+        [Category("QuickFixes")]
+        public void VbExtKeyModuleAttributeWithoutAnnotationForOneKey_QuickFixWorks()
+        {
+            const string inputCode =
+                @"Attribute VB_Ext_Key = ""Key"", ""NotValue""
+Attribute VB_Ext_Key = ""OtherKey"", ""OtherValue""
+'@ModuleAttribute VB_Ext_Key, ""Key"", ""Value""
+Public Sub Foo()
+    Const const1 As Integer = 9
+End Sub";
+
+            const string expectedCode =
+                @"Attribute VB_Ext_Key = ""Key"", ""NotValue""
+'@ModuleAttribute VB_Ext_Key, ""Key"", ""Value""
+Public Sub Foo()
+    Const const1 As Integer = 9
+End Sub";
+
+            var actualCode = ApplyQuickFixToFirstInspectionResult(inputCode, state => new MissingModuleAnnotationInspection(state), CodeKind.AttributesCode);
+            Assert.AreEqual(expectedCode, actualCode);
+        }
+
+        [Test]
+        [Category("QuickFixes")]
+        public void MemberAttributeWithoutAnnotation_QuickFixWorks()
+        {
+            const string inputCode =
+                @"
+Public Sub Foo()
+Attribute Foo.VB_Description = ""NotDesc""
+    Const const1 As Integer = 9
+End Sub";
+
+            const string expectedCode =
+                @"
+Public Sub Foo()
+    Const const1 As Integer = 9
+End Sub";
+
+            var actualCode = ApplyQuickFixToFirstInspectionResult(inputCode, state => new MissingMemberAnnotationInspection(state), CodeKind.AttributesCode);
+            Assert.AreEqual(expectedCode, actualCode);
+        }
+
+        [Test]
+        [Category("QuickFixes")]
+        public void VbExtKeyMemberAttributeWithoutAnnotationForOneKey_QuickFixWorks()
+        {
+            const string inputCode =
+                @"'@MemberAttribute VB_Ext_Key, ""Key"", ""Value""
+Public Sub Foo()
+Attribute Foo.VB_Ext_Key = ""Key"", ""NotValue""
+Attribute Foo.VB_Ext_Key = ""OtherKey"", ""OtherValue""
+    Const const1 As Integer = 9
+End Sub";
+
+            const string expectedCode =
+                @"'@MemberAttribute VB_Ext_Key, ""Key"", ""Value""
+Public Sub Foo()
+Attribute Foo.VB_Ext_Key = ""Key"", ""NotValue""
+    Const const1 As Integer = 9
+End Sub";
+
+            var actualCode = ApplyQuickFixToFirstInspectionResult(inputCode, state => new MissingMemberAnnotationInspection(state), CodeKind.AttributesCode);
+            Assert.AreEqual(expectedCode, actualCode);
+        }
+
+        protected override IQuickFix QuickFix(RubberduckParserState state)
+        {
+            return new RemoveAttributeQuickFix(new AttributesUpdater(state));
+        }
+    }
+}