small async fixes (#1690)

Author: Andrin Meier

RetailCoder.VBE/App.cs

@@ -150,7 +150,7 @@ public void Startup()
             _appMenus.Initialize();
             _hooks.HookHotkeys(); // need to hook hotkeys before we localize menus, to correctly display ShortcutTexts
             _appMenus.Localize();
-            Task.Delay(1000).ContinueWith(t => UiDispatcher.Invoke(() => _parser.State.OnParseRequested(this))).ConfigureAwait(false);
+            Task.Delay(1000).ContinueWith(t => UiDispatcher.Invoke(() => _parser.State.OnParseRequested(this)));
             UpdateLoggingLevel();
         }
 

RetailCoder.VBE/Inspections/Inspector.cs

@@ -55,11 +55,8 @@ public async Task<IEnumerable<ICodeInspectionResult>> FindIssuesAsync(Rubberduck
                     return new ICodeInspectionResult[] { };
                 }
 
-                await Task.Yield();
-
                 state.OnStatusMessageUpdate(RubberduckUI.CodeInspections_Inspecting);
                 UpdateInspectionSeverity();
-                //OnReset();
 
                 var allIssues = new ConcurrentBag<ICodeInspectionResult>();
 
@@ -72,31 +69,23 @@ public async Task<IEnumerable<ICodeInspectionResult>> FindIssuesAsync(Rubberduck
 
                 var inspections = _inspections.Where(inspection => inspection.Severity != CodeInspectionSeverity.DoNotShow)
                     .Select(inspection =>
-                        new Task(() =>
+                        Task.Run(() =>
                         {
                             token.ThrowIfCancellationRequested();
                             var inspectionResults = inspection.GetInspectionResults();
                             var results = inspectionResults as IEnumerable<InspectionResultBase> ?? inspectionResults;
 
                             if (results.Any())
                             {
-                                //OnIssuesFound(results);
-
                                 foreach (var inspectionResult in results)
                                 {
                                     allIssues.Add(inspectionResult);
                                 }
                             }
-                        })).ToArray();
-
-                foreach (var inspection in inspections)
-                {
-                    inspection.Start();
-                }
+                        })).ToList();
 
-                Task.WaitAll(inspections);
+                await Task.WhenAll(inspections);
                 state.OnStatusMessageUpdate(RubberduckUI.ResourceManager.GetString("ParserState_" + state.Status)); // should be "Ready"
-
                 return allIssues;
             }
 

RetailCoder.VBE/Refactorings/ExtractMethod/ExtractMethodSelectionValidation.cs

@@ -15,7 +15,7 @@ public class ExtractMethodSelectionValidation : IExtractMethodSelectionValidatio
         private IEnumerable<Declaration> _declarations;
 
 
-        
+
         public ExtractMethodSelectionValidation(IEnumerable<Declaration> declarations)
         {
             _declarations = declarations;
@@ -56,10 +56,15 @@ public bool withinSingleProcedure(QualifiedSelection qualifiedSelection)
             {
                 procStartContext = procStart.Context as VBAParser.SubStmtContext;
             }
+            // TOOD: Doesn't support properties.
+            if (procStartContext == null)
+            {
+                return false;
+            }
             var procEndOfSignature = procStartContext.endOfStatement() as VBAParser.EndOfStatementContext;
             var procSignatureLastLine = procEndOfSignature.Start.Line;
 
-            return (procEnd as Declaration).QualifiedSelection.Equals((procStart as Declaration).QualifiedSelection) 
+            return (procEnd as Declaration).QualifiedSelection.Equals((procStart as Declaration).QualifiedSelection)
                 && (procSignatureLastLine < startLine);
 
         }