Merge pull request #4509 from Vogel612/appveyor-shallow-clone

Fix Release Upload

Author: retailcoder

appveyor.yml

@@ -9,7 +9,7 @@ init:
   git config --global core.autocrlf true
 
 # history limited to 15 commits, since we ran into trouble with a limit of 3
-# the limit can be rather 
+# the limit can be rather generous
 clone_depth: 15
 # explicitly do not shallow-clone. 
 # Line-Endings are wrong on github, because of CRLF fixing
@@ -48,9 +48,6 @@ dotnet_csproj:
   file: 'RubberduckBaseProject.csproj' # ;*\Rubberduck.Core.csproj'
   version: '{version}'
   assembly_version: '{version}'
-  # patching fails if we try to patch properties we didn't define
-  #file_version: '{version}'
-  #informational_version: '{version}'
 
 
 before_build:
@@ -81,53 +78,61 @@ for:
     - next
   environment:
     installer_name: Rubberduck.Setup.%APPVEYOR_BUILD_VERSION%-pre.exe
+    release_name: Rubberduck v%APPVEYOR_BUILD_VERSION%-pre
 - 
   branches:
     only:
     - master
   environment:
     installer_name: Rubberduck.Setup.%APPVEYOR_BUILD_VERSION%.exe
+    release_name: Rubberduck v%APPVEYOR_BUILD_VERSION%
 - 
   branches:
     except:
       - master
       - next
   environment:
-    # fall back to calling the installer after the branch we're on
-    installer_name: Rubberduck.Setup.%APPVEYOR_BUILD_VERSION%-%APPVEYOR_REPO_BRANCH%.exe
+    # fall back to naming the installer something that shows we're in an unexpected state
+    installer_name: Rubberduck.Setup.%APPVEYOR_BUILD_VERSION%-unexpected.exe
+    release_name: Rubberduck v%APPVEYOR_BUILD_VERSION%-%APPVEYOR_REPO_BRANCH%
 
-# Create Installers for 
+# Create Installers to store at appveyor and upload to github
 after_test:
   - cmd: iscc /O "Rubberduck.Deployment\InnoSetup\Rubberduck.Installer.Build.iss"
   - cmd: move %INSTALLER_DIR%\Rubberduck.Setup.exe %INSTALLER_DIR%\%INSTALLER_NAME%
-    
+
 # grab the installers we produce and upload them to github :)
 artifacts:
   - path: Rubberduck.Deployment\InnoSetup\Installers\Rubberduck.Setup.*.exe
     name: Rubberduck
 deploy:
   - provider: GitHub
     tag: Rubberduck v$(appveyor_build_version)
-    release: Rubberduck v$(appveyor_build_version)
-    description: AppVeyor build on [master] - https://ci.appveyor.com/project/rubberduck-vba/rubberduck/build/$(appveyor_build_version)
-    auth_token:
-      secure: NVAZgFRSk566SP5QDge5gYRWCaLi4NJJPTNk3QengH15wL9iVldfrFOllbzKXExq
-    artifact: Rubberduck.Deployment\InnoSetup\Installers\Rubberduck.Setup.$(appveyor_build_version).exe
+    release: $(release_name)
     draft: true
     prerelease: false
-    on:
+    description: "Built with :heart: by AppVeyor CI on [$(appveyor_repo_branch)] - https://ci.appveyor.com/project/rubberduck-vba/rubberduck/build/$(appveyor_build_version)"
+    auth_token:
+      secure: NVAZgFRSk566SP5QDge5gYRWCaLi4NJJPTNk3QengH15wL9iVldfrFOllbzKXExq
+    artifact: Rubberduck
+    on: 
       branch: master
   - provider: GitHub
     tag: Rubberduck v$(appveyor_build_version)
-    release: Rubberduck v$(appveyor_build_version)-pre
-    description: AppVeyor build on [next] - https://ci.appveyor.com/project/rubberduck-vba/rubberduck/build/$(appveyor_build_version)
+    release: $(release_name)
+    draft: true
+    prerelease: false
+    description: >-
+      AppVeyor build on [$(appveyor_repo_branch)] - https://ci.appveyor.com/project/rubberduck-vba/rubberduck/build/$(appveyor_build_version)
+
+      Merges \#$(appveyor_pull_request_number) - $(appveyor_pull_request_title)
     auth_token:
       secure: NVAZgFRSk566SP5QDge5gYRWCaLi4NJJPTNk3QengH15wL9iVldfrFOllbzKXExq
-    artifact: Rubberduck.Deployment\InnoSetup\Installers\Rubberduck.Setup.$(appveyor_build_version)-pre.exe
-    draft: false
-    prerelease: true
-    on:
+    artifact: Rubberduck
+    on: 
       branch: next
+
+# This is Duga posting stuff to the war room
 notifications:
   - provider: Webhook
     url: http://stats.zomis.net/GithubHookSEChatService/hooks/github/payload?roomId=14929