resolver fixes (#1695)

* added AsTypeName to the context-sensitive commandbar

* clear built-in references at every resolution; fixed issue with null parse trees, given built-in modules get a module state instance.

* fixed OverflowException in GetTypeName; built-in parameters now have return type info :)

* returning built-in members now have return type info as well

* removed hard-coded defaults in ClassModuleDeclaration

* added IsBadReadPtr check in COM declarations collector

* Implemented CanExecute in Project Explorer rename command

* cleaned up FormDesignerRefactorRename command

* fixed IOExceptions in QualifiedModuleName

* use filename, not buildfilename

* GetDisplayName being the part in parens, should be null when not applicable; made it private

* renamed namespace Rubberduck.UI.CodeInspections to Rubberduck.UI.Inspections for consistency with Rubberduck.Inspections namespace

* changed background color of bottom panel in CodeExplorer and InspectionResults toolwindows

* fixed broken keybinding "Esc" -> "Escape"

* added copy/export button to SearchView (todo: implement ExecuteCopyResultsCommand)

* Revert "added copy/export button to SearchView (todo: implement ExecuteCopyResultsCommand)"

This reverts commit e9946b7.

* assert ProjectId isn't null

* fixes #1664

* some French translations

* fixed possible NRE's in QualifiedModuleName

* fixes #1671

* changed wording of fr resources for settings dialog (left pane items)

* fixes #1672

* more French translations

* fix RuntimeBinderException with optional object parameters (resolver bug)

* fixed AsTypeName of optional parameters with a default value

* fixed "resolving" state in the status bar

Author: retailcoder

Rubberduck.Parsing/Binding/BindingService.cs

@@ -1,4 +1,6 @@
-using Antlr4.Runtime;
+using System.Diagnostics;
+using Antlr4.Runtime;
+using Rubberduck.Parsing.Grammar;
 using Rubberduck.Parsing.Symbols;
 
 namespace Rubberduck.Parsing.Binding
@@ -39,7 +41,13 @@ public IBoundExpression ResolveDefault(Declaration module, Declaration parent, P
 
         public IBoundExpression ResolveType(Declaration module, Declaration parent, ParserRuleContext expression)
         {
-            return _typedBindingContext.Resolve(module, parent, expression, null, StatementResolutionContext.Undefined);
+            var context = expression;
+            var opContext = expression as VBAParser.RelationalOpContext;
+            if (opContext != null && opContext.Parent is VBAParser.ComplexTypeContext)
+            {
+                context = opContext.GetChild<VBAParser.LExprContext>(0);
+            }
+            return _typedBindingContext.Resolve(module, parent, context, null, StatementResolutionContext.Undefined);
         }
 
         public IBoundExpression ResolveProcedurePointer(Declaration module, Declaration parent, ParserRuleContext expression)

Rubberduck.Parsing/Binding/StatementResolutionContext.cs

@@ -4,6 +4,7 @@ public enum StatementResolutionContext
     {
         Undefined,
         SetStatement,
-        LetStatement
+        LetStatement,
+        DefaultParamValue,
     }
 }

Rubberduck.Parsing/Symbols/DeclarationSymbolsListener.cs

@@ -185,6 +185,16 @@ private Declaration CreateDeclaration(
             {
                 var argContext = (VBAParser.ArgContext)context;
                 var isOptional = argContext.OPTIONAL() != null;
+                if (isOptional)
+                {
+                    // if parameter is optional, asTypeName may contain the default value
+                    var complexType = asTypeContext.type().complexType();
+                    if (complexType != null && complexType.expression() is VBAParser.RelationalOpContext)
+                    {
+                        asTypeName = complexType.expression().GetChild(0).GetText();
+                    }
+                }
+
                 var isByRef = argContext.BYREF() != null;
                 var isParamArray = argContext.PARAMARRAY() != null;
                 result = new ParameterDeclaration(

Rubberduck.Parsing/VBA/RubberduckParser.cs

@@ -56,13 +56,8 @@ public RubberduckParser(
             _comReflector = new ReferencedDeclarationsCollector(_state);
 
             state.ParseRequest += ReparseRequested;
-            state.StateChanged += StateOnStateChanged;
         }
 
-        private void StateOnStateChanged(object sender, EventArgs e)
-        {
-            Logger.Debug("RubberduckParser handles OnStateChanged ({0})", _state.Status);
-        }
 
         private void ReparseRequested(object sender, ParseRequestEventArgs e)
         {
@@ -466,6 +461,7 @@ private void ParseAsyncInternal(VBComponent component, CancellationToken token,
 
         private void Resolve(CancellationToken token)
         {
+            State.SetStatusAndFireStateChanged(ParserState.Resolving);
             var sharedTokenSource = CancellationTokenSource.CreateLinkedTokenSource(_resolverTokenSource.Token, token);
             // tests expect this to be synchronous :/
             //Task.Run(() => ResolveInternal(sharedTokenSource.Token));
@@ -599,8 +595,6 @@ private void ResolveReferences(DeclarationFinder finder, VBComponent component,
         public void Dispose()
         {
             State.ParseRequest -= ReparseRequested;
-            State.StateChanged -= StateOnStateChanged;
-
             if (_resolverTokenSource != null)
             {
                 _resolverTokenSource.Dispose();