Skip to content

Commit e1785d2

Browse files
shadowofsiliconshadowofsilicon
committed
Rename UI and code elements to make their names more accurate: "GroupByType" and "SortByCodeOrder"
1 parent 80df1b7 commit e1785d2

File tree

8 files changed

+63
-79
lines changed

8 files changed

+63
-79
lines changed

‎RetailCoder.VBE/Navigation/CodeExplorer/CodeExplorerItemViewModel.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -228,9 +228,9 @@ public void AddChild(CodeExplorerItemViewModel item)
228228
_items.Add(item);
229229
}
230230

231-
public void ReorderItems(bool sortByName, bool sortByType)
231+
public void ReorderItems(bool sortByName, bool groupByType)
232232
{
233-
if (sortByType)
233+
if (groupByType)
234234
{
235235
Items = sortByName
236236
? Items.OrderBy(o => o, new CompareByType()).ThenBy(t => t, new CompareByName()).ToList()

‎RetailCoder.VBE/Navigation/CodeExplorer/CodeExplorerViewModel.cs

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -97,14 +97,14 @@ public CodeExplorerViewModel(FolderHelper folderHelper, RubberduckParserState st
9797

9898
SetNameSortCommand = new DelegateCommand(LogManager.GetCurrentClassLogger(), param =>
9999
{
100-
SortByName = (bool)param;
101-
SortBySelection = !(bool)param;
100+
SortByName = (bool)param;
101+
SortByCodeOrder = !(bool)param;
102102
});
103103

104-
SetSelectionSortCommand = new DelegateCommand(LogManager.GetCurrentClassLogger(), param =>
104+
SetCodeOrderSortCommand = new DelegateCommand(LogManager.GetCurrentClassLogger(), param =>
105105
{
106-
SortBySelection = (bool)param;
107-
SortByName = !(bool)param;
106+
SortByCodeOrder = (bool)param;
107+
SortByName = !(bool)param;
108108
});
109109
}
110110

@@ -141,25 +141,25 @@ public bool SortByName
141141
}
142142

143143
_windowSettings.CodeExplorer_SortByName = value;
144-
_windowSettings.CodeExplorer_SortByLocation = !value;
144+
_windowSettings.CodeExplorer_SortByCodeOrder = !value;
145145
_windowSettingsProvider.Save(_windowSettings);
146146
OnPropertyChanged();
147147

148148
ReorderChildNodes(Projects);
149149
}
150150
}
151151

152-
public bool SortBySelection
152+
public bool SortByCodeOrder
153153
{
154-
get { return _windowSettings.CodeExplorer_SortByLocation; }
154+
get { return _windowSettings.CodeExplorer_SortByCodeOrder; }
155155
set
156156
{
157-
if (_windowSettings.CodeExplorer_SortByLocation == value)
157+
if (_windowSettings.CodeExplorer_SortByCodeOrder == value)
158158
{
159159
return;
160160
}
161161

162-
_windowSettings.CodeExplorer_SortByLocation = value;
162+
_windowSettings.CodeExplorer_SortByCodeOrder = value;
163163
_windowSettings.CodeExplorer_SortByName = !value;
164164
_windowSettingsProvider.Save(_windowSettings);
165165
OnPropertyChanged();
@@ -172,9 +172,9 @@ public bool SortBySelection
172172

173173
public CommandBase SetNameSortCommand { get; }
174174

175-
public CommandBase SetSelectionSortCommand { get; }
175+
public CommandBase SetCodeOrderSortCommand { get; }
176176

177-
public bool SortByType
177+
public bool GroupByType
178178
{
179179
get { return _windowSettings.CodeExplorer_GroupByType; }
180180
set
@@ -414,7 +414,7 @@ private void ReorderChildNodes(IEnumerable<CodeExplorerItemViewModel> nodes)
414414
{
415415
foreach (var node in nodes)
416416
{
417-
node.ReorderItems(SortByName, SortByType);
417+
node.ReorderItems(SortByName, GroupByType);
418418
ReorderChildNodes(node.Items);
419419
}
420420
}

‎RetailCoder.VBE/Settings/WindowSettings.cs

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ public interface IWindowSettings
1818
bool TodoExplorerVisibleOnStartup { get; set; }
1919

2020
bool CodeExplorer_SortByName { get; set; }
21-
bool CodeExplorer_SortByLocation { get; set; }
21+
bool CodeExplorer_SortByCodeOrder { get; set; }
2222
bool CodeExplorer_GroupByType { get; set; }
2323

2424
bool IsWindowVisible(DockableToolwindowPresenter candidate);
@@ -34,7 +34,9 @@ public WindowSettings()
3434
//empty constructor needed for serialization
3535
}
3636

37-
public WindowSettings(bool codeExplorerVisibleOnStartup, bool codeInspectionsVisibleOnStartup, bool sourceControlVisibleOnStartup, bool testExplorerVisibleOnStartup, bool todoExplorerVisibleOnStartup, bool codeExplorer_SortByName, bool codeExplorer_SortByLocation, bool codeExplorer_GroupByType)
37+
public WindowSettings(bool codeExplorerVisibleOnStartup, bool codeInspectionsVisibleOnStartup,
38+
bool sourceControlVisibleOnStartup, bool testExplorerVisibleOnStartup, bool todoExplorerVisibleOnStartup,
39+
bool codeExplorer_SortByName, bool codeExplorer_SortByCodeOrder, bool codeExplorer_GroupByType)
3840
{
3941
CodeExplorerVisibleOnStartup = codeExplorerVisibleOnStartup;
4042
CodeInspectionsVisibleOnStartup = codeInspectionsVisibleOnStartup;
@@ -43,7 +45,7 @@ public WindowSettings(bool codeExplorerVisibleOnStartup, bool codeInspectionsVis
4345
TodoExplorerVisibleOnStartup = todoExplorerVisibleOnStartup;
4446

4547
CodeExplorer_SortByName = codeExplorer_SortByName;
46-
CodeExplorer_SortByLocation = codeExplorer_SortByLocation;
48+
CodeExplorer_SortByCodeOrder = codeExplorer_SortByCodeOrder;
4749
CodeExplorer_GroupByType = codeExplorer_GroupByType;
4850
}
4951

@@ -54,7 +56,7 @@ public WindowSettings(bool codeExplorerVisibleOnStartup, bool codeInspectionsVis
5456
public bool TodoExplorerVisibleOnStartup { get; set; }
5557

5658
public bool CodeExplorer_SortByName { get; set; }
57-
public bool CodeExplorer_SortByLocation { get; set; }
59+
public bool CodeExplorer_SortByCodeOrder { get; set; }
5860
public bool CodeExplorer_GroupByType { get; set; }
5961

6062
public bool IsWindowVisible(DockableToolwindowPresenter candidate)
@@ -94,7 +96,7 @@ public bool Equals(WindowSettings other)
9496
TestExplorerVisibleOnStartup == other.TestExplorerVisibleOnStartup &&
9597
TodoExplorerVisibleOnStartup == other.TodoExplorerVisibleOnStartup &&
9698
CodeExplorer_SortByName == other.CodeExplorer_SortByName &&
97-
CodeExplorer_SortByLocation == other.CodeExplorer_SortByLocation &&
99+
CodeExplorer_SortByCodeOrder == other.CodeExplorer_SortByCodeOrder &&
98100
CodeExplorer_GroupByType == other.CodeExplorer_GroupByType;
99101
}
100102
}

‎RetailCoder.VBE/UI/CodeExplorer/CodeExplorerControl.xaml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -793,24 +793,24 @@
793793

794794
<MenuItem Name="SortByName"
795795
Style="{DynamicResource MenuItemStyle}" VerticalAlignment="Center"
796-
Header="{Resx ResxName=Rubberduck.UI.RubberduckUI, Key=SortStyle_ByName}"
796+
Header="{Resx ResxName=Rubberduck.UI.RubberduckUI, Key=CodeExplorer_SortStyle_ByName}"
797797
IsChecked="{Binding SortByName, UpdateSourceTrigger=PropertyChanged}"
798798
Command="{Binding SetNameSortCommand}"
799799
CommandParameter="{Binding ElementName=SortByName, Path=IsChecked}"
800800
IsCheckable="True" />
801-
<MenuItem Name="SortBySelection"
801+
<MenuItem Name="SortByCodeOrder"
802802
Style="{DynamicResource MenuItemStyle}" VerticalAlignment="Center"
803-
Header="{Resx ResxName=Rubberduck.UI.RubberduckUI, Key=SortStyle_ByCodeOrder}"
804-
IsChecked="{Binding SortBySelection, UpdateSourceTrigger=PropertyChanged}"
805-
Command="{Binding SetSelectionSortCommand}"
806-
CommandParameter="{Binding ElementName=SortBySelection, Path=IsChecked}"
803+
Header="{Resx ResxName=Rubberduck.UI.RubberduckUI, Key=CodeExplorer_SortStyle_ByCodeOrder}"
804+
IsChecked="{Binding SortByCodeOrder, UpdateSourceTrigger=PropertyChanged}"
805+
Command="{Binding SetCodeOrderSortCommand}"
806+
CommandParameter="{Binding ElementName=SortByCodeOrder, Path=IsChecked}"
807807
IsCheckable="True" />
808808

809809
<Separator />
810810

811811
<MenuItem Style="{DynamicResource MenuItemStyle}" VerticalAlignment="Center"
812-
Header="{Resx ResxName=Rubberduck.UI.RubberduckUI, Key=SortStyle_ByType}"
813-
IsChecked="{Binding SortByType, Mode=TwoWay, UpdateSourceTrigger=PropertyChanged}"
812+
Header="{Resx ResxName=Rubberduck.UI.RubberduckUI, Key=CodeExplorer_SortStyle_ByType}"
813+
IsChecked="{Binding GroupByType, Mode=TwoWay, UpdateSourceTrigger=PropertyChanged}"
814814
IsCheckable="True" />
815815
</MenuItem>
816816
</Menu>

‎RetailCoder.VBE/UI/RubberduckUI.Designer.cs

Lines changed: 27 additions & 27 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎RetailCoder.VBE/UI/RubberduckUI.de.resx

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1492,12 +1492,6 @@ Allen Sternguckern, Likern &amp; Followern, für das warme Kribbeln
14921492
<data name="SourceControl_CommitStatus" xml:space="preserve">
14931493
<value>Commit Status.</value>
14941494
</data>
1495-
<data name="SortStyle_ByType" xml:space="preserve">
1496-
<value>Nach Typ</value>
1497-
</data>
1498-
<data name="SortStyle_ByName" xml:space="preserve">
1499-
<value>Nach Name</value>
1500-
</data>
15011495
<data name="CodeExplorer_Sort" xml:space="preserve">
15021496
<value>Sortieren</value>
15031497
</data>
@@ -1636,9 +1630,6 @@ Allen Sternguckern, Likern &amp; Followern, für das warme Kribbeln
16361630
<data name="SourceControl_OpenCommandPromptButtonToolTip" xml:space="preserve">
16371631
<value>Eingabeaufforderung öffnen</value>
16381632
</data>
1639-
<data name="SortStyle_ByCodeOrder" xml:space="preserve">
1640-
<value>Nach Deklarationsreihenfolge</value>
1641-
</data>
16421633
<data name="SourceControl_FileStatus_Removed" xml:space="preserve">
16431634
<value>Gelöscht</value>
16441635
</data>

‎RetailCoder.VBE/UI/RubberduckUI.fr.resx

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1456,9 +1456,6 @@ Tous ceux qui nous ont donné une étoile ou un "like"
14561456
<data name="GeneralSettings_PeriodDelimiter" xml:space="preserve">
14571457
<value>Point (.)</value>
14581458
</data>
1459-
<data name="SortStyle_ByType" xml:space="preserve">
1460-
<value>Par type</value>
1461-
</data>
14621459
<data name="CodeExplorer_AddClassModuleText" xml:space="preserve">
14631460
<value>Module de classe (.cls)</value>
14641461
</data>
@@ -1501,9 +1498,6 @@ Tous ceux qui nous ont donné une étoile ou un "like"
15011498
<data name="CodeExplorer_Print" xml:space="preserve">
15021499
<value>Imprimer...</value>
15031500
</data>
1504-
<data name="SortStyle_ByName" xml:space="preserve">
1505-
<value>Par nom</value>
1506-
</data>
15071501
<data name="SourceControl_UndoTitle" xml:space="preserve">
15081502
<value>Contrôle des sources - annuler</value>
15091503
</data>
@@ -1752,9 +1746,6 @@ End Sub</value>
17521746
<data name="TestExplorerMenu_AddExpectedErrorTestMethod" xml:space="preserve">
17531747
<value>Méthode de test (&amp;erreur attendue)</value>
17541748
</data>
1755-
<data name="SortStyle_ByCodeOrder" xml:space="preserve">
1756-
<value>Tel que dans le module</value>
1757-
</data>
17581749
<data name="RubberduckReloadFailure_Message" xml:space="preserve">
17591750
<value>Les fenêtres ancrables n'ont probablement pas été correctement détruites, et/ou n'ont pas pu être recréées. l'environnement peut ne pas être dans un état stable. Rubberduck démerrera normalement à la prochaine initialisation du VBE.</value>
17601751
</data>
@@ -1926,4 +1917,4 @@ End Sub</value>
19261917
<data name="SettingsCaption_WindowSettings" xml:space="preserve">
19271918
<value>Paramètres des fenêtres</value>
19281919
</data>
1929-
</root>
1920+
</root>

‎RetailCoder.VBE/UI/RubberduckUI.resx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1529,13 +1529,13 @@ All our stargazers, likers &amp; followers, for the warm fuzzies
15291529
<data name="CodeExplorer_Sort" xml:space="preserve">
15301530
<value>Sort</value>
15311531
</data>
1532-
<data name="SortStyle_ByName" xml:space="preserve">
1533-
<value>By name</value>
1532+
<data name="CodeExplorer_SortStyle_ByName" xml:space="preserve">
1533+
<value>by Name</value>
15341534
</data>
1535-
<data name="SortStyle_ByType" xml:space="preserve">
1536-
<value>By type</value>
1535+
<data name="CodeExplorer_SortStyle_ByType" xml:space="preserve">
1536+
<value>Group by Type</value>
15371537
</data>
1538-
<data name="SortStyle_ByCodeOrder" xml:space="preserve">
1538+
<data name="CodeExplorer_SortStyle_ByCodeOrder" xml:space="preserve">
15391539
<value>As in module</value>
15401540
</data>
15411541
<data name="TestOutcome_Ignored" xml:space="preserve">

0 commit comments

Comments
 (0)