Merge pull request #5597 from MDoerner/FixDefaultMemberInspectionForOptionalPropertyParentheses

Fix missing default member result for optional parentheses on properties

Author: bclothier

Rubberduck.Parsing/Binding/Bindings/IndexDefaultBinding.cs

@@ -356,8 +356,11 @@ declared type.
         private static bool ArgumentListIsCompatible(ICollection<ParameterDeclaration> parameters, ArgumentList argumentList)
         {
             return (parameters.Count >= (argumentList?.Arguments.Count ?? 0) 
-                        || parameters.Any(parameter => parameter.IsParamArray))
-                    && parameters.Count(parameter => !parameter.IsOptional && !parameter.IsParamArray) <= (argumentList?.Arguments.Count ?? 0);
+                            || parameters.Any(parameter => parameter.IsParamArray))
+                        && parameters.Count(parameter => !parameter.IsOptional && !parameter.IsParamArray) <= (argumentList?.Arguments.Count ?? 0)
+                   || parameters.Count == 0 
+                        && argumentList?.Arguments.Count == 1
+                        && argumentList.Arguments.Single().ArgumentType == ArgumentListArgumentType.Missing;
         }
 
         private IBoundExpression ResolveRecursiveDefaultMember(Declaration defaultMember, ExpressionClassification defaultMemberClassification, ArgumentList argumentList, ParserRuleContext expression, Declaration parent, int defaultMemberResolutionRecursionDepth, RecursiveDefaultMemberAccessExpression containedExpression)

RubberduckTests/Inspections/DefaultMemberRequiredInspectionTests.cs

@@ -330,6 +330,31 @@ End Function
             Assert.AreEqual(expectedSelection, actualSelection);
         }
 
+        [Category("Inspections")]
+        [Test]
+        public void OptionalParenthesesAfterVariantReturningProperty_NoResult()
+        {
+            var classCode = @"
+Public Property Get Foo() As Variant
+End Property
+";
+
+            var moduleCode = @"
+Private Function Bar() As String 
+    Dim cls As new Class1
+    Bar = cls.Foo()
+End Function
+";
+
+            var vbe = MockVbeBuilder.BuildFromModules(
+                ("Class1", classCode, ComponentType.ClassModule),
+                ("Module1", moduleCode, ComponentType.StandardModule));
+
+            var inspectionResults = InspectionResults(vbe.Object);
+            
+            Assert.AreEqual(0, inspectionResults.Count());
+        }
+
         [Category("Inspections")]
         [Test]
         public void FailedIndexExpressionOnFunctionWithParameters_NoResult()