Skip to content

Commit dd77700

Browse files
committed
Made inspections trigger a refresh, including a reparse, on changes of the inspection settings.
1 parent 8592284 commit dd77700

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

RetailCoder.VBE/UI/Inspections/InspectionResultsViewModel.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ private void _configService_SettingsChanged(object sender, ConfigurationChangedE
102102
{
103103
if (e.InspectionSettingsChanged)
104104
{
105-
RefreshInspections(CancellationToken.None);
105+
RefreshCommand.Execute(null);
106106
}
107107
_runInspectionsOnReparse = e.RunInspectionsOnReparse;
108108
}

Rubberduck.Inspections/Inspector.cs

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ public async Task<IEnumerable<IInspectionResult>> FindIssuesAsync(RubberduckPars
102102

103103
try
104104
{
105-
await Task.Run(() => RunInspectionsInParallel(inspectionsToRun, allIssues, token));
105+
await Task.Run(() => RunInspectionsInParallel(inspectionsToRun, allIssues, token), token);
106106
}
107107
catch (AggregateException exception)
108108
{
@@ -111,10 +111,8 @@ public async Task<IEnumerable<IInspectionResult>> FindIssuesAsync(RubberduckPars
111111
//This eliminates the stack trace, but for the cancellation, this is irrelevant.
112112
throw exception.InnerException ?? exception;
113113
}
114-
else
115-
{
116-
LogManager.GetCurrentClassLogger().Error(exception);
117-
}
114+
115+
LogManager.GetCurrentClassLogger().Error(exception);
118116
}
119117
catch (OperationCanceledException)
120118
{

0 commit comments

Comments
 (0)