Merge pull request #4914 from Vogel612/fix/project-order

Invert project order for RD.CodeAnalysis and make RD.SettingsProvider more useful

Author: retailcoder

Rubberduck.Core/CodeAnalysis/CodeMetrics/AggregationLevel.cs renamed to Rubberduck.CodeAnalysis/CodeMetrics/AggregationLevel.cs

@@ -2,14 +2,14 @@
 using System.Globalization;
 using System.Linq;
 using System.Text.RegularExpressions;
+using Rubberduck.CodeAnalysis.Settings;
 using Rubberduck.Inspections.Abstract;
 using Rubberduck.Inspections.Inspections.Extensions;
 using Rubberduck.Inspections.Results;
 using Rubberduck.Parsing.Inspections.Abstract;
 using Rubberduck.Parsing.Symbols;
 using Rubberduck.Parsing.VBA;
 using Rubberduck.Resources;
-using Rubberduck.Settings;
 using Rubberduck.SettingsProvider;
 
 namespace Rubberduck.Inspections.Concrete
@@ -104,9 +104,9 @@ public sealed class HungarianNotationInspection : InspectionBase
 
         #endregion
 
-        private readonly IPersistanceService<CodeInspectionSettings> _settings;
+        private readonly IPersistenceService<CodeInspectionSettings> _settings;
 
-        public HungarianNotationInspection(RubberduckParserState state, IPersistanceService<CodeInspectionSettings> settings)
+        public HungarianNotationInspection(RubberduckParserState state, IPersistenceService<CodeInspectionSettings> settings)
             : base(state)
         {
             _settings = settings;

Rubberduck.Core/CodeAnalysis/CodeMetrics/CodeMetric.cs renamed to Rubberduck.CodeAnalysis/CodeMetrics/CodeMetric.cs

@@ -1,6 +1,7 @@
 using System.Collections.Generic;
 using System.Globalization;
 using System.Linq;
+using Rubberduck.CodeAnalysis.Settings;
 using Rubberduck.Common;
 using Rubberduck.Inspections.Abstract;
 using Rubberduck.Inspections.Results;
@@ -9,17 +10,16 @@
 using Rubberduck.Parsing.Symbols;
 using Rubberduck.Parsing.VBA;
 using Rubberduck.Resources;
-using Rubberduck.Settings;
 using Rubberduck.SettingsProvider;
 using static Rubberduck.Parsing.Grammar.VBAParser;
 
 namespace Rubberduck.Inspections.Concrete
 {
     public sealed class UseMeaningfulNameInspection : InspectionBase
     {
-        private readonly IPersistanceService<CodeInspectionSettings> _settings;
+        private readonly IPersistenceService<CodeInspectionSettings> _settings;
 
-        public UseMeaningfulNameInspection(RubberduckParserState state, IPersistanceService<CodeInspectionSettings> settings)
+        public UseMeaningfulNameInspection(RubberduckParserState state, IPersistenceService<CodeInspectionSettings> settings)
             : base(state)
         {
             _settings = settings;

Rubberduck.Core/CodeAnalysis/CodeMetrics/ICodeMetricResult.cs renamed to Rubberduck.CodeAnalysis/CodeMetrics/ICodeMetricResult.cs

@@ -2,14 +2,15 @@
 using System.Linq;
 using Rubberduck.Parsing.Inspections.Abstract;
 using Rubberduck.Settings;
+using Rubberduck.CodeAnalysis.Settings;
 
 namespace Rubberduck.CodeAnalysis.Inspections
 {
     public class InspectionProvider : IInspectionProvider
     {
         public InspectionProvider(IEnumerable<IInspection> inspections)
         {
-            var defaultSettings = new DefaultSettings<CodeInspectionSettings>().Default;
+            var defaultSettings = new DefaultSettings<CodeInspectionSettings, Properties.CodeInspectionDefaults>().Default;
             var defaultNames = defaultSettings.CodeInspections.Select(x => x.Name);
             var defaultInspections = inspections.Where(inspection => defaultNames.Contains(inspection.Name));