added red/repro tests for #4531

Author: retailcoder

RubberduckTests/Mocks/MockVbeBuilder.cs

@@ -127,22 +127,22 @@ public Mock<IVBE> Build()
         /// <param name="selection">Specifies user selection in the editor.</param>
         /// <param name="referenceStdLibs">Specifies whether standard libraries are referenced.</param>
         /// <returns></returns>
-        public static Mock<IVBE> BuildFromSingleStandardModule(string content, out IVBComponent component, Selection selection = default(Selection), bool referenceStdLibs = false)
+        public static Mock<IVBE> BuildFromSingleStandardModule(string content, out IVBComponent component, Selection selection = default, bool referenceStdLibs = false)
         {
             return BuildFromSingleModule(content, TestModuleName, ComponentType.StandardModule, out component, selection, referenceStdLibs);
         }
 
-        public static Mock<IVBE> BuildFromSingleStandardModule(string content, string name, out IVBComponent component, Selection selection = default(Selection), bool referenceStdLibs = false)
+        public static Mock<IVBE> BuildFromSingleStandardModule(string content, string name, out IVBComponent component, Selection selection = default, bool referenceStdLibs = false)
         {
             return BuildFromSingleModule(content, name, ComponentType.StandardModule, out component, selection, referenceStdLibs);
         }
 
-        public static Mock<IVBE> BuildFromSingleModule(string content, ComponentType type, out IVBComponent component, Selection selection = default(Selection), bool referenceStdLibs = false)
+        public static Mock<IVBE> BuildFromSingleModule(string content, ComponentType type, out IVBComponent component, Selection selection = default, bool referenceStdLibs = false)
         {
             return BuildFromSingleModule(content, TestModuleName, type, out component, selection, referenceStdLibs);
         }
 
-        public static Mock<IVBE> BuildFromSingleModule(string content, string name, ComponentType type, out IVBComponent component, Selection selection = default(Selection), bool referenceStdLibs = false)
+        public static Mock<IVBE> BuildFromSingleModule(string content, string name, ComponentType type, out IVBComponent component, Selection selection = default, bool referenceStdLibs = false)
         {
             var vbeBuilder = new MockVbeBuilder();
 

RubberduckTests/QuickFixes/UseSetKeywordForObjectAssignmentQuickFixTests.cs

@@ -3,12 +3,59 @@
 using Rubberduck.Inspections.QuickFixes;
 using Rubberduck.Parsing.Inspections.Abstract;
 using Rubberduck.Parsing.VBA;
+using Rubberduck.VBEditor.SafeComWrappers;
+using Rubberduck.VBEditor.SafeComWrappers.Abstract;
+using RubberduckTests.Mocks;
 
 namespace RubberduckTests.QuickFixes
 {
     [TestFixture]
     public class UseSetKeywordForObjectAssignmentQuickFixTests : QuickFixTestBase
     {
+        [Test]
+        [Category("QuickFixes")]
+        public void ObjectVariableNotSet_ReplacesExplicitLetKeyword()
+        {
+            var inputCode = @"
+Private Sub TextBox1_Change()
+    Dim foo As Range
+    Set foo = Range(""A1"")
+    Let foo.Font = Range(""B1"").Font
+End Sub
+";
+            var expectedCode = @"
+Private Sub TextBox1_Change()
+    Dim foo As Range
+    Set foo = Range(""A1"")
+    Set foo.Font = Range(""B1"").Font
+End Sub
+";
+            var actualCode = ApplyQuickFixToAllInspectionResults(inputCode, state => new ObjectVariableNotSetInspection(state));
+            Assert.AreEqual(expectedCode, actualCode);
+        }
+
+        [Test]
+        [Category("QuickFixes")]
+        public void ObjectVariableNotSet_PlacesKeywordBeforeMemberCall()
+        {
+            var inputCode = @"
+Private Sub TextBox1_Change()
+    Dim foo As Range
+    Set foo = Range(""A1"")
+    foo.Font = Range(""B1"").Font
+End Sub
+";
+            var expectedCode = @"
+Private Sub TextBox1_Change()
+    Dim foo As Range
+    Set foo = Range(""A1"")
+    Set foo.Font = Range(""B1"").Font
+End Sub
+";
+            var actualCode = ApplyQuickFixToAllInspectionResults(inputCode, state => new ObjectVariableNotSetInspection(state));
+            Assert.AreEqual(expectedCode, actualCode);
+        }
+
         [Test]
         [Category("QuickFixes")]
         public void ObjectVariableNotSet_ForFunctionAssignment_ReturnsResult()
@@ -63,5 +110,19 @@ protected override IQuickFix QuickFix(RubberduckParserState state)
         {
             return new UseSetKeywordForObjectAssignmentQuickFix();
         }
+
+        protected override IVBE TestVbe(string code, out IVBComponent component)
+        {
+            var builder = new MockVbeBuilder();
+            var project = builder.ProjectBuilder("VBAProject", ProjectProtection.Unprotected)
+                .AddComponent("Module1", ComponentType.StandardModule, code)
+                .AddReference("Excel", MockVbeBuilder.LibraryPathMsExcel, 1, 8, true)
+                .Build();
+
+            var vbe = builder.AddProject(project).Build().Object;
+            component = project.Object.VBComponents[0];
+            return vbe;
+        }
+
     }
 }