Merge pull request #1352 from autoboosh/paramarrayfix

fix paramarray incorrectly flagged as missing ByRef param mechanism (…

Author: retailcoder

RetailCoder.VBE/Inspections/ImplicitByRefParameterInspection.cs

@@ -24,8 +24,11 @@ public override IEnumerable<InspectionResultBase> GetInspectionResults()
             var interfaceMembers = UserDeclarations.FindInterfaceImplementationMembers();
 
             var issues = (from item in UserDeclarations
-                where !item.IsInspectionDisabled(AnnotationName)
+                where
+                    !item.IsInspectionDisabled(AnnotationName)
                     && item.DeclarationType == DeclarationType.Parameter
+                    // ParamArray parameters do not allow an explicit "ByRef" parameter mechanism.               
+                    && !((ParameterDeclaration)item).IsParamArray
                     && !interfaceMembers.Select(m => m.Scope).Contains(item.ParentScope)
                 let arg = item.Context as VBAParser.ArgContext
                 where arg != null && arg.BYREF() == null && arg.BYVAL() == null

RetailCoder.VBE/Inspections/InspectionsUI.de.resx

@@ -423,7 +423,7 @@
     <value>Deklariere explizit als 'Variant'</value>
   </data>
   <data name="ImplicitByRefParameterQuickFix" xml:space="preserve">
-    <value>Über gebe den Parameter explizit als Referenz</value>
+    <value>Parameter explizit als Referenz angeben</value>
   </data>
   <data name="Inspections_DeclarationOf" xml:space="preserve">
     <value>Deklaration von</value>

RubberduckTests/Inspections/ImplicitByRefParameterInspectionTests.cs

@@ -200,7 +200,7 @@ public void ImplicitByRefParameter_QuickFixWorks_PassByRef()
         }
 
         [TestMethod]
-        public void ImplicitByRefParameter_QuickFixWorks_ParamArrayMustBePassedByRef()
+        public void ImplicitByRefParameter_QuickFixWorks_ParamArrayIsIgnored()
         {
             const string inputCode =
 @"Sub Foo(ParamArray arg1 As Integer)
@@ -220,7 +220,7 @@ public void ImplicitByRefParameter_QuickFixWorks_ParamArrayMustBePassedByRef()
             var inspection = new ImplicitByRefParameterInspection(parser.State);
             var inspectionResults = inspection.GetInspectionResults();
 
-            Assert.AreEqual(2, inspectionResults.First().QuickFixes.Count());
+            Assert.AreEqual(0, inspectionResults.Count());
         }
 
         [TestMethod]