Merge with conflicts

Author: Hosch250

Rubberduck.Parsing/Inspections/Resources/InspectionsUI.Designer.cs

@@ -232,31 +232,31 @@
     <value>The 'Call' statement is no longer required to call procedures, and only exists in the language to support legacy code that required it; it can be safely rewritten to an implicit call.</value>
   </data>
   <data name="ObsoleteCallStatementInspectionName" xml:space="preserve">
-    <value>Use of 'Call' statement</value>
+    <value>Use of obsolete 'Call' statement</value>
   </data>
   <data name="ObsoleteCommentSyntaxInspectionMeta" xml:space="preserve">
     <value>The 'Rem' statement only exists in the language to support legacy code that required it; it can be safely replaced with an apostrophe / single-quote comment.</value>
   </data>
   <data name="ObsoleteCommentSyntaxInspectionName" xml:space="preserve">
-    <value>Use of 'Rem' statement</value>
+    <value>Use of obsolete 'Rem' statement</value>
   </data>
   <data name="ObsoleteGlobalInspectionMeta" xml:space="preserve">
     <value>The 'Global' keyword only exists in the language to support legacy code that required it; it can be safely replaced with the 'Public' modifier.</value>
   </data>
   <data name="ObsoleteGlobalInspectionName" xml:space="preserve">
-    <value>Use of 'Global' access modifier</value>
+    <value>Use of obsolete 'Global' access modifier</value>
   </data>
   <data name="ObsoleteLetStatementInspectionMeta" xml:space="preserve">
     <value>The 'Let' statement only exists in the language to support legacy code that required it; it can be safely removed, since modern VBA does not require that keyword for value assignments.</value>
   </data>
   <data name="ObsoleteLetStatementInspectionName" xml:space="preserve">
-    <value>Use of explicit 'Let' statement</value>
+    <value>Use of obsolete explicit 'Let' statement</value>
   </data>
   <data name="ObsoleteTypeHintInspectionMeta" xml:space="preserve">
     <value>Type hint characters only exist in the language to support legacy code that required it; they can be safely replaced in declarations with an "As" type clause that specifies the type explicitly, and they can be omitted in other identifier references.</value>
   </data>
   <data name="ObsoleteTypeHintInspectionName" xml:space="preserve">
-    <value>Type hint usage</value>
+    <value>Obsolete Type hint usage</value>
   </data>
   <data name="OptionBaseInspectionMeta" xml:space="preserve">
     <value>Arrays are typically zero-based. This option changes the default lower boundary for implicitly-sized arrays, which can introduce off-by-one errors if one isn't cautious.</value>

Rubberduck.Parsing/Inspections/Resources/InspectionsUI.resx

@@ -57,7 +57,7 @@ public void InspectionMetaStringsExist()
         {
             var inspections = typeof(InspectionBase).Assembly.GetTypes()
                           .Where(type => GetAllBaseTypes(type).Contains(typeof(InspectionBase)) && !type.IsAbstract)
-                          .Where(i => string.IsNullOrEmpty(InspectionsUI.ResourceManager.GetString(i.Name + "Meta")))
+                          .Where(i => string.IsNullOrWhiteSpace(InspectionsUI.ResourceManager.GetString(i.Name + "Meta")))
                           .Select(i => i.Name)
                           .ToList();
 
@@ -83,7 +83,7 @@ public void InspectionResultFormatStringsExist()
             var inspections = typeof(InspectionBase).Assembly.GetTypes()
                           .Where(type => GetAllBaseTypes(type).Contains(typeof(InspectionBase)) && !type.IsAbstract)
                           .Where(i => !inspectionsWithSharedResultFormat.Contains(i.Name) &&
-                                      string.IsNullOrEmpty(InspectionsUI.ResourceManager.GetString(i.Name + "ResultFormat")))
+                                      string.IsNullOrWhiteSpace(InspectionsUI.ResourceManager.GetString(i.Name + "ResultFormat")))
                           .Select(i => i.Name)
                           .ToList();
 
@@ -99,7 +99,7 @@ public void InspectionNameStrings_AreNotFormatted()
                           .Where(i =>
                           {
                               var value = InspectionsUI.ResourceManager.GetString(i.Name + "Name");
-                              return !string.IsNullOrEmpty(value) && value.Contains("{0}");
+                              return !string.IsNullOrWhiteSpace(value) && value.Contains("{0}");
                           })
                           .Select(i => i.Name)
                           .ToList();