Skip to content

Commit d027edf

Browse files
MDoernerMDoerner
committed
Fix categorization of failed default member resolution inspection tests
1 parent 629deec commit d027edf

File tree

3 files changed

+32
-63
lines changed

3 files changed

+32
-63
lines changed

‎RubberduckTests/Inspections/DefaultMemberRequiredInspectionTests.cs

Lines changed: 12 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,7 @@ namespace RubberduckTests.Inspections
1313
[TestFixture]
1414
public class DefaultMemberRequiredInspectionTests : InspectionTestsBase
1515
{
16-
17-
[Category("Grammar")]
18-
[Category("Resolver")]
16+
[Category("Inspections")]
1917
[Test]
2018
public void ChainedDictionaryAccessFailedAtEnd_OneResult()
2119
{
@@ -53,8 +51,7 @@ End Function
5351
Assert.AreEqual(expectedSelection, actualSelection);
5452
}
5553

56-
[Category("Grammar")]
57-
[Category("Resolver")]
54+
[Category("Inspections")]
5855
[Test]
5956
public void ChainedDictionaryAccessExpressionFailedAtStart_OneResult()
6057
{
@@ -92,8 +89,7 @@ End Function
9289
Assert.AreEqual(expectedSelection, actualSelection);
9390
}
9491

95-
[Category("Grammar")]
96-
[Category("Resolver")]
92+
[Category("Inspections")]
9793
[Test]
9894
public void FailedDictionaryAccessExpressionWithIndexedDefaultMemberAccess_OneResult()
9995
{
@@ -131,8 +127,7 @@ End Function
131127
Assert.AreEqual(expectedSelection, actualSelection);
132128
}
133129

134-
[Category("Grammar")]
135-
[Category("Resolver")]
130+
[Category("Inspections")]
136131
[Test]
137132
public void FailedIndexExpressionOnVariable_WithoutArguments_OneResult()
138133
{
@@ -161,8 +156,7 @@ End Function
161156
Assert.AreEqual(expectedSelection, actualSelection);
162157
}
163158

164-
[Category("Grammar")]
165-
[Category("Resolver")]
159+
[Category("Inspections")]
166160
[Test]
167161
public void FailedIndexExpressionOnVariable_WithArguments_OneResult()
168162
{
@@ -191,8 +185,7 @@ End Function
191185
Assert.AreEqual(expectedSelection, actualSelection);
192186
}
193187

194-
[Category("Grammar")]
195-
[Category("Resolver")]
188+
[Category("Inspections")]
196189
[Test]
197190
public void FailedIndexExpressionOnArrayAccess_WithoutArguments_OneResult()
198191
{
@@ -221,8 +214,7 @@ End Function
221214
Assert.AreEqual(expectedSelection, actualSelection);
222215
}
223216

224-
[Category("Grammar")]
225-
[Category("Resolver")]
217+
[Category("Inspections")]
226218
[Test]
227219
public void FailedIndexExpressionOnArrayAccess_WithArguments_OneResult()
228220
{
@@ -251,8 +243,7 @@ End Function
251243
Assert.AreEqual(expectedSelection, actualSelection);
252244
}
253245

254-
[Category("Grammar")]
255-
[Category("Resolver")]
246+
[Category("Inspections")]
256247
[Test]
257248
public void FailedIndexExpressionOnOtherIndexExpression_WithoutArguments_OneResult()
258249
{
@@ -281,8 +272,7 @@ End Function
281272
Assert.AreEqual(expectedSelection, actualSelection);
282273
}
283274

284-
[Category("Grammar")]
285-
[Category("Resolver")]
275+
[Category("Inspections")]
286276
[Test]
287277
public void FailedIndexExpressionOnOtherIndexExpression_WithArguments_OneResult()
288278
{
@@ -311,8 +301,7 @@ End Function
311301
Assert.AreEqual(expectedSelection, actualSelection);
312302
}
313303

314-
[Category("Grammar")]
315-
[Category("Resolver")]
304+
[Category("Inspections")]
316305
[Test]
317306
public void FailedIndexExpressionOnParameterlessFunction_WithArguments_OneResult()
318307
{
@@ -341,8 +330,7 @@ End Function
341330
Assert.AreEqual(expectedSelection, actualSelection);
342331
}
343332

344-
[Category("Grammar")]
345-
[Category("Resolver")]
333+
[Category("Inspections")]
346334
[Test]
347335
public void FailedIndexExpressionOnFunctionWithParameters_NoResult()
348336
{
@@ -367,8 +355,7 @@ End Function
367355
Assert.IsFalse(inspectionResults.Any());
368356
}
369357

370-
[Category("Grammar")]
371-
[Category("Resolver")]
358+
[Category("Inspections")]
372359
[Test]
373360
[TestCase("String", "bar = \"Hello \" & Foo(Nothing)")]
374361
[TestCase("Class1", "Set Foo = Foo(Nothing)")]

‎RubberduckTests/Inspections/ProcedureRequiredInspectionTests.cs

Lines changed: 14 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,7 @@ namespace RubberduckTests.Inspections
1212
public class ProcedureRequiredInspectionTests : InspectionTestsBase
1313
{
1414
[Test]
15-
[Category("Grammar")]
16-
[Category("Resolver")]
15+
[Category("Inspections")]
1716
//This will be handled by another inspection, since it is a failed indexed default member resolution.
1817
public void FailedParameterizedProcedureCoercionReferenceOnEntireContext()
1918
{
@@ -51,8 +50,7 @@ End Sub
5150
}
5251

5352
[Test]
54-
[Category("Grammar")]
55-
[Category("Resolver")]
53+
[Category("Inspections")]
5654
public void FailedNonParameterizedProcedureCoercionReferenceOnEntireContext()
5755
{
5856
var class1Code = @"
@@ -89,8 +87,7 @@ End Sub
8987
}
9088

9189
[Test]
92-
[Category("Grammar")]
93-
[Category("Resolver")]
90+
[Category("Inspections")]
9491
//This will be handled by another inspection, since it is a failed indexed default member resolution.
9592
public void FailedParameterizedProcedureCoercionReferenceOnEntireContext_ExplicitCall()
9693
{
@@ -128,8 +125,7 @@ End Sub
128125
}
129126

130127
[Test]
131-
[Category("Grammar")]
132-
[Category("Resolver")]
128+
[Category("Inspections")]
133129
public void FailedNonParameterizedProcedureCoercionReferenceOnEntireContext_ExplicitCall()
134130
{
135131
var class1Code = @"
@@ -166,8 +162,7 @@ End Sub
166162
}
167163

168164
[Test]
169-
[Category("Grammar")]
170-
[Category("Resolver")]
165+
[Category("Inspections")]
171166
public void FailedNonParameterizedProcedureCoercionOnArrayAccessReferenceOnEntireContext()
172167
{
173168
var class1Code = @"
@@ -204,8 +199,7 @@ End Sub
204199
}
205200

206201
[Test]
207-
[Category("Grammar")]
208-
[Category("Resolver")]
202+
[Category("Inspections")]
209203
public void FailedNonParameterizedProcedureCoercionOnArrayAccessReferenceOnEntireContext_ExplicitCall()
210204
{
211205
var class1Code = @"
@@ -240,9 +234,9 @@ End Sub
240234
var inspectionResults = InspectionResults(vbe.Object);
241235
Assert.AreEqual(1, inspectionResults.Count());
242236
}
237+
243238
[Test]
244-
[Category("Grammar")]
245-
[Category("Resolver")]
239+
[Category("Inspections")]
246240
public void SuccessfulParameterizedProcedureCoercionReferenceOnEntireContext()
247241
{
248242
var class1Code = @"
@@ -280,8 +274,7 @@ End Sub
280274
}
281275

282276
[Test]
283-
[Category("Grammar")]
284-
[Category("Resolver")]
277+
[Category("Inspections")]
285278
public void SuccessfulNonParameterizedProcedureCoercionReferenceOnEntireContext()
286279
{
287280
var class1Code = @"
@@ -319,8 +312,7 @@ End Sub
319312
}
320313

321314
[Test]
322-
[Category("Grammar")]
323-
[Category("Resolver")]
315+
[Category("Inspections")]
324316
public void SuccessfulParameterizedProcedureCoercionReferenceOnEntireContext_ExplicitCall()
325317
{
326318
var class1Code = @"
@@ -358,8 +350,7 @@ End Sub
358350
}
359351

360352
[Test]
361-
[Category("Grammar")]
362-
[Category("Resolver")]
353+
[Category("Inspections")]
363354
public void SuccessfulNonParameterizedProcedureCoercionReferenceOnEntireContext_ExplicitCall()
364355
{
365356
var class1Code = @"
@@ -397,8 +388,7 @@ End Sub
397388
}
398389

399390
[Test]
400-
[Category("Grammar")]
401-
[Category("Resolver")]
391+
[Category("Inspections")]
402392
public void SuccessfulNonParameterizedProcedureCoercionOnArrayAccessReferenceOnEntireContext()
403393
{
404394
var class1Code = @"
@@ -437,8 +427,7 @@ End Sub
437427
}
438428

439429
[Test]
440-
[Category("Grammar")]
441-
[Category("Resolver")]
430+
[Category("Inspections")]
442431
public void SuccessfulNonParameterizedProcedureCoercionOnArrayAccessReferenceOnEntireContext_ExplicitCall()
443432
{
444433
var class1Code = @"
@@ -476,8 +465,7 @@ End Sub
476465
Assert.IsFalse(inspectionResults.Any());
477466
}
478467

479-
[Category("Grammar")]
480-
[Category("Resolver")]
468+
[Category("Inspections")]
481469
[Test]
482470
[TestCase("", "Call Foo")]
483471
[TestCase("", "Call Foo()")]

‎RubberduckTests/Inspections/ValueRequiredInspectionTests.cs

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,7 @@ namespace RubberduckTests.Inspections
1313
public class ValueRequiredInspectionTests : InspectionTestsBase
1414
{
1515
[Test]
16-
[Category("Grammar")]
17-
[Category("Resolver")]
16+
[Category("Inspections")]
1817
[TestCase(" Bar cls.Baz")]
1918
[TestCase(" Baz (cls.Baz)")]
2019
[TestCase(" Debug.Print cls.Baz")]
@@ -151,8 +150,7 @@ End Sub
151150
}
152151

153152
[Test]
154-
[Category("Grammar")]
155-
[Category("Resolver")]
153+
[Category("Inspections")]
156154
[TestCase(" Foo = cls.Baz")]
157155
[TestCase(" Let Foo = cls.Baz")]
158156
[TestCase(" Foo = cls.Baz + 42")]
@@ -239,8 +237,7 @@ End Sub
239237
}
240238

241239
[Test]
242-
[Category("Grammar")]
243-
[Category("Resolver")]
240+
[Category("Inspections")]
244241
[TestCase(" Foo = cls.Baz")]
245242
[TestCase(" Let Foo = cls.Baz")]
246243
[TestCase(" fooBaz(42) = cls.Baz")]
@@ -297,8 +294,7 @@ End Sub
297294
}
298295

299296
[Test]
300-
[Category("Grammar")]
301-
[Category("Resolver")]
297+
[Category("Inspections")]
302298
[TestCase(" cls.Baz = 42")]
303299
[TestCase(" Let cls.Baz = 42")]
304300
[TestCase(" cls.Bar(42) = 42")]
@@ -342,8 +338,7 @@ End Sub
342338
Assert.IsFalse(inspectionResults.Any());
343339
}
344340

345-
[Category("Grammar")]
346-
[Category("Resolver")]
341+
[Category("Inspections")]
347342
[Test]
348343
public void ParamArray_NoResult()
349344
{
@@ -371,8 +366,7 @@ End Function
371366
Assert.IsFalse(inspectionResults.Any());
372367
}
373368

374-
[Category("Grammar")]
375-
[Category("Resolver")]
369+
[Category("Inspections")]
376370
[Test]
377371
public void ParamArrayInLibrary_NoResult()
378372
{

0 commit comments

Comments
 (0)