Merge pull request #4898 from Vogel612/remove-inspection-aggregation

Removes inspection result aggregation

Author: retailcoder

Rubberduck.CodeAnalysis/Inspections/Inspector.cs

@@ -30,7 +30,6 @@ public class Inspector : IInspector
 
             private readonly IGeneralConfigService _configService;
             private readonly List<IInspection> _inspections;
-            private const int AGGREGATION_THRESHOLD = 128;
 
             public Inspector(IGeneralConfigService configService, IInspectionProvider inspectionProvider)
             {
@@ -42,8 +41,8 @@ public Inspector(IGeneralConfigService configService, IInspectionProvider inspec
 
             private void ConfigServiceSettingsChanged(object sender, EventArgs e)
             {
-                //var config = _configService.LoadConfiguration();
-                //UpdateInspectionSeverity(config);
+                var config = _configService.LoadConfiguration();
+                UpdateInspectionSeverity(config);
             }
 
             private void UpdateInspectionSeverity(Configuration config)
@@ -133,16 +132,9 @@ public async Task<IEnumerable<IInspectionResult>> FindIssuesAsync(RubberduckPars
                     LogManager.GetCurrentClassLogger().Error(e);
                 }
 
-                var issuesByType = allIssues.GroupBy(issue => issue.Inspection.Name)
-                                            .ToDictionary(grouping => grouping.Key, grouping => grouping.ToList());
-                var results = issuesByType.Where(kv => kv.Value.Count <= AGGREGATION_THRESHOLD)
-                    .SelectMany(kv => kv.Value)
-                    .Union(issuesByType.Where(kv => kv.Value.Count > AGGREGATION_THRESHOLD)
-                    .Select(kv => new AggregateInspectionResult(kv.Value.OrderBy(i => i.QualifiedSelection).First(), kv.Value.Count)))
-                    .ToList();
-
-                state.OnStatusMessageUpdate(RubberduckUI.ResourceManager.GetString("ParserState_" + state.Status, CultureInfo.CurrentUICulture)); // should be "Ready"
-                return results;
+                // should be "Ready"
+                state.OnStatusMessageUpdate(RubberduckUI.ResourceManager.GetString("ParserState_" + state.Status, CultureInfo.CurrentUICulture)); 
+                return allIssues;
             }
 
             private static bool RequiredLibrariesArePresent(IInspection inspection, RubberduckParserState state)

Rubberduck.Core/UI/Inspections/AggregateInspectionResult.cs

@@ -176,26 +176,5 @@ public void IdentifierReferenceInspectionResultsAreNotDeemedInvalidatedIfNeither
 
             Assert.IsFalse(inspectionResult.ChangesInvalidateResult(modifiedModules));
         }
-
-        [Test]
-        public void AggregateInspectionResultsAreAlwaysDeemedInvalidated()
-        {
-            var inspectionMock = new Mock<IInspection>();
-            inspectionMock
-                .Setup(m =>
-                    m.ChangesInvalidateResult(It.IsAny<IInspectionResult>(),
-                        It.IsAny<ICollection<QualifiedModuleName>>()))
-                .Returns(false);
-
-            var module = new QualifiedModuleName("project", string.Empty, "module");
-            var otherModule = new QualifiedModuleName("project", string.Empty, "otherModule");
-            var context = new QualifiedContext(module, null);
-            var modifiedModules = new HashSet<QualifiedModuleName> { otherModule };
-
-            var baseInspectionResult = new QualifiedContextInspectionResult(inspectionMock.Object, string.Empty, context);
-            var inspectionResult = new AggregateInspectionResult(baseInspectionResult, 42);
-
-            Assert.IsTrue(inspectionResult.ChangesInvalidateResult(modifiedModules));
-        }
     }
 }