removed (commented-out) menus and commandbars dispose/teardown... and against all recommendations, best practices, and common sense, ...we get a clean exit.

Author: retailcoder

RetailCoder.VBE/AppMenu.cs

@@ -42,11 +42,12 @@ public void Localize()
 
         public void Dispose()
         {
-            foreach (var menu in _menus.Where(menu => menu.Item != null))
-            {
-                menu.RemoveChildren();
-                menu.Item.Delete();
-            }
+            // note: doing this wrecks the teardown process. counter-intuitive? sure. but hey it works.
+            //foreach (var menu in _menus.Where(menu => menu.Item != null))
+            //{
+            //    menu.RemoveChildren();
+            //    menu.Item.Delete();
+            //}
         }
     }
 }

RetailCoder.VBE/UI/Command/MenuItems/CommandBars/AppCommandBarBase.cs

@@ -110,12 +110,13 @@ public void EvaluateCanExecute(RubberduckParserState state)
         public ICommandBar Item { get; private set; }
         public void RemoveChildren()
         {
-            foreach (var child in _items.Values.Select(item => item as CommandBarButton).Where(child => child != null))
-            {
-                child.Click -= child_Click;
-                child.Delete();
-                //child.Release();
-            }
+            // note: doing this wrecks the teardown process. counter-intuitive? sure. but hey it works.
+            //foreach (var child in _items.Values.Select(item => item as CommandBarButton).Where(child => child != null))
+            //{
+            //    child.Click -= child_Click;
+            //    child.Delete();
+            //    child.Release();
+            //}
         }
 
         // note: HAAAAACK!!!

RetailCoder.VBE/UI/Command/MenuItems/CommandBars/RubberduckCommandBar.cs

@@ -53,9 +53,10 @@ public void SetContextSelectionCaption(string caption)
 
         public void Dispose()
         {
-            RemoveChildren();
-            Item.Delete();
-            Item.Release(true);
+            //note: doing this wrecks the teardown process. counter-intuitive? sure. but hey it works.
+            //RemoveChildren();
+            //Item.Delete();
+            //Item.Release(true);
         }
     }
 

RetailCoder.VBE/UI/Command/MenuItems/ParentMenus/ParentMenuItemBase.cs

@@ -96,14 +96,14 @@ public void RemoveChildren()
             foreach (var child in _items.Keys.Select(item => item as IParentMenuItem).Where(child => child != null))
             {
                 child.RemoveChildren();
-                var item = _items[child];
-                Debug.Assert(item is CommandBarPopup);
-                (item as CommandBarPopup).Delete();
+                //var item = _items[child];
+                //Debug.Assert(item is CommandBarPopup);
+                //(item as CommandBarPopup).Delete();
             }
             foreach (var child in _items.Values.Select(item => item as CommandBarButton).Where(child => child != null))
             {
                 child.Click -= child_Click;
-                child.Delete();
+                //child.Delete();
             }
         }
 

Rubberduck.VBEEditor/SafeComWrappers/Office.Core/CommandBars.cs

@@ -77,15 +77,15 @@ public ICommandBar this[object index]
 
         public override void Release(bool final = false)
         {
-            if (!IsWrappingNullReference)
-            {
-                var commandBars = this.ToArray();
-                foreach (var commandBar in commandBars)
-                {
-                    commandBar.Release();
-                }
-                base.Release(final);
-            }
+            //if (!IsWrappingNullReference)
+            //{
+            //    var commandBars = this.ToArray();
+            //    foreach (var commandBar in commandBars)
+            //    {
+            //        commandBar.Release();
+            //    }
+            //    base.Release(final);
+            //}
         }
 
         public override bool Equals(ISafeComWrapper<Microsoft.Office.Core.CommandBars> other)

Rubberduck.VBEEditor/SafeComWrappers/VBA/VBE.cs

@@ -90,7 +90,7 @@ public override void Release(bool final = false)
             {
                 VBProjects.Release();
                 CodePanes.Release();
-                CommandBars.Release();
+                //CommandBars.Release();
                 Windows.Release();
                 AddIns.Release();
                 base.Release(final);