Skip to content

Commit c8f48d2

Browse files
rubberduck203rubberduck203
committed
expected/actual args were all backwards, added tests to reach 100% coverage for AssertClass
1 parent fbcf8bb commit c8f48d2

File tree

1 file changed

+79
-22
lines changed

1 file changed

+79
-22
lines changed

‎RubberduckTests/AssertTests.cs

Lines changed: 79 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public void IsTrueSucceedsWithTrueExpression()
2727
var assert = new AssertClass();
2828
assert.IsTrue(true);
2929

30-
Assert.AreEqual(_args.Result.Outcome, TestOutcome.Succeeded);
30+
Assert.AreEqual(TestOutcome.Succeeded, _args.Result.Outcome);
3131
}
3232

3333
[TestMethod]
@@ -36,7 +36,7 @@ public void IsTrueFailsWithFalseExpression()
3636
var assert = new AssertClass();
3737
assert.IsTrue(false);
3838

39-
Assert.AreEqual(_args.Result.Outcome, TestOutcome.Failed);
39+
Assert.AreEqual(TestOutcome.Failed, _args.Result.Outcome);
4040
}
4141

4242
[TestMethod]
@@ -45,7 +45,7 @@ public void IsFalseSucceedsWithFalseExpression()
4545
var assert = new AssertClass();
4646
assert.IsFalse(false);
4747

48-
Assert.AreEqual(_args.Result.Outcome, TestOutcome.Succeeded);
48+
Assert.AreEqual(TestOutcome.Succeeded, _args.Result.Outcome);
4949
}
5050

5151
[TestMethod]
@@ -54,7 +54,7 @@ public void IsFalseFailsWithTrueExpression()
5454
var assert = new AssertClass();
5555
assert.IsFalse(true);
5656

57-
Assert.AreEqual(_args.Result.Outcome, TestOutcome.Failed);
57+
Assert.AreEqual(TestOutcome.Failed, _args.Result.Outcome);
5858
}
5959

6060
[TestMethod]
@@ -65,7 +65,7 @@ public void AreSameShouldSucceedWithSameReferences()
6565
var obj2 = obj1;
6666
assert.AreSame(obj1, obj2);
6767

68-
Assert.AreEqual(_args.Result.Outcome, TestOutcome.Succeeded);
68+
Assert.AreEqual(TestOutcome.Succeeded, _args.Result.Outcome);
6969
}
7070

7171
[TestMethod]
@@ -76,7 +76,34 @@ public void AreSameShouldFailWithDifferentReferences()
7676
var obj2 = new object();
7777
assert.AreSame(obj1, obj2);
7878

79-
Assert.AreEqual(_args.Result.Outcome, TestOutcome.Failed);
79+
Assert.AreEqual(TestOutcome.Failed, _args.Result.Outcome);
80+
}
81+
82+
[TestMethod]
83+
public void AreSameShouldSucceedWithTwoNullReferences()
84+
{
85+
var assert = new AssertClass();
86+
assert.AreSame(null, null);
87+
88+
Assert.AreEqual(TestOutcome.Succeeded, _args.Result.Outcome);
89+
}
90+
91+
[TestMethod]
92+
public void AreSameShouldFailWithActualNullReference()
93+
{
94+
var assert = new AssertClass();
95+
assert.AreSame(new object(), null);
96+
97+
Assert.AreEqual(TestOutcome.Failed, _args.Result.Outcome);
98+
}
99+
100+
[TestMethod]
101+
public void AreSameShouldFailWithExpectedNullReference()
102+
{
103+
var assert = new AssertClass();
104+
assert.AreSame(null, new object());
105+
106+
Assert.AreEqual(TestOutcome.Failed, _args.Result.Outcome);
80107
}
81108

82109
[TestMethod]
@@ -87,7 +114,25 @@ public void AreNotSameShouldSucceedWithDifferentReferences()
87114
var obj2 = new object();
88115
assert.AreNotSame(obj1, obj2);
89116

90-
Assert.AreEqual(_args.Result.Outcome, TestOutcome.Succeeded);
117+
Assert.AreEqual(TestOutcome.Succeeded, _args.Result.Outcome);
118+
}
119+
120+
[TestMethod]
121+
public void AreNotSameShouldSuccedWithOneNullReference()
122+
{
123+
var assert = new AssertClass();
124+
assert.AreNotSame(new object(), null);
125+
126+
Assert.AreEqual(TestOutcome.Succeeded, _args.Result.Outcome);
127+
}
128+
129+
[TestMethod]
130+
public void AreNotSameShouldFailWithBothNullReferences()
131+
{
132+
var assert = new AssertClass();
133+
assert.AreNotSame(null, null);
134+
135+
Assert.AreEqual(TestOutcome.Failed, _args.Result.Outcome);
91136
}
92137

93138
[TestMethod]
@@ -98,7 +143,7 @@ public void AreNotSameShouldFailWithSameReferences()
98143
var obj2 = obj1;
99144
assert.AreNotSame(obj1, obj2);
100145

101-
Assert.AreEqual(_args.Result.Outcome, TestOutcome.Failed);
146+
Assert.AreEqual(TestOutcome.Failed, _args.Result.Outcome);
102147
}
103148

104149
[TestMethod]
@@ -107,7 +152,7 @@ public void AreEqualShouldSucceedWithSameValues()
107152
var assert = new AssertClass();
108153
assert.AreEqual(1, 1);
109154

110-
Assert.AreEqual(_args.Result.Outcome, TestOutcome.Succeeded);
155+
Assert.AreEqual(TestOutcome.Succeeded, _args.Result.Outcome);
111156
}
112157

113158
[TestMethod]
@@ -116,7 +161,7 @@ public void AreEqualShouldFailWithDifferentValues()
116161
var assert = new AssertClass();
117162
assert.AreEqual(1, 2);
118163

119-
Assert.AreEqual(_args.Result.Outcome, TestOutcome.Failed);
164+
Assert.AreEqual(TestOutcome.Failed, _args.Result.Outcome);
120165
}
121166

122167
[TestMethod]
@@ -125,7 +170,7 @@ public void AreNotEqualShouldSucceedWithDifferentValues()
125170
var assert = new AssertClass();
126171
assert.AreNotEqual(1, 2);
127172

128-
Assert.AreEqual(_args.Result.Outcome, TestOutcome.Succeeded);
173+
Assert.AreEqual(TestOutcome.Succeeded, _args.Result.Outcome);
129174
}
130175

131176
[TestMethod]
@@ -134,7 +179,19 @@ public void AreNotEqualShouldFailWithSameValues()
134179
var assert = new AssertClass();
135180
assert.AreNotEqual(1, 1);
136181

137-
Assert.AreEqual(_args.Result.Outcome, TestOutcome.Failed);
182+
Assert.AreEqual(TestOutcome.Failed, _args.Result.Outcome);
183+
}
184+
185+
[TestMethod]
186+
public void AreNotEqualShouldBeInconclusiveWithDifferentTypes()
187+
{
188+
int obj1 = 10;
189+
double obj2 = 10;
190+
191+
var assert = new AssertClass();
192+
assert.AreNotEqual(obj1, obj2);
193+
194+
Assert.AreEqual(TestOutcome.Inconclusive, _args.Result.Outcome);
138195
}
139196

140197
[TestMethod]
@@ -143,7 +200,7 @@ public void IsNothingShouldSucceedWithNullValue()
143200
var assert = new AssertClass();
144201
assert.IsNothing(null);
145202

146-
Assert.AreEqual(_args.Result.Outcome, TestOutcome.Succeeded);
203+
Assert.AreEqual(TestOutcome.Succeeded, _args.Result.Outcome);
147204
}
148205

149206
[TestMethod]
@@ -152,7 +209,7 @@ public void IsNothingShouldFailWithNonNullValue()
152209
var assert = new AssertClass();
153210
assert.IsNothing(new object());
154211

155-
Assert.AreEqual(_args.Result.Outcome, TestOutcome.Failed);
212+
Assert.AreEqual(TestOutcome.Failed, _args.Result.Outcome);
156213
}
157214

158215
[TestMethod]
@@ -161,7 +218,7 @@ public void IsNotNothingShouldFailWithNullValue()
161218
var assert = new AssertClass();
162219
assert.IsNotNothing(null);
163220

164-
Assert.AreEqual(_args.Result.Outcome, TestOutcome.Failed);
221+
Assert.AreEqual(TestOutcome.Failed, _args.Result.Outcome);
165222
}
166223

167224
[TestMethod]
@@ -170,7 +227,7 @@ public void IsNotNothingShouldSucceedWithNonNullValue()
170227
var assert = new AssertClass();
171228
assert.IsNotNothing(new object());
172229

173-
Assert.AreEqual(_args.Result.Outcome, TestOutcome.Succeeded);
230+
Assert.AreEqual(TestOutcome.Succeeded, _args.Result.Outcome);
174231
}
175232

176233
[TestMethod]
@@ -179,7 +236,7 @@ public void FailShouldFail()
179236
var assert = new AssertClass();
180237
assert.Fail();
181238

182-
Assert.AreEqual(_args.Result.Outcome, TestOutcome.Failed);
239+
Assert.AreEqual(TestOutcome.Failed, _args.Result.Outcome);
183240
}
184241

185242
[TestMethod]
@@ -188,7 +245,7 @@ public void InconclusiveShouldBeInconclusive()
188245
var assert = new AssertClass();
189246
assert.Inconclusive();
190247

191-
Assert.AreEqual(_args.Result.Outcome, TestOutcome.Inconclusive);
248+
Assert.AreEqual(TestOutcome.Inconclusive, _args.Result.Outcome);
192249
}
193250

194251
private void AssertHandler_OnAssertCompleted(object sender, AssertCompletedEventArgs e)
@@ -202,7 +259,7 @@ public void NullValuesAreEqual()
202259
var assert = new AssertClass();
203260
assert.AreEqual(null, null);
204261

205-
Assert.AreEqual(_args.Result.Outcome, TestOutcome.Succeeded);
262+
Assert.AreEqual(TestOutcome.Succeeded, _args.Result.Outcome);
206263
}
207264

208265
[TestMethod]
@@ -211,7 +268,7 @@ public void NullAndEmptyStringAreEqual()
211268
var assert = new AssertClass();
212269
assert.AreEqual(null, string.Empty);
213270

214-
Assert.AreEqual(_args.Result.Outcome, TestOutcome.Succeeded);
271+
Assert.AreEqual(TestOutcome.Succeeded, _args.Result.Outcome);
215272
}
216273

217274
[TestMethod]
@@ -220,7 +277,7 @@ public void NullIsNotComparableWithValues()
220277
var assert = new AssertClass();
221278
assert.AreEqual(42, null);
222279

223-
Assert.AreEqual(_args.Result.Outcome, TestOutcome.Inconclusive);
280+
Assert.AreEqual(TestOutcome.Inconclusive, _args.Result.Outcome);
224281
}
225282

226283
[TestMethod]
@@ -229,7 +286,7 @@ public void DifferentTypesEqualityIsNotConclusive()
229286
var assert = new AssertClass();
230287
assert.AreEqual(42, "42");
231288

232-
Assert.AreEqual(_args.Result.Outcome, TestOutcome.Inconclusive);
289+
Assert.AreEqual(TestOutcome.Inconclusive, _args.Result.Outcome);
233290
}
234291
}
235292
}

0 commit comments

Comments
 (0)