Added checks for illegal annotations

Author: rkapka

Rubberduck.CodeAnalysis/Inspections/Concrete/DuplicatedAnnotationInspection.cs

@@ -2,7 +2,9 @@
 using System.Linq;
 using Rubberduck.Inspections.Abstract;
 using Rubberduck.Inspections.Results;
+using Rubberduck.Parsing.Annotations;
 using Rubberduck.Parsing.Inspections.Abstract;
+using Rubberduck.Parsing.Symbols;
 using Rubberduck.Parsing.VBA;
 using Rubberduck.Resources.Inspections;
 
@@ -22,7 +24,11 @@ protected override IEnumerable<IInspectionResult> DoGetInspectionResults()
             {
                 var duplicateAnnotations = declaration.Annotations
                     .GroupBy(annotation => annotation.AnnotationType)
-                    .Where(group => !group.First().AllowMultiple && group.Count() > 1);
+                    .Where(group => !group.First().AllowMultiple && group.Count() > 1 &&
+                                    (group.Key.HasFlag(AnnotationType.ModuleAnnotation) &&
+                                     declaration.DeclarationType.HasFlag(DeclarationType.Module) ||
+                                     group.Key.HasFlag(AnnotationType.MemberAnnotation) &&
+                                     declaration.DeclarationType.HasFlag(DeclarationType.Member)));
 
                 issues.AddRange(duplicateAnnotations.Select(duplicate => new DeclarationInspectionResult(
                     this,

RubberduckTests/Inspections/DuplicatedAnnotationInspectionTests.cs

@@ -14,9 +14,6 @@ public class DuplicatedAnnotationInspectionTests
         public void AnnotationDuplicated_ReturnsResult()
         {
             const string inputCode = @"
-Public Sub Qux()
-End Sub
-
 '@Obsolete
 '@Obsolete
 Public Sub Foo()
@@ -37,9 +34,6 @@ Public Sub Foo()
         public void AnnotationDuplicatedTwice_ReturnsSingleResult()
         {
             const string inputCode = @"
-Public Sub Qux()
-End Sub
-
 '@Obsolete
 '@Obsolete
 '@Obsolete
@@ -61,9 +55,6 @@ Public Sub Foo()
         public void AnnotationNotDuplicated_DoesNotReturnResult()
         {
             const string inputCode = @"
-Public Sub Qux()
-End Sub
-
 '@Obsolete
 Public Sub Foo()
 End Sub";
@@ -83,9 +74,6 @@ Public Sub Foo()
         public void AnnotationAllowingMultipleApplicationsDuplicated_DoesNotReturnResult()
         {
             const string inputCode = @"
-Public Sub Qux()
-End Sub
-
 '@Ignore(Bar)
 '@Ignore(Baz)
 Public Sub Foo()
@@ -100,5 +88,51 @@ Public Sub Foo()
                 Assert.AreEqual(0, inspectionResults.Count());
             }
         }
+
+        [Test]
+        [Category("Inspections")]
+        public void MemberAnnotationDuplicatedForModuleDeclaration_DoesNotReturnResult()
+        {
+            const string inputCode = @"
+'@TestInitialize
+'@TestInitialize
+
+Public S as String
+
+Public Sub Foo()
+End Sub";
+
+            var vbe = MockVbeBuilder.BuildFromSingleStandardModule(inputCode, out _);
+            using (var state = MockParser.CreateAndParse(vbe.Object))
+            {
+                var inspection = new DuplicatedAnnotationInspection(state);
+                var inspectionResults = inspection.GetInspectionResults(CancellationToken.None);
+
+                Assert.AreEqual(0, inspectionResults.Count());
+            }
+        }
+
+        [Test]
+        [Category("Inspections")]
+        public void ModuleAnnotationDuplicatedForMemberDeclaration_DoesNotReturnResult()
+        {
+            const string inputCode = @"
+Public Sub Foo()
+End Sub
+
+'@Folder(Baz)
+'@Folder(Baz)
+Public Sub Bar()
+End Sub";
+
+            var vbe = MockVbeBuilder.BuildFromSingleStandardModule(inputCode, out _);
+            using (var state = MockParser.CreateAndParse(vbe.Object))
+            {
+                var inspection = new DuplicatedAnnotationInspection(state);
+                var inspectionResults = inspection.GetInspectionResults(CancellationToken.None);
+
+                Assert.AreEqual(0, inspectionResults.Count());
+            }
+        }
     }
 }