Omit controls from member not on interface inspection results. Ref #2592. Closes #3532

Author: comintern

Rubberduck.CodeAnalysis/Inspections/Concrete/MemberNotOnInterfaceInspection.cs

@@ -21,7 +21,7 @@ protected override IEnumerable<IInspectionResult> DoGetInspectionResults()
 
             var targets = Declarations.Where(decl => decl.AsTypeDeclaration != null &&
                                                      !decl.AsTypeDeclaration.IsUserDefined &&
-                                                     decl.AsTypeDeclaration.DeclarationType.HasFlag(DeclarationType.ClassModule) &&
+                                                     decl.AsTypeDeclaration.DeclarationType.HasFlag(DeclarationType.ClassModule) &&                                                    
                                                      ((ClassModuleDeclaration)decl.AsTypeDeclaration).IsExtensible)
                                        .SelectMany(decl => decl.References).ToList();
             return unresolved
@@ -33,7 +33,8 @@ protected override IEnumerable<IInspectionResult> DoGetInspectionResults()
                                                                          usage.Context.Parent.Parent.Equals(access.CallingContext))
                                                                      )
                 })
-                .Where(memberAccess => memberAccess.callingContext != null)
+                .Where(memberAccess => memberAccess.callingContext != null &&
+                                       memberAccess.callingContext.Declaration.DeclarationType != DeclarationType.Control)    //TODO - remove this exception after resolving #2592)
                 .Select(memberAccess => new DeclarationInspectionResult(this,
                     string.Format(InspectionResults.MemberNotOnInterfaceInspection, memberAccess.access.IdentifierName,
                         memberAccess.callingContext.Declaration.AsTypeDeclaration.IdentifierName), memberAccess.access));

RubberduckTests/Inspections/MemberNotOnInterfaceInspectionTests.cs

@@ -267,7 +267,7 @@ End With
         //See https://github.com/rubberduck-vba/Rubberduck/issues/4308 
         [Test]
         [Category("Inspections")]
-        [Ignore("To be unignored in a PR fixing issue 4308.")]
+        //[Ignore("To be unignored in a PR fixing issue 4308.")]
         public void MemberNotOnInterface_ProcedureArgument()
         {
             const string inputCode =
@@ -380,12 +380,28 @@ End Sub
 
         [Test]
         [Category("Inspections")]
-        public void InspectionName()
+        public void MemberNotOnInterface_DoesNotReturnResult_ControlObject()
         {
-            const string inspectionName = "MemberNotOnInterfaceInspection";
-            var inspection = new MemberNotOnInterfaceInspection(null);
+            const string inputCode =
+                @"Sub Foo(bar as MSForms.TextBox)
+    Debug.Print bar.Left
+End Sub";
+
+            var vbeBuilder = new MockVbeBuilder();
+            var projectBuilder = vbeBuilder.ProjectBuilder("testproject", ProjectProtection.Unprotected);
+            projectBuilder.MockUserFormBuilder("UserForm1", inputCode).AddFormToProjectBuilder()
+                .AddReference("MSForms", MockVbeBuilder.LibraryPathMsForms, 2, 0, true);
 
-            Assert.AreEqual(inspectionName, inspection.Name);
+            vbeBuilder.AddProject(projectBuilder.Build());
+            var vbe = vbeBuilder.Build();
+
+            using (var state = MockParser.CreateAndParse(vbe.Object))
+            {
+                var inspection = new MemberNotOnInterfaceInspection(state);
+                var inspectionResults = inspection.GetInspectionResults(CancellationToken.None);
+
+                Assert.IsTrue(!inspectionResults.Any());
+            }
         }
     }
 }