Clarify todos and add comments

Author: MDoerner

Rubberduck.CodeAnalysis/Inspections/Concrete/AssignedByValParameterInspection.cs

@@ -58,6 +58,8 @@ protected override IEnumerable<IInspectionResult> DoGetInspectionResults()
 
         private static bool IsAssignmentToDeclaration(IdentifierReference reference)
         {
+            //Todo: Review whether this is still needed once parameterless default member assignments are resolved correctly.
+
             if (!reference.IsAssignment)
             {
                 return false;

Rubberduck.Parsing/Binding/Bindings/DictionaryAccessDefaultBinding.cs

@@ -16,6 +16,8 @@ public sealed class DictionaryAccessDefaultBinding : IExpressionBinding
 
         private const int DEFAULT_MEMBER_RECURSION_LIMIT = 32;
 
+        //This is based on the spec at https://docs.microsoft.com/en-us/openspecs/microsoft_general_purpose_programming_languages/MS-VBAL/f20c9ebc-3365-4614-9788-1cd50a504574
+
         public DictionaryAccessDefaultBinding(
             ParserRuleContext expression,
             IExpressionBinding lExpressionBinding,

Rubberduck.Parsing/Binding/Bindings/IndexDefaultBinding.cs

@@ -16,6 +16,8 @@ public sealed class IndexDefaultBinding : IExpressionBinding
 
         private const int DEFAULT_MEMBER_RECURSION_LIMIT = 32;
 
+        //This is based on the spec at https://docs.microsoft.com/en-us/openspecs/microsoft_general_purpose_programming_languages/MS-VBAL/551030b2-72a4-4c95-9cb0-fb8f8c8774b4
+
         public IndexDefaultBinding(
             ParserRuleContext expression,
             IExpressionBinding lExpressionBinding,
@@ -250,7 +252,7 @@ private IBoundExpression ResolveDefaultMember(IBoundExpression lExpression, stri
                     index expression references this default member and takes on its classification and 
                     declared type.  
 
-                    TODO: Improve argument compatibility check.
+                    TODO: Improve argument compatibility check by checking the argument types.
                  */
                 var parameters = ((IParameterizedDeclaration) defaultMember).Parameters.ToList();
                 if (ArgumentListIsCompatible(parameters, _argumentList))
@@ -350,7 +352,7 @@ takes on the classification and declared type of <l-expression> and references t
                     references an individual element of the array, is classified as a variable and has the 
                     declared type of the array’s element type.  
 
-                    TODO: Implement compatibility checking / amend the grammar
+                    TODO: Implement compatibility checking
                  */
 
                 return new IndexExpression(indexedDeclaration, ExpressionClassification.Variable, _expression, lExpression, _argumentList, isArrayAccess: true);

Rubberduck.Parsing/Grammar/VBAParser.g4

@@ -647,7 +647,7 @@ visibility : PRIVATE | PUBLIC | FRIEND | GLOBAL;
 // 5.6 Expressions
 expression :
     // Literal Expression has to come before lExpression, otherwise it'll be classified as simple name expression instead.
-	//The same holds for Built-in Type Expression.
+    //The same holds for Built-in Type Expression.
     whiteSpace? LPAREN whiteSpace? expression whiteSpace? RPAREN                                    # parenthesizedExpr
     | TYPEOF whiteSpace expression                                                                  # typeofexpr // To make the grammar SLL, the type-of-is-expression is actually the child of an IS relational op.
     | HASH expression                                                                               # markedFileNumberExpr // Added to support special forms such as Input(file1, #file1)

Rubberduck.VBEEditor/Selection.cs

@@ -142,6 +142,9 @@ public override string ToString()
             return !(selection1 == selection2);
         }
 
+        /// <summary>
+        /// Orders first by start position and then end position.
+        /// </summary>
         public static bool operator >(Selection selection1, Selection selection2)
         {
             return IsGreaterPosition(selection1.StartLine, selection1.StartColumn, selection2.StartLine, selection2.StartColumn)
@@ -156,6 +159,9 @@ private static bool IsGreaterPosition(int line1, int column1, int line2, int col
                     && column1 > column2;
         }
 
+        /// <summary>
+        /// Orders first by start position and then end position.
+        /// </summary>
         public static bool operator <(Selection selection1, Selection selection2)
         {
             return IsLesserPosition(selection1.StartLine, selection1.StartColumn, selection2.StartLine, selection2.StartColumn)
@@ -170,11 +176,17 @@ private static bool IsLesserPosition(int line1, int column1, int line2, int colu
                     && column1 < column2;
         }
 
+        /// <summary>
+        /// Orders first by start position and then end position.
+        /// </summary>
         public static bool operator >=(Selection selection1, Selection selection2)
         {
             return !(selection1 < selection2);
         }
 
+        /// <summary>
+        /// Orders first by start position and then end position.
+        /// </summary>
         public static bool operator <=(Selection selection1, Selection selection2)
         {
             return !(selection1 > selection2);