Made AttributeNode less confusing and fragile.

Author: MDoerner

Rubberduck.Parsing/VBA/Attributes.cs

@@ -20,37 +20,35 @@ public enum Instancing
 
     public class AttributeNode : IEquatable<AttributeNode>
     {
-        private readonly string _name;
         private readonly IList<string> _values;
 
         public AttributeNode(VBAParser.AttributeStmtContext context)
         {
             Context = context;
+            Name = Context?.attributeName().GetText() ?? String.Empty;
+            _values = Context?.attributeValue().Select(a => a.GetText()).ToList() ?? new List<string>();
         }
 
         public AttributeNode(string name, IEnumerable<string> values)
         {
-            _name = name;
+            Name = name;
             _values = values.ToList();
         }
 
         public VBAParser.AttributeStmtContext Context { get; }
 
-        public string Name => Context?.attributeName().GetText() ?? _name;
-
+        public string Name { get; }
+    
         public void AddValue(string value)
         {
-            _values?.Add(value);
+            _values.Add(value);
         }
 
-        public IReadOnlyList<string> Values
-        {
-            get { return Context?.attributeValue().Select(a => a.GetText()).ToArray() ?? _values.ToArray(); }
-        }
+        public IReadOnlyCollection<string> Values => _values.AsReadOnly();
 
         public bool HasValue(string value)
         {
-            return Values.Any(item => item.Equals(value, StringComparison.OrdinalIgnoreCase));
+            return _values.Any(item => item.Equals(value, StringComparison.OrdinalIgnoreCase));
         }
 
         public bool Equals(AttributeNode other)