Skip to content

Commit c22ae5e

Browse files
committed
Address PR comments
1 parent 1545d44 commit c22ae5e

File tree

7 files changed

+58
-25
lines changed

7 files changed

+58
-25
lines changed

Rubberduck.Parsing/Grammar/VBALexer.g4

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ EACH : E A C H;
111111
ELSE : E L S E;
112112
ELSEIF : E L S E I F;
113113
EMPTY : E M P T Y;
114-
// Apparently END_ENUM don't allow line continuations (in the VB editor)
114+
// Apparently END_ENUM doesn't allow line continuations (in the VB editor)
115115
END_ENUM : E N D WS+ E N U M;
116116
END_FUNCTION : E N D (WS | LINE_CONTINUATION)+ F U N C T I O N;
117117
// We allow "EndIf" without the whitespace as well for the preprocessor.

Rubberduck.Resources/Inspections/InspectionInfo.Designer.cs

Lines changed: 41 additions & 17 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Rubberduck.Resources/Inspections/InspectionInfo.resx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -365,12 +365,12 @@ If the parameter can be null, ignore this inspection result; passing a null valu
365365
<value>Module attributes are not displayed in the VBE. By adding an annotation, you make these attributes more explicit, and Rubberduck can keep annotations and attributes synchronized.</value>
366366
</data>
367367
<data name="KeywordsUsedAsMemberInspection" xml:space="preserve">
368-
<value>A keyword is being used as a member in either an enumeration or an user defined type. That can lead to ambiguous resolution. Condier renaming.</value>
368+
<value>A keyword is being used as a member in either an enumeration or an user defined type. That can lead to ambiguous resolution. Consider renaming the member.</value>
369369
</data>
370370
<data name="LineContinuationBetweenKeywordsInspection" xml:space="preserve">
371371
<value>There are line continuations between keywords. There is no good reason to put it there; consider removing them altogether</value>
372372
</data>
373373
<data name="NonBreakingSpaceIdentifierInspection" xml:space="preserve">
374-
<value>The identiifer contains a non-breaking space which looks very much like just an ordinary space, which obfsucates the code and makes for a confusing experience. Consider using only latin characters for the identifiers.</value>
374+
<value>The identiifer contains a non-breaking space which looks very much like just an ordinary space, which obfsucates the code and makes for a confusing experience. Consider using visible characters for the identifiers.</value>
375375
</data>
376376
</root>

Rubberduck.Resources/Inspections/InspectionResults.Designer.cs

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Rubberduck.Resources/Inspections/InspectionResults.resx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -398,14 +398,14 @@
398398
<comment>{0} module; {1} specified attribute; {2} specified values</comment>
399399
</data>
400400
<data name="KeywordsUsedAsMemberInspection" xml:space="preserve">
401-
<value>Keyword used as an identifier for the member {0}</value>
401+
<value>Keyword used as an identifier for the member '{0}'</value>
402402
<comment>{0} Member name</comment>
403403
</data>
404404
<data name="LineContinuationBetweenKeywordsInspection" xml:space="preserve">
405405
<value>Line continuation(s) in unexpected places. </value>
406406
</data>
407407
<data name="NonBreakingSpaceIdentifierInspection" xml:space="preserve">
408-
<value>Non-breaking space encountered in identifier {0}</value>
408+
<value>Non-breaking space encountered in identifier '{0}'</value>
409409
<comment>{0} Identifier</comment>
410410
</data>
411411
<data name="ThunderCode_Base" xml:space="preserve">

Rubberduck.Resources/Rubberduck.Resources.csproj

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,11 @@
2222
</Compile>
2323
</ItemGroup>
2424
<ItemGroup>
25+
<Compile Update="Inspections\InspectionInfo.Designer.cs">
26+
<DesignTime>True</DesignTime>
27+
<AutoGen>True</AutoGen>
28+
<DependentUpon>InspectionInfo.resx</DependentUpon>
29+
</Compile>
2530
<Compile Update="Inspections\InspectionNames.Designer.cs">
2631
<DesignTime>True</DesignTime>
2732
<AutoGen>True</AutoGen>
@@ -39,6 +44,10 @@
3944
</Compile>
4045
</ItemGroup>
4146
<ItemGroup>
47+
<EmbeddedResource Update="Inspections\InspectionInfo.resx">
48+
<Generator>PublicResXFileCodeGenerator</Generator>
49+
<LastGenOutput>InspectionInfo.Designer.cs</LastGenOutput>
50+
</EmbeddedResource>
4251
<EmbeddedResource Update="Inspections\InspectionNames.resx">
4352
<Generator>PublicResXFileCodeGenerator</Generator>
4453
<LastGenOutput>InspectionNames.Designer.cs</LastGenOutput>

RubberduckTests/Inspections/ThunderCode/ThunderCodeInspectionTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ Private Enum HawHaw
5555
// NOTE: the inspection only covers trivial cases and is not exhaustive
5656
// For that reason, some of test cases which the evil continuations exists
5757
// may still pass without any results. To cover them all would likely be too
58-
// expensie.
58+
// expensive.
5959
[Test]
6060
[TestCase(1, @"Private Sub Foo()
6161
End _

0 commit comments

Comments
 (0)