Fixed overenthousiastic use of Task.Start

Author: Vogel612

Rubberduck.Parsing/VBA/ComponentParseTask.cs

@@ -37,13 +37,8 @@ public ComponentParseTask(VBComponent vbComponent, VBAPreprocessor preprocessor,
             _rewriter = rewriter;
             _qualifiedName = new QualifiedModuleName(vbComponent); 
         }
-
-        public Task ParseAsync(CancellationToken token)
-        {
-            return new Task(() => ParseInternal(token));
-        }
-
-        private void ParseInternal(CancellationToken token)
+        
+        public void Start(CancellationToken token)
         {
             try
             {
@@ -142,12 +137,7 @@ private IEnumerable<CommentNode> QualifyAndUnionComments(QualifiedModuleName qua
             var allCommentNodes = commentNodes.Union(remCommentNodes);
             return allCommentNodes;
         }
-
-        public void Parse()
-        {
-            ParseAsync(CancellationToken.None).Wait();
-        }
-
+        
         public class ParseCompletionArgs
         {
             public ITokenStream Tokens { get; internal set; }

Rubberduck.Parsing/VBA/RubberduckParserReimpl.cs

@@ -120,12 +120,9 @@ public Task ParseAsync(VBComponent component, CancellationToken token, TokenStre
 
             var task = new Task(() => ParseAsyncInternal(component, linkedTokenSource.Token, rewriter));
             _currentTasks.Add(component, Tuple.Create(task, linkedTokenSource));
-
             task.ContinueWith(t => _currentTasks.Remove(component)); // default also executes on cancel
 
-            _state.SetModuleState(component, ParserState.Parsing);
             task.Start();
-
             return task;
         }
 
@@ -160,9 +157,8 @@ private void ParseAsyncInternal(VBComponent component, CancellationToken token,
                 _state.AddTokenStream(component, e.Tokens);
                 _state.SetModuleComments(component, e.Comments);
             };
-            var task = parser.ParseAsync(token);
             _state.SetModuleState(component, ParserState.Parsing);
-            task.Start();
+            parser.Start(token);
         }
 
         public void ParseComponent(VBComponent component, TokenStreamRewriter rewriter = null)
@@ -208,6 +204,8 @@ private void ResolveDeclarations(VBComponent component, IParseTree tree)
             var emptyStringLiteralListener = new EmptyStringLiteralListener();
             var argListWithOneByRefParamListener = new ArgListWithOneByRefParamListener();
 
+            // FIXME account for errors here
+
             var walker = new ParseTreeWalker();
             walker.Walk(new CombinedParseTreeListener(new IParseTreeListener[]{
                 obsoleteCallStatementListener,