Add abstract Predicate guard clause to base class

Author: BZngr

Rubberduck.Refactorings/DeleteDeclarations/Abstract/DeleteElementsRefactoringActionBase.cs

@@ -31,6 +31,8 @@ public DeleteElementsRefactoringActionBase(IDeclarationFinderProvider declaratio
             _declarationDeletionGroupsGenerator = deletionGroupsGeneratorFactory.Create();
         }
 
+        protected abstract bool CanRefactorAllTargets(TModel model);
+
         protected void DeleteDeclarations(IDeleteDeclarationsModel model, 
             IRewriteSession rewriteSession, 
             Func<IEnumerable<Declaration>, IRewriteSession, IDeclarationDeletionTargetFactory, IEnumerable<IDeclarationDeletionTarget>> generateDeletionTargets)

Rubberduck.Refactorings/DeleteDeclarations/DeleteEnumMembers/DeleteEnumMembersRefactoringAction.cs

@@ -18,12 +18,15 @@ public DeleteEnumMembersRefactoringAction(IDeclarationFinderProvider declaration
 
         public override void Refactor(DeleteEnumMembersModel model, IRewriteSession rewriteSession)
         {
-            if (model.Targets.Any(t => t.DeclarationType != DeclarationType.EnumerationMember))
+            if (!CanRefactorAllTargets(model))
             {
                 throw new InvalidOperationException("Only DeclarationType.EnumerationMember can be refactored by this class");
             }
 
             DeleteDeclarations(model, rewriteSession, (declarations, rewriterSession, targetFactory) => targetFactory.CreateMany(declarations, rewriteSession));
         }
+
+        protected override bool CanRefactorAllTargets(DeleteEnumMembersModel model) 
+            => model.Targets.All(t => t.DeclarationType == DeclarationType.EnumerationMember);
     }
 }

Rubberduck.Refactorings/DeleteDeclarations/DeleteModuleElements/DeleteModuleElementsRefactoringAction.cs

@@ -20,14 +20,17 @@ public DeleteModuleElementsRefactoringAction(IDeclarationFinderProvider declarat
 
         public override void Refactor(DeleteModuleElementsModel model, IRewriteSession rewriteSession)
         {
-            if (model.Targets.Any(t => !(t.ParentDeclaration is ModuleDeclaration)))
+            if (!CanRefactorAllTargets(model))
             {
                 throw new InvalidOperationException("Only module-scope declarations can be refactored by this object");
             }
 
             DeleteDeclarations(model, rewriteSession, base.CreateDeletionTargetsSupportingPartialDeletions);
         }
 
+        protected override bool CanRefactorAllTargets(DeleteModuleElementsModel model)
+            => model.Targets.All(t => t.ParentDeclaration is ModuleDeclaration);
+
         protected override VBAParser.EndOfStatementContext GetPrecedingNonDeletedEOSContextForGroup(IDeclarationDeletionGroup deletionGroup)
         {
             var deleteTarget = deletionGroup.Targets.FirstOrDefault();

Rubberduck.Refactorings/DeleteDeclarations/DeleteProcedureScopeElements/DeleteProcedureScopeElementsRefactoringAction.cs

@@ -23,14 +23,17 @@ public DeleteProcedureScopeElementsRefactoringAction(IDeclarationFinderProvider
 
         public override void Refactor(DeleteProcedureScopeElementsModel model, IRewriteSession rewriteSession)
         {
-            if (model.Targets.Any(t => t.ParentDeclaration is ModuleDeclaration))
+            if (!CanRefactorAllTargets(model))
             {
-                throw new InvalidOperationException("Only declarations within procedures can be refactored by this object");
+                throw new InvalidOperationException("Only declarations within procedures other than parameters can be refactored by this object");
             }
 
             DeleteDeclarations(model, rewriteSession, CreateDeletionTargetsLocalScope);
         }
 
+        protected override bool CanRefactorAllTargets(DeleteProcedureScopeElementsModel model)
+            => model.Targets.All(t => t.ParentDeclaration.DeclarationType.HasFlag(DeclarationType.Member) && !t.DeclarationType.HasFlag(DeclarationType.Parameter));
+
         //Creating local targets are the same as creating a module level deletion targets except that Labels 
         //need to be accounted for
         private IEnumerable<IDeclarationDeletionTarget> CreateDeletionTargetsLocalScope(IEnumerable<Declaration> declarations, IRewriteSession rewriteSession, IDeclarationDeletionTargetFactory targetFactory)

Rubberduck.Refactorings/DeleteDeclarations/DeleteUdtMembers/DeleteUDTMembersRefactoringAction.cs

@@ -18,12 +18,15 @@ public DeleteUDTMembersRefactoringAction(IDeclarationFinderProvider declarationF
 
         public override void Refactor(DeleteUDTMembersModel model, IRewriteSession rewriteSession)
         {
-            if (model.Targets.Any(t => t.DeclarationType != DeclarationType.UserDefinedTypeMember))
+            if (!CanRefactorAllTargets(model))
             {
                 throw new InvalidOperationException("Only DeclarationType.UserDefinedTypeMember can be refactored by this class");
             }
 
             DeleteDeclarations(model, rewriteSession, (declarations, rewriterSession, targetFactory) => targetFactory.CreateMany(declarations, rewriteSession));
         }
+
+        protected override bool CanRefactorAllTargets(DeleteUDTMembersModel model)
+             => model.Targets.Any(t => t.DeclarationType == DeclarationType.UserDefinedTypeMember);
     }
 }