Make the unnecessary abstract member concrete to make it less confusing to use with the model

Author: bclothier

Rubberduck.Core/UI/Refactorings/ExtractInterface/ExtractInterfacePresenter.cs

@@ -8,12 +8,7 @@ namespace Rubberduck.UI.Refactorings.ExtractInterface
     internal class ExtractInterfacePresenter : RefactoringPresenterBase<ExtractInterfaceModel, ExtractInterfaceDialog, ExtractInterfaceView, ExtractInterfaceViewModel>, IExtractInterfacePresenter
     {
         public ExtractInterfacePresenter(ExtractInterfaceModel model,
-            IRefactoringDialogFactory dialogFactory) : base(model, dialogFactory)
-        {
-            ViewModel = dialogFactory.CreateViewModel<ExtractInterfaceModel, ExtractInterfaceViewModel>(model);
-        }
-
-        public override ExtractInterfaceViewModel ViewModel { get; }
+            IRefactoringDialogFactory dialogFactory) : base(model, dialogFactory) { }
 
         public override ExtractInterfaceModel Show()
         {

Rubberduck.Core/UI/Refactorings/RefactoringPresenterBase.cs

@@ -19,9 +19,9 @@ protected RefactoringPresenterBase(TModel model, IRefactoringDialogFactory facto
             Dialog = _factory.CreateDialog<TModel, TView, TViewModel, TDialog>(model, view, viewModel);
         }
 
-        public TModel Model => Dialog.Model;
         public TDialog Dialog { get; }
-        public abstract TViewModel ViewModel { get; }
+        public TModel Model => Dialog.Model;
+        public TViewModel ViewModel => Dialog.ViewModel;
         public virtual RefactoringDialogResult DialogResult { get; protected set; }
 
         public virtual TModel Show()

Rubberduck.Core/UI/Refactorings/RemoveParameters/RemoveParametersPresenter.cs

@@ -13,12 +13,9 @@ internal class RemoveParametersPresenter : RefactoringPresenterBase<RemoveParame
         public RemoveParametersPresenter(RemoveParametersModel model,
             IRefactoringDialogFactory dialogFactory, IMessageBox messageBox) : base(model, dialogFactory)
         {
-            ViewModel = dialogFactory.CreateViewModel<RemoveParametersModel, RemoveParametersViewModel>(model);
             _messageBox = messageBox;
         }
 
-        public override RemoveParametersViewModel ViewModel { get; }
-
         public override RemoveParametersModel Show()
         {
             if (Model.TargetDeclaration == null)

Rubberduck.Core/UI/Refactorings/Rename/RenamePresenter.cs

@@ -6,14 +6,7 @@ namespace Rubberduck.UI.Refactorings.Rename
 {
     internal class RenamePresenter : RefactoringPresenterBase<RenameModel, IRefactoringDialog<RenameModel, IRefactoringView<RenameModel>, IRefactoringViewModel<RenameModel>>, IRefactoringView<RenameModel>, IRefactoringViewModel<RenameModel>>, IRenamePresenter
     {
-        private readonly RenameViewModel _viewModel;
-
-        public RenamePresenter(RenameModel model, IRefactoringDialogFactory dialogFactory) : base(model, dialogFactory)
-        {
-            _viewModel = dialogFactory.CreateViewModel<RenameModel, RenameViewModel>(model);
-        }
-
-        public override IRefactoringViewModel<RenameModel> ViewModel => _viewModel;
+        public RenamePresenter(RenameModel model, IRefactoringDialogFactory dialogFactory) : base(model, dialogFactory) { }
 
         public override RenameModel Show()
         {
@@ -28,16 +21,14 @@ public RenameModel Show(Declaration target)
             }
 
             Model.Target = target;
-            _viewModel.Target = target;
 
             var model = Show();
 
             if (DialogResult != RefactoringDialogResult.Execute)
             {
                 return null;
             }
-
-            //Model.NewName = _viewModel.NewName;
+            
             return model;
         }
     }

Rubberduck.Core/UI/Refactorings/ReorderParameters/ReorderParametersPresenter.cs

@@ -14,12 +14,9 @@ internal class ReorderParametersPresenter : RefactoringPresenterBase<ReorderPara
         public ReorderParametersPresenter(ReorderParametersModel model,
             IRefactoringDialogFactory dialogFactory, IMessageBox messageBox) : base(model, dialogFactory)
         {
-            ViewModel = dialogFactory.CreateViewModel<ReorderParametersModel, ReorderParametersViewModel>(model);
             _messageBox = messageBox;
         }
 
-        public override ReorderParametersViewModel ViewModel { get; }
-
         public override ReorderParametersModel Show()
         {
             if (Model.TargetDeclaration == null) { return null; }