Extracted common interface

Author: rubberduck203

RetailCoder.VBE/Rubberduck.csproj

@@ -407,9 +407,10 @@
     <Compile Include="UI\SourceControl\IDeleteBranchView.cs" />
     <Compile Include="UI\SourceControl\IMergeView.cs" />
     <Compile Include="UI\SourceControl\IProviderPresenter.cs" />
+    <Compile Include="UI\SourceControl\IRefreshableView.cs" />
     <Compile Include="UI\SourceControl\ISettingsView.cs" />
     <Compile Include="UI\SourceControl\ISourceControlView.cs" />
-    <Compile Include="UI\SourceControl\IUnsyncedCommitsView.cs" />
+    <Compile Include="UI\SourceControl\IUnSyncedCommitsView.cs" />
     <Compile Include="UI\SourceControl\MergeForm.cs">
       <SubType>Form</SubType>
     </Compile>

RetailCoder.VBE/UI/SourceControl/BranchesPresenter.cs

@@ -6,9 +6,8 @@
 
 namespace Rubberduck.UI.SourceControl
 {
-    public interface IBranchesPresenter : IProviderPresenter
+    public interface IBranchesPresenter : IProviderPresenter, IRefreshable
     {
-        void RefreshView();
         event EventHandler<EventArgs> BranchChanged;
     }
 

RetailCoder.VBE/UI/SourceControl/ChangesPresenter.cs

@@ -5,9 +5,8 @@
 
 namespace Rubberduck.UI.SourceControl
 {
-    public interface IChangesPresenter : IProviderPresenter
+    public interface IChangesPresenter : IProviderPresenter, IRefreshable
     {
-        void Refresh();
         void Commit();
     }
 
@@ -47,7 +46,7 @@ private bool ShouldEnableCommit()
             return !string.IsNullOrEmpty(_view.CommitMessage) && _view.CommitAction != CommitAction.Unset;
         }
 
-        public void Refresh()
+        public void RefreshView()
         {
             var fileStats = this.Provider.Status().ToList();
 
@@ -86,7 +85,7 @@ private void OnCommit(object sender, EventArgs e)
         {
             Commit();
             _view.CommitMessage = string.Empty;
-            Refresh();
+            RefreshView();
         }
     }
 }

RetailCoder.VBE/UI/SourceControl/IRefreshableView.cs

@@ -0,0 +1,7 @@
+namespace Rubberduck.UI.SourceControl
+{
+    public interface IRefreshable
+    {
+        void RefreshView();
+    }
+}

RetailCoder.VBE/UI/SourceControl/SourceControlPresenter.cs

@@ -48,7 +48,7 @@ public SourceControlPresenter
 
         private void _branchesPresenter_BranchChanged(object sender, EventArgs e)
         {
-            _changesPresenter.Refresh();
+            _changesPresenter.RefreshView();
         }
 
         private void OnInitNewRepository(object sender, EventArgs e)
@@ -147,7 +147,7 @@ private void SetChildPresenterSourceControlProviders(ISourceControlProvider prov
             _unsyncedPresenter.Provider = provider;
 
             _branchesPresenter.RefreshView();
-            _changesPresenter.Refresh();
+            _changesPresenter.RefreshView();
             // Purposely not refreshing settingsPresenter.
             //  Settings it's provider doesn't affect it's view.
         }

RetailCoder.VBE/UI/SourceControl/UnsyncedCommitsPresenter.cs

@@ -7,10 +7,8 @@
 
 namespace Rubberduck.UI.SourceControl
 {
-    public interface IUnsyncedCommitsPresenter
+    public interface IUnsyncedCommitsPresenter : IProviderPresenter, IRefreshable
     {
-        ISourceControlProvider Provider { get; set; }
-        void Refresh();
     }
 
     public class UnsyncedCommitsPresenter : IUnsyncedCommitsPresenter
@@ -51,7 +49,7 @@ void OnSync(object sender, EventArgs e)
             Provider.Push();
         }
 
-        public void Refresh()
+        public void RefreshView()
         {
             if (this.Provider != null)
             {

RubberduckTests/SourceControl/ChangesPresenterTests.cs

@@ -111,7 +111,7 @@ public void RefreshDisplaysChangedFiles()
 
             var presenter = new ChangesPresenter(_viewMock.Object, _providerMock.Object);
             //act
-            presenter.Refresh();
+            presenter.RefreshView();
 
             //Assert
             Assert.AreEqual(2, _viewMock.Object.IncludedChanges.Count, "Incorrect Included Changes");
@@ -184,7 +184,7 @@ public void ExcludedIsClearedAfterRefresh()
             Assert.IsTrue(_viewMock.Object.ExcludedChanges.Any(), "No changes found prior to refresh. Issue with Test code.");
 
             //act
-            presenter.Refresh();
+            presenter.RefreshView();
 
             //
             Assert.IsFalse(_viewMock.Object.ExcludedChanges.Any());

RubberduckTests/SourceControl/SCPresenterTests.cs

@@ -93,7 +93,7 @@ private void SetupValidVbProject()
         private void VerifyOffline()
         {
             Assert.AreEqual("Offline", _view.Object.Status);
-            _changesPresenter.Verify(c => c.Refresh(), Times.Never);
+            _changesPresenter.Verify(c => c.RefreshView(), Times.Never);
             _branchesPresenter.Verify(b => b.RefreshView(), Times.Never);
         }
 
@@ -178,7 +178,7 @@ public void ChangesRefreshOnRefreshEvent()
                 _view.Raise(v => v.RefreshData += null, new EventArgs());
 
             //assert
-            _changesPresenter.Verify(c => c.Refresh(), Times.Once);
+            _changesPresenter.Verify(c => c.RefreshView(), Times.Once);
         }
 
         [TestMethod]

RubberduckTests/SourceControl/UnsyncedCommitsPresenterTests.cs

@@ -44,7 +44,7 @@ public void UnsyncedPresenter_AfterRefresh_ViewBranchIsCurrentBranch()
             //Arrange
 
             //Act
-            _presenter.Refresh();
+            _presenter.RefreshView();
 
             //Assert
             Assert.AreEqual(_initialBranch.Name, _view.Object.CurrentBranch);
@@ -56,7 +56,7 @@ public void UnsyncedPresenter_AfterRefresh_IncomingCommitsAreDisplayed()
             //Arrange
 
             //Act
-            _presenter.Refresh();
+            _presenter.RefreshView();
 
             //Assert
             CollectionAssert.AreEquivalent(_provider.Object.UnsyncedRemoteCommits.ToList(), _view.Object.IncomingCommits.ToList());
@@ -68,7 +68,7 @@ public void UnsyncedPresenter_AfterRefresh_OutgoingCommitsAreDisplayed()
             //Arrange
 
             //Act
-            _presenter.Refresh();
+            _presenter.RefreshView();
 
             //Assert
             CollectionAssert.AreEquivalent(_provider.Object.UnsyncedLocalCommits.ToList(), _view.Object.OutgoingCommits.ToList());