Clean up GridViewSort, add broken test

Author: Hosch250

RetailCoder.VBE/UI/GridViewSort.cs

@@ -8,25 +8,24 @@ public class GridViewSort<T>
         private bool _sortedAscending;
         private string _columnName;
 
-        public GridViewSort(string ColumnName, bool SortedAscending)
+        public GridViewSort(string columnName, bool sortedAscending)
         {
-            _columnName = ColumnName;
-            _sortedAscending = SortedAscending;
+            _columnName = columnName;
+            _sortedAscending = sortedAscending;
         }
 
-        public IEnumerable<T> Sort(IEnumerable<T> Items, string ColumnName)
+        public IEnumerable<T> Sort(IEnumerable<T> items, string columnName)
         {
-            if (ColumnName == _columnName && _sortedAscending)
+            if (columnName == _columnName && _sortedAscending)
             {
                 _sortedAscending = false;
-                var test = Items.Select(x => x.GetType().GetProperty(ColumnName).GetValue(x));
-                return Items.OrderByDescending(x => x.GetType().GetProperty(ColumnName).GetValue(x));
+                return items.OrderByDescending(x => x.GetType().GetProperty(columnName).GetValue(x));
             }
             else
             {
-                _columnName = ColumnName;
+                _columnName = columnName;
                 _sortedAscending = true;
-                return Items.OrderBy(x => x.GetType().GetProperty(ColumnName).GetValue(x));
+                return items.OrderBy(x => x.GetType().GetProperty(columnName).GetValue(x));
             }
         }
     }

RubberduckTests/TodoControllerTests.cs

@@ -1,4 +1,5 @@
-using System.Collections.Generic;
+using System;
+using System.Collections.Generic;
 using Microsoft.VisualStudio.TestTools.UnitTesting;
 using Moq;
 using Rubberduck.Settings;
@@ -109,5 +110,24 @@ public void MarkerChangeSavedOnPriorityChanged()
 
             Assert.AreEqual(view.ActiveMarkerPriority, view.TodoMarkers[0].Priority);
         }
+
+        [TestMethod]
+        public void RemoveReallyDoesRemoveSelectedItem()
+        {
+            var markers = GetTestMarkers();
+
+            var view = new TodoListSettingsUserControl(markers, new Mock<GridViewSort<ToDoMarker>>("", false).Object);
+            view.RemoveMarker += RemoveParam;
+            view.SelectedIndex = 2;
+
+            RemoveParam(null, EventArgs.Empty);
+
+            Assert.AreEqual(2, view.TodoMarkers.Count);
+        }
+
+        private void RemoveParam(object sender, EventArgs e)
+        {
+            
+        }
     }
 }