fixed key exceptions in finder, unused parameter in ModulesReferencedBy

Author: retailcoder

Rubberduck.Parsing/Symbols/DeclarationFinder.cs

@@ -253,7 +253,10 @@ public IEnumerable<Declaration> FindAllInterfaceImplementingMembers()
 
         public Declaration FindParameter(Declaration procedure, string parameterName)
         {
-            return _parametersByParent[procedure].SingleOrDefault(parameter => parameter.IdentifierName == parameterName);
+            ConcurrentBag<Declaration> parameters;
+            return _parametersByParent.TryGetValue(procedure, out parameters) 
+                ? parameters.SingleOrDefault(parameter => parameter.IdentifierName == parameterName) 
+                : null;
         }
 
         public IEnumerable<Declaration> FindMemberMatches(Declaration parent, string memberName)

Rubberduck.Parsing/VBA/ParseCoordinator.cs

@@ -17,7 +17,6 @@
 using Rubberduck.VBEditor.SafeComWrappers.Abstract;
 using System.Runtime.InteropServices;
 using Rubberduck.VBEditor.Application;
-using Rubberduck.VBEditor.Extensions;
 
 // ReSharper disable LoopCanBeConvertedToQuery
 
@@ -75,8 +74,8 @@ public ParseCoordinator(
         // but the cancelees need to use their own token.
         private readonly List<CancellationTokenSource> _cancellationTokens = new List<CancellationTokenSource> { new CancellationTokenSource() };
 
-        private readonly Object _cancellationSyncObject = new Object();
-        private readonly Object _parsingRunSyncObject = new Object();
+        private readonly object _cancellationSyncObject = new object();
+        private readonly object _parsingRunSyncObject = new object();
 
         private void ReparseRequested(object sender, EventArgs e)
         {
@@ -89,7 +88,7 @@ private void ReparseRequested(object sender, EventArgs e)
 
             if (!_isTestScope)
             {
-                Task.Run(() => ParseAll(sender, token));
+                Task.Run(() => ParseAll(sender, token), token);
             }
             else
             {
@@ -295,7 +294,7 @@ private void ClearModuleToModuleReferences(ICollection<QualifiedModuleName> toCl
             }
         }
 
-        //This doesn not live on the RubberduckParserState to keep concurrency haanlding out of it.
+        //This does not live on the RubberduckParserState to keep concurrency haanlding out of it.
         public void RemoveAllReferencesBy(ICollection<QualifiedModuleName> referencesFromToRemove, ICollection<QualifiedModuleName> modulesNotNeedingReferenceRemoval, DeclarationFinder finder, CancellationToken token)
         {
             var referencedModulesNeedingReferenceRemoval = State.ModulesReferencedBy(referencesFromToRemove).Where(qmn => !modulesNotNeedingReferenceRemoval.Contains(qmn));
@@ -343,7 +342,7 @@ private void ParseComponents(ICollection<IVBComponent> components, CancellationT
             {
                 if (exception.Flatten().InnerExceptions.All(ex => ex is OperationCanceledException))
                 {
-                    throw exception.InnerException; //This eliminates the stack trace, but for the cancellation, this is irrelevant.
+                    throw exception.InnerException ?? exception; //This eliminates the stack trace, but for the cancellation, this is irrelevant.
                 }
                 State.SetStatusAndFireStateChanged(this, ParserState.Error);
                 throw;
@@ -438,7 +437,7 @@ private void ResolveAllDeclarations(ICollection<IVBComponent> components, Cancel
             {
                 if (exception.Flatten().InnerExceptions.All(ex => ex is OperationCanceledException))
                 {
-                    throw exception.InnerException; //This eliminates the stack trace, but for the cancellation, this is irrelevant.
+                    throw exception.InnerException ?? exception; //This eliminates the stack trace, but for the cancellation, this is irrelevant.
                 }
                 State.SetStatusAndFireStateChanged(this, ParserState.ResolverError);
                 throw;
@@ -537,7 +536,7 @@ private void ResolveAllReferences(ICollection<QualifiedModuleName> toResolve, Ca
             {
                 if (exception.Flatten().InnerExceptions.All(ex => ex is OperationCanceledException))
                 {
-                    throw exception.InnerException; //This eliminates the stack trace, but for the cancellation, this is irrelevant.
+                    throw exception.InnerException ?? exception; //This eliminates the stack trace, but for the cancellation, this is irrelevant.
                 }
                 State.SetStatusAndFireStateChanged(this, ParserState.ResolverError);
                 throw;
@@ -611,9 +610,12 @@ private void ResolveReferences(DeclarationFinder finder, QualifiedModuleName qua
 
         private void AddModuleToModuleReferences(DeclarationFinder finder, CancellationToken token)
         {
-            var options = new ParallelOptions();
-            options.CancellationToken = token;
-            options.MaxDegreeOfParallelism = _maxDegreeOfReferenceResolverParallelism;
+            var options = new ParallelOptions
+            {
+                CancellationToken = token,
+                MaxDegreeOfParallelism = _maxDegreeOfReferenceResolverParallelism
+            };
+
             try
             {
                 Parallel.For(0, State.ParseTrees.Count, options,
@@ -624,7 +626,7 @@ private void AddModuleToModuleReferences(DeclarationFinder finder, CancellationT
             {
                 if (exception.Flatten().InnerExceptions.All(ex => ex is OperationCanceledException))
                 {
-                    throw exception.InnerException; //This eliminates the stack trace, but for the cancellation, this is irrelevant.
+                    throw exception.InnerException ?? exception; //This eliminates the stack trace, but for the cancellation, this is irrelevant.
                 }
                 State.SetStatusAndFireStateChanged(this, ParserState.ResolverError);
                 throw;
@@ -749,9 +751,9 @@ private void ParseAllInternal(object requestor, CancellationToken token)
         /// </summary>
         private bool CleanUpRemovedComponents(ICollection<IVBComponent> components, CancellationToken token)
         {
-            var removedModuledecalrations = RemovedModuleDeclarations(components);
-            var componentRemoved = removedModuledecalrations.Any();
-            var removedModules = removedModuledecalrations.Select(declaration => declaration.QualifiedName.QualifiedModuleName).ToHashSet();
+            var removedModuleDeclarations = RemovedModuleDeclarations(components).ToArray();
+            var componentRemoved = removedModuleDeclarations.Any();
+            var removedModules = removedModuleDeclarations.Select(declaration => declaration.QualifiedName.QualifiedModuleName).ToHashSet();
             if (removedModules.Any())
             {
                 RemoveAllReferencesBy(removedModules, removedModules, State.DeclarationFinder, token);
@@ -865,7 +867,7 @@ private void SyncComReferences(IReadOnlyList<IVBProject> projects, CancellationT
             {
                 if (exception.Flatten().InnerExceptions.All(ex => ex is OperationCanceledException))
                 {
-                    throw exception.InnerException; //This eliminates the stack trace, but for the cancellation, this is irrelevant.
+                    throw exception.InnerException ?? exception; //This eliminates the stack trace, but for the cancellation, this is irrelevant.
                 }
                 State.SetStatusAndFireStateChanged(this, ParserState.Error);
                 throw;
@@ -952,7 +954,7 @@ private void LoadReference(IReference localReference, ConcurrentBag<IReference>
                 }
                 else
                 {
-                    LoadReferenceByCOMReflection(localReference, comReflector);
+                    LoadReferenceFromTypeLibrary(localReference, comReflector);
                 }
             }
             catch (Exception exception)
@@ -973,7 +975,7 @@ private void LoadReferenceByDeserialization(IReference localReference, Reference
             }
         }
 
-        private void LoadReferenceByCOMReflection(IReference localReference, ReferencedDeclarationsCollector comReflector)
+        private void LoadReferenceFromTypeLibrary(IReference localReference, ReferencedDeclarationsCollector comReflector)
         {
             Logger.Trace(string.Format("COM reflecting reference '{0}'.", localReference.Name));
             var declarations = comReflector.LoadDeclarationsFromLibrary();

Rubberduck.Parsing/VBA/RubberduckParserState.cs

@@ -1183,9 +1183,9 @@ public void ClearModuleToModuleReferencesFromModule(QualifiedModuleName referenc
                 return;
             }
 
-            ModuleState referencedModuleState;
             foreach (var referencedModule in referencingModuleState.HasReferenceToModule.Keys)
             {
+                ModuleState referencedModuleState;
                 if (!_moduleStates.TryGetValue(referencedModule,out referencedModuleState))
                 {
                     continue;
@@ -1208,7 +1208,7 @@ public HashSet<QualifiedModuleName> ModulesReferencedBy(QualifiedModuleName refe
         public HashSet<QualifiedModuleName> ModulesReferencedBy(IEnumerable<QualifiedModuleName> referencingModules)
         {
             var referencedModules = new HashSet<QualifiedModuleName>();
-            foreach (var referencingModule in referencedModules)
+            foreach (var referencingModule in referencingModules)
             {
                 referencedModules.UnionWith(ModulesReferencedBy(referencingModule));
             }