Refactor of settings, separate validation from setter

Author: bclothier

RetailCoder.VBE/UI/Settings/GeneralSettingsViewModel.cs

@@ -133,7 +133,6 @@ public bool CheckVersionAtStartup
         }
 
         private bool _compileBeforeParse;
-
         public bool CompileBeforeParse
         {
             get => _compileBeforeParse;
@@ -146,22 +145,33 @@ public bool CompileBeforeParse
 
                 if (value && _vbeSettings.CompileOnDemand)
                 {
-                    var result = _messageBox.Show(RubberduckUI.GeneralSettings_CompileBeforeParse_WarnCompileOnDemandEnabled,
-                        RubberduckUI.GeneralSettings_CompileBeforeParse_WarnCompileOnDemandEnabled_Caption, MessageBoxButtons.YesNo,
-                        MessageBoxIcon.Exclamation, MessageBoxDefaultButton.Button1);
-                    if(result == DialogResult.No)
+                    if(!SynchronizeVBESettings())
                     {
                         return;
                     }
-
-                    _vbeSettings.CompileOnDemand = false;
                 }
 
                 _compileBeforeParse = value;
                 OnPropertyChanged();
             }
         }
 
+        private bool SynchronizeVBESettings()
+        {
+            var result = _messageBox.Show(RubberduckUI.GeneralSettings_CompileBeforeParse_WarnCompileOnDemandEnabled,
+                RubberduckUI.GeneralSettings_CompileBeforeParse_WarnCompileOnDemandEnabled_Caption, MessageBoxButtons.YesNo,
+                MessageBoxIcon.Exclamation, MessageBoxDefaultButton.Button1);
+
+            if (result == DialogResult.No)
+            {
+                return false;
+            }
+
+            _vbeSettings.CompileOnDemand = false;
+            _vbeSettings.BackGroundCompile = false;
+            return true;
+        }
+
         private int _autoSavePeriod;
         public int AutoSavePeriod
         {