Add tests for ObsoleteCallingConventionInspection

Author: comintern

Rubberduck.CodeAnalysis/Inspections/Concrete/ObsoleteCallingConventionInspection.cs

@@ -1,11 +1,7 @@
-using System;
-using System.Collections.Generic;
+using System.Collections.Generic;
 using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
 using Antlr4.Runtime;
 using Rubberduck.Inspections.Abstract;
-using Rubberduck.Inspections.Concrete;
 using Rubberduck.Inspections.Results;
 using Rubberduck.Parsing;
 using Rubberduck.Parsing.Grammar;

RubberduckTests/Inspections/ObsoleteCallingConventionInspectionTests.cs

@@ -0,0 +1,120 @@
+using System.Linq;
+using System.Threading;
+using NUnit.Framework;
+using Rubberduck.Inspections.Inspections.Concrete;
+using RubberduckTests.Mocks;
+
+namespace RubberduckTests.Inspections
+{
+    [TestFixture]
+    public class ObsoleteCallingConventionInspectionTests
+    {
+        [Test]
+        [Category("Inspections")]
+        public void ObsoleteCallingConvention_ReturnsResult()
+        {
+            const string inputCode =
+@"Private Declare Sub Beep CDecl Lib ""kernel32"" (dwFreq As Any, dwDuration As Any)";
+
+            var vbe = MockVbeBuilder.BuildFromSingleStandardModule(inputCode, out _);
+            using (var state = MockParser.CreateAndParse(vbe.Object))
+            {
+
+                var inspection = new ObsoleteCallingConventionInspection(state);
+                var inspector = InspectionsHelper.GetInspector(inspection);
+                var inspectionResults = inspector.FindIssuesAsync(state, CancellationToken.None).Result;
+
+                Assert.AreEqual(1, inspectionResults.Count());
+            }
+        }
+
+        [Test]
+        [Category("Inspections")]
+        public void ObsoleteCallingConvention_DoesNotReturnResult()
+        {
+            const string inputCode =
+@"Private Declare Sub Beep Lib ""kernel32"" (dwFreq As Any, dwDuration As Any)";
+
+            var vbe = MockVbeBuilder.BuildFromSingleStandardModule(inputCode, out _);
+            using (var state = MockParser.CreateAndParse(vbe.Object))
+            {
+
+                var inspection = new ObsoleteCallingConventionInspection(state);
+                var inspector = InspectionsHelper.GetInspector(inspection);
+                var inspectionResults = inspector.FindIssuesAsync(state, CancellationToken.None).Result;
+
+                Assert.AreEqual(0, inspectionResults.Count());
+            }
+        }
+
+        [Test]
+        [Category("Inspections")]
+        public void ObsoleteCallingConvention_ReturnsMultipleResults()
+        {
+            const string inputCode =
+@"Private Declare Sub Beep CDecl Lib ""kernel32"" (dwFreq As Any, dwDuration As Any)
+Private Declare Sub Sleep CDecl Lib ""kernel32"" (ByVal dwMilliseconds As Long)";
+
+            var vbe = MockVbeBuilder.BuildFromSingleStandardModule(inputCode, out _);
+            using (var state = MockParser.CreateAndParse(vbe.Object))
+            {
+
+                var inspection = new ObsoleteCallingConventionInspection(state);
+                var inspector = InspectionsHelper.GetInspector(inspection);
+                var inspectionResults = inspector.FindIssuesAsync(state, CancellationToken.None).Result;
+
+                Assert.AreEqual(2, inspectionResults.Count());
+            }
+        }
+
+        [Test]
+        [Category("Inspections")]
+        public void ObsoleteCallingConvention_ReturnsResults_SomeObsoleteCallingConventions()
+        {
+            const string inputCode =
+@"Private Declare Sub Beep CDecl Lib ""kernel32"" (dwFreq As Any, dwDuration As Any)
+Private Declare Sub Sleep Lib ""kernel32"" (ByVal dwMilliseconds As Long)";
+
+            var vbe = MockVbeBuilder.BuildFromSingleStandardModule(inputCode, out _);
+            using (var state = MockParser.CreateAndParse(vbe.Object))
+            {
+
+                var inspection = new ObsoleteCallingConventionInspection(state);
+                var inspector = InspectionsHelper.GetInspector(inspection);
+                var inspectionResults = inspector.FindIssuesAsync(state, CancellationToken.None).Result;
+
+                Assert.AreEqual(1, inspectionResults.Count());
+            }
+        }
+
+        [Test]
+        [Category("Inspections")]
+        public void ObsoleteCallingConvention_Ignored_DoesNotReturnResult()
+        {
+            const string inputCode =
+@"'@Ignore ObsoleteCallingConvention
+Private Declare Sub Beep CDecl Lib ""kernel32"" (dwFreq As Any, dwDuration As Any)";
+
+            var vbe = MockVbeBuilder.BuildFromSingleStandardModule(inputCode, out _);
+            using (var state = MockParser.CreateAndParse(vbe.Object))
+            {
+
+                var inspection = new ObsoleteCallingConventionInspection(state);
+                var inspector = InspectionsHelper.GetInspector(inspection);
+                var inspectionResults = inspector.FindIssuesAsync(state, CancellationToken.None).Result;
+
+                Assert.IsFalse(inspectionResults.Any());
+            }
+        }
+
+        [Test]
+        [Category("Inspections")]
+        public void InspectionName()
+        {
+            const string inspectionName = "ObsoleteCallingConventionInspection";
+            var inspection = new ObsoleteCallingConventionInspection(null);
+
+            Assert.AreEqual(inspectionName, inspection.Name);
+        }
+    }
+}

RubberduckTests/RubberduckTests.csproj

@@ -106,6 +106,7 @@
     <Compile Include="CodeAnalysis\CodeMetrics\LineCountTests.cs" />
     <Compile Include="CodeExplorer\CodeExplorerTests.cs" />
     <Compile Include="FlagSanityTests.cs" />
+    <Compile Include="Inspections\ObsoleteCallingConventionInspectionTests.cs" />
     <Compile Include="Mocks\MockAddInBuilder.cs" />
     <Compile Include="Inspections\ObsoleteMemberUsageInspectionTests.cs" />
     <Compile Include="Mocks\MockVbeEvents.cs" />